From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:34962 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755538AbeDFNdX (ORCPT ); Fri, 6 Apr 2018 09:33:23 -0400 From: Laurent Pinchart To: Jacopo Mondi Cc: horms@verge.net.au, magnus.damm@gmail.com, geert@linux-m68k.org, niklas.soderlund@ragnatech.se, sergei.shtylyov@cogentembedded.com, dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Vladimir Barinov , Niklas =?ISO-8859-1?Q?S=F6derlund?= Subject: Re: [PATCH 2/7] arm64: dts: renesas: r8a77970: add VSPD support Date: Fri, 06 Apr 2018 16:33:21 +0300 Message-ID: <3172265.bfWcyC1uqx@avalon> In-Reply-To: <1523020092-25540-3-git-send-email-jacopo+renesas@jmondi.org> References: <1523020092-25540-1-git-send-email-jacopo+renesas@jmondi.org> <1523020092-25540-3-git-send-email-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Friday, 6 April 2018 16:08:07 EEST Jacopo Mondi wrote: > From: Sergei Shtylyov >=20 > Describe VSPD0 in the R8A77970 device tree; it will be used by DU in > the next patch... >=20 > Based on the original (and large) patch by Daisuke Matsushita > . >=20 > Signed-off-by: Vladimir Barinov > Signed-off-by: Sergei Shtylyov > Signed-off-by: Niklas S=F6derlund > --- > arch/arm64/boot/dts/renesas/r8a77970.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/arch/arm64/boot/dts/renesas/r8a77970.dtsi > b/arch/arm64/boot/dts/renesas/r8a77970.dtsi index 71f466d..db06c94 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77970.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77970.dtsi > @@ -625,6 +625,16 @@ > power-domains =3D <&sysc R8A77970_PD_ALWAYS_ON>; > resets =3D <&cpg 603>; > }; > + > + vspd0: vsp@fea20000 { > + compatible =3D "renesas,vsp2"; > + reg =3D <0 0xfea20000 0 0x4000>; You need to extend the memory region to include the V6_CLUTn_TBL* registers= =2E I=20 would recommend simply extending it to 0x8000 as all other VSP instances, e= ven=20 if the registers at 0x7000-0x7fff are not implemented. Apart from that, Reviewed-by: Laurent Pinchart > + interrupts =3D ; > + clocks =3D <&cpg CPG_MOD 623>; > + power-domains =3D <&sysc R8A77970_PD_ALWAYS_ON>; > + resets =3D <&cpg 623>; > + renesas,fcp =3D <&fcpvd0>; > + }; > }; >=20 > timer { =2D-=20 Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 2/7] arm64: dts: renesas: r8a77970: add VSPD support Date: Fri, 06 Apr 2018 16:33:21 +0300 Message-ID: <3172265.bfWcyC1uqx@avalon> References: <1523020092-25540-1-git-send-email-jacopo+renesas@jmondi.org> <1523020092-25540-3-git-send-email-jacopo+renesas@jmondi.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1523020092-25540-3-git-send-email-jacopo+renesas@jmondi.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jacopo Mondi Cc: devicetree@vger.kernel.org, Niklas =?ISO-8859-1?Q?S=F6derlund?= , sergei.shtylyov@cogentembedded.com, magnus.damm@gmail.com, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Vladimir Barinov , linux-renesas-soc@vger.kernel.org, horms@verge.net.au, geert@linux-m68k.org, niklas.soderlund@ragnatech.se List-Id: devicetree@vger.kernel.org T24gRnJpZGF5LCA2IEFwcmlsIDIwMTggMTY6MDg6MDcgRUVTVCBKYWNvcG8gTW9uZGkgd3JvdGU6 Cj4gRnJvbTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5b3ZAY29nZW50ZW1iZWRkZWQu Y29tPgo+IAo+IERlc2NyaWJlIFZTUEQwIGluIHRoZSBSOEE3Nzk3MCBkZXZpY2UgdHJlZTsgaXQg d2lsbCBiZSB1c2VkIGJ5IERVIGluCj4gdGhlIG5leHQgcGF0Y2guLi4KPiAKPiBCYXNlZCBvbiB0 aGUgb3JpZ2luYWwgKGFuZCBsYXJnZSkgcGF0Y2ggYnkgRGFpc3VrZSBNYXRzdXNoaXRhCj4gPGRh aXN1a2UubWF0c3VzaGl0YS5uc0BoaXRhY2hpLmNvbT4uCj4gCj4gU2lnbmVkLW9mZi1ieTogVmxh ZGltaXIgQmFyaW5vdiA8dmxhZGltaXIuYmFyaW5vdkBjb2dlbnRlbWJlZGRlZC5jb20+Cj4gU2ln bmVkLW9mZi1ieTogU2VyZ2VpIFNodHlseW92IDxzZXJnZWkuc2h0eWx5b3ZAY29nZW50ZW1iZWRk ZWQuY29tPgo+IFNpZ25lZC1vZmYtYnk6IE5pa2xhcyBTw7ZkZXJsdW5kIDxuaWtsYXMuc29kZXJs dW5kK3JlbmVzYXNAcmFnbmF0ZWNoLnNlPgo+IC0tLQo+ICBhcmNoL2FybTY0L2Jvb3QvZHRzL3Jl bmVzYXMvcjhhNzc5NzAuZHRzaSB8IDEwICsrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQsIDEw IGluc2VydGlvbnMoKykKPiAKPiBkaWZmIC0tZ2l0IGEvYXJjaC9hcm02NC9ib290L2R0cy9yZW5l c2FzL3I4YTc3OTcwLmR0c2kKPiBiL2FyY2gvYXJtNjQvYm9vdC9kdHMvcmVuZXNhcy9yOGE3Nzk3 MC5kdHNpIGluZGV4IDcxZjQ2NmQuLmRiMDZjOTQgMTAwNjQ0Cj4gLS0tIGEvYXJjaC9hcm02NC9i b290L2R0cy9yZW5lc2FzL3I4YTc3OTcwLmR0c2kKPiArKysgYi9hcmNoL2FybTY0L2Jvb3QvZHRz L3JlbmVzYXMvcjhhNzc5NzAuZHRzaQo+IEBAIC02MjUsNiArNjI1LDE2IEBACj4gIAkJCXBvd2Vy LWRvbWFpbnMgPSA8JnN5c2MgUjhBNzc5NzBfUERfQUxXQVlTX09OPjsKPiAgCQkJcmVzZXRzID0g PCZjcGcgNjAzPjsKPiAgCQl9Owo+ICsKPiArCQl2c3BkMDogdnNwQGZlYTIwMDAwIHsKPiArCQkJ Y29tcGF0aWJsZSA9ICJyZW5lc2FzLHZzcDIiOwo+ICsJCQlyZWcgPSA8MCAweGZlYTIwMDAwIDAg MHg0MDAwPjsKCllvdSBuZWVkIHRvIGV4dGVuZCB0aGUgbWVtb3J5IHJlZ2lvbiB0byBpbmNsdWRl IHRoZSBWNl9DTFVUbl9UQkwqIHJlZ2lzdGVycy4gSSAKd291bGQgcmVjb21tZW5kIHNpbXBseSBl eHRlbmRpbmcgaXQgdG8gMHg4MDAwIGFzIGFsbCBvdGhlciBWU1AgaW5zdGFuY2VzLCBldmVuIApp ZiB0aGUgcmVnaXN0ZXJzIGF0IDB4NzAwMC0weDdmZmYgYXJlIG5vdCBpbXBsZW1lbnRlZC4KCkFw YXJ0IGZyb20gdGhhdCwKClJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBp bmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cgo+ICsJCQlpbnRlcnJ1cHRzID0gPEdJQ19TUEkgMTY5 IElSUV9UWVBFX0xFVkVMX0hJR0g+Owo+ICsJCQljbG9ja3MgPSA8JmNwZyBDUEdfTU9EIDYyMz47 Cj4gKwkJCXBvd2VyLWRvbWFpbnMgPSA8JnN5c2MgUjhBNzc5NzBfUERfQUxXQVlTX09OPjsKPiAr CQkJcmVzZXRzID0gPCZjcGcgNjIzPjsKPiArCQkJcmVuZXNhcyxmY3AgPSA8JmZjcHZkMD47Cj4g KwkJfTsKPiAgCX07Cj4gCj4gIAl0aW1lciB7CgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hh cnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==