Re: [PATCH] ethdev: fix port ID retrieval on vdev attach

[Thomas Monjalon <thomas@monjalon.net>]

11/07/2018 11:49, Andrew Rybchenko:
> From: Ivan Malov <ivan.malov@oktetlabs.ru>
> 
> Attaching a vdev port may result in multiple
> ports actually added because a vdev port may
> have slave devices to be attached implicitly.
> 
> Ethdev attach API has to fill in the port ID
> to be read back by the user and what it does
> is take the last assigned ID from the common
> list after attach completion. Such an ID may
> belong to a slave device and not to the vdev.
> 
> This mistake must be precluded by requesting
> the port ID by name of device being attached.

No, the real issue is using this function rte_eth_dev_attach.
It is broken since day 1.
Mixing EAL devargs and ethdev port cannot work by design.

If you want to attach a device, you must add it with
	rte_eal_hotplug_add
and wait for the driver to probe the ports
(which can be ethdev or other classes).

We should take these actions in 18.08:
	- deprecate rte_eth_dev_attach/rte_eth_dev_detach
	- deprecate rte_eal_dev_attach/rte_eal_dev_detach
I did not take time to send the deprecation notices yet.
Feel free to deprecate these functions yourself.