From: Thomas Monjalon <thomas@monjalon.net>
To: Hajkowski <marcinx.hajkowski@intel.com>,
david.hunt@intel.com, "Burakov,
Anatoly" <anatoly.burakov@intel.com>,
bruce.richardson@intel.com, anatoly.burakov@intel.com
Cc: dev@dpdk.org, david.marchand@redhat.com, ferruh.yigit@intel.com,
andrew.rybchenko@oktetlabs.ru, john.mcnamara@intel.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 1/4] power: fix non thread-safe power env modification
Date: Sun, 25 Oct 2020 19:22:24 +0100 [thread overview]
Message-ID: <3176678.oQ72JnNS2j@thomas> (raw)
In-Reply-To: <fe336745-19bc-8a65-77c8-c5782696875d@intel.com>
29/03/2019 16:09, Burakov, Anatoly:
> On 29-Mar-19 2:14 PM, Thomas Monjalon wrote:
> > 18/03/2019 12:56, Hajkowski:
> >> From: Marcin Hajkowski <marcinx.hajkowski@intel.com>
> >> --- a/doc/guides/rel_notes/release_19_05.rst
> >> +++ b/doc/guides/rel_notes/release_19_05.rst
> >> @@ -120,6 +120,8 @@ API Changes
> >> + * power: ``rte_power_set_env`` and ``rte_power_unset_env`` functions
> >> + have been modified to be thread safe.
> >
> > The deprecation notice was recently sent,
> > so I guess this patch is for DPDK 19.08.
>
> Yes, this is changing API so the target was 19.08. However, first patch
> is a fix and can be applied to 19.05 as well. The API documentation
> stated that the function was not thread safe, but the code itself was
> thread safe (it wasn't because it was buggy, but the intention of being
> thread safe was there), so this could be considered fixing docs to match
> the intended behavior of the code.
>
> > Review from the maintainer (David) may help.
> > Thanks
What is the follow-up here?
We still have an old deprecation notice:
http://git.dpdk.org/dpdk/commit/?id=3477b7a2cc
I wonder how such things can be forgotten.
I feel some help is needed in prioritization,
so let's consider this deprecation as the priority #1
gating any other change in the power library.
Priority #2: cleaning up API which are secretly exported
for example convenience. It is an old design issue never fixed:
http://inbox.dpdk.org/dev/6046120.mQ0ExDuKPD@thomas/
Priority #3: request feedbacks from other maintainers
to add a generic API in ethdev to get a hook for power management.
next prev parent reply other threads:[~2020-10-25 18:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 11:56 [PATCH v2 1/4] power: fix non thread-safe power env modification Hajkowski
2019-03-18 11:56 ` [PATCH v2 2/4] power: return error in set env when power env already set Hajkowski
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-18 11:56 ` [PATCH v2 3/4] power: reset function pointers on unset env Hajkowski
2019-03-19 10:58 ` Burakov, Anatoly
2019-03-18 11:56 ` [PATCH v2 4/4] power: add UTs for all power env types Hajkowski
2019-03-19 11:58 ` Burakov, Anatoly
2019-03-18 15:01 ` [PATCH v2 1/4] power: fix non thread-safe power env modification Stephen Hemminger
2019-03-19 10:57 ` Burakov, Anatoly
2019-03-29 14:14 ` [dpdk-stable] " Thomas Monjalon
2019-03-29 15:09 ` Burakov, Anatoly
2020-10-25 18:22 ` Thomas Monjalon [this message]
2020-10-28 13:53 ` [dpdk-dev] " David Hunt
2020-10-28 14:16 ` Thomas Monjalon
2019-04-05 14:35 ` [dpdk-dev] [PATCH] " Hajkowski
2019-04-22 20:22 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3176678.oQ72JnNS2j@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=david.hunt@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marcinx.hajkowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.