From: Thomas Monjalon <thomas@monjalon.net>
To: Timothy Redaelli <tredaelli@redhat.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
stable@dpdk.org, bruce.richardson@intel.com, dev@dpdk.org,
david.marchand@redhat.com, maxime.coquelin@redhat.com,
ferruh.yigit@intel.com, Ali Alnubani <alialnu@nvidia.com>,
ktraynor@redhat.com
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL
Date: Wed, 25 Nov 2020 23:54:18 +0100 [thread overview]
Message-ID: <3188166.28SImnAznb@thomas> (raw)
In-Reply-To: <cover.1606229937.git.tredaelli@redhat.com>
24/11/2020 16:13, Timothy Redaelli:
> Currently eal only tries to find shared lib by looking for .so files,
> but on Fedora, CentOS and RHEL the .so file is not installed by dpdk
> package, but it's only installed by dpdk-devel package, since .so files
> should not be necessary in order to run a program [1].
>
> This series fix that by checking for .so.ABI_VERSION that should be
> available on any linux distribution.
>
> [1] https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
>
> Timothy Redaelli (2):
> eal: fix shared lib mode detection
> eal: fix loading of shared libs from driver plugin directories
This is very late to fix such core behaviour,
but it has been well reviewed and tested:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Tested-by: Ali Alnubani <alialnu@nvidia.com>
Applied, thanks
prev parent reply other threads:[~2020-11-25 22:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 15:14 [dpdk-dev] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL Timothy Redaelli
2020-11-24 15:14 ` [dpdk-dev] [PATCH 1/2] eal: fix shared lib mode detection Timothy Redaelli
2020-11-24 15:22 ` Bruce Richardson
2020-11-25 9:10 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-24 15:14 ` [dpdk-dev] [PATCH 2/2] eal: fix loading of shared libs from driver plugin directories Timothy Redaelli
2020-11-24 15:22 ` Bruce Richardson
2020-11-25 10:01 ` [dpdk-dev] [dpdk-stable] " David Marchand
2020-11-25 11:05 ` Ferruh Yigit
2020-11-25 10:57 ` [dpdk-dev] [PATCH 0/2] Fix shared lib detection on Fedora/CentOS/RHEL Maxime Coquelin
2020-11-25 15:59 ` Ali Alnubani
2020-11-25 22:54 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3188166.28SImnAznb@thomas \
--to=thomas@monjalon.net \
--cc=alialnu@nvidia.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=ktraynor@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.