From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables
Date: Wed, 27 May 2015 06:30:49 +0200 [thread overview]
Message-ID: <3191422.fnlJdo9ilI@xps13> (raw)
In-Reply-To: <20150526075719.24bed9cf@urahara>
2015-05-26 07:57, Stephen Hemminger:
> On Tue, 26 May 2015 15:39:18 +0200
> Maciej Gajdzica <maciejx.t.gajdzica@intel.com> wrote:
>
> > +#if RTE_LOG_LEVEL == RTE_LOG_DEBUG
> > +#define RTE_PIPELINE_STATS_ADD(counter, val) \
> > + ({ (counter) += (val); })
> > +
> > +#define RTE_PIPELINE_STATS_ADD_M(counter, mask) \
> > + ({ (counter) += __builtin_popcountll(mask); })
> > +#else
> > +#define RTE_PIPELINE_STATS_ADD(counter, val)
> > +#define RTE_PIPELINE_STATS_ADD_M(counter, mask)
> > +#endif
>
> This is worse idea than the previous one.
> I want statistics done on a per lcore basis, and always available
> because real users on production system want statistics (but they
> don't want log spam).
If they don't want log spam, they will increase log level with
the option --log-level.
By the way, maybe that RTE_LOG_INFO would be more appropriate for
these statistics in order to build them without having debug checks
in drivers.
prev parent reply other threads:[~2015-05-27 4:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-26 13:39 [PATCH v3] pipeline: add statistics for librte_pipeline ports and tables Maciej Gajdzica
2015-05-26 13:51 ` Dumitrescu, Cristian
2015-05-26 14:57 ` Stephen Hemminger
2015-05-26 21:35 ` Dumitrescu, Cristian
2015-05-26 21:47 ` Stephen Hemminger
2015-05-26 22:30 ` Dumitrescu, Cristian
2015-05-27 4:30 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3191422.fnlJdo9ilI@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.