From: Alper YILDIRIM <yildirimalper@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/4] package: enhance infrastructure to support source dir override
Date: Fri, 24 Jun 2011 05:04:56 -0700 (PDT) [thread overview]
Message-ID: <31919307.post@talk.nabble.com> (raw)
In-Reply-To: <c7659f95de05fab6acb0cc1b5e8772a80832fc33.1305755245.git.thomas.petazzoni@free-electrons.com>
Hello Thomas,
We started using your "source override" patches, but we encountered a
problem.
Package dependencies are not build when a package source is overriden.
To overcome this problem we made the following change in Makefile.package.in
ifeq ($($(2)_OVERRIDE_SRCDIR),)
$(1)-configure: $(1)-patch \
$$($(2)_TARGET_CONFIGURE)
else
$(1)-configure: $(1)-symlink \
+ $(1)-depends \
$$($(2)_TARGET_CONFIGURE)
endif
$(1)-symlink: $$($(2)_TARGET_SYMLINK)
Cheers,
Alper
Thomas Petazzoni-2 wrote:
>
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
> package/Makefile.package.in | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/package/Makefile.package.in b/package/Makefile.package.in
> index bf4e1b4..1afc18d 100644
> --- a/package/Makefile.package.in
> +++ b/package/Makefile.package.in
> @@ -250,6 +250,13 @@ $(BUILD_DIR)/%/.stamp_extracted:
> $(foreach hook,$($(PKG)_POST_EXTRACT_HOOKS),$(call $(hook))$(sep))
> $(Q)touch $@
>
> +# Set up symbolic link to the source directory if the
> +# <pkg>_OVERRIDE_SRCDIR feature is used.
> +$(BUILD_DIR)/%/.stamp_symlinked:
> + @$(call MESSAGE,"Symlinking to source dir")
> + ln -s $(SRCDIR) $(@D)
> + $(Q)touch $@
> +
> # Patch
> #
> # The NOHOSTPKG variable is the uppercased package name, without the
> @@ -418,6 +425,7 @@ $(2)_TARGET_INSTALL_STAGING =
> $$($(2)_DIR)/.stamp_staging_installed
> $(2)_TARGET_INSTALL_HOST = $$($(2)_DIR)/.stamp_host_installed
> $(2)_TARGET_BUILD = $$($(2)_DIR)/.stamp_built
> $(2)_TARGET_CONFIGURE = $$($(2)_DIR)/.stamp_configured
> +$(2)_TARGET_SYMLINK = $$($(2)_DIR)/.stamp_symlinked
> $(2)_TARGET_PATCH = $$($(2)_DIR)/.stamp_patched
> $(2)_TARGET_EXTRACT = $$($(2)_DIR)/.stamp_extracted
> $(2)_TARGET_SOURCE = $$($(2)_DIR)/.stamp_downloaded
> @@ -463,8 +471,15 @@ $(1)-install-host: $(1)-build
> $$($(2)_TARGET_INSTALL_HOST)
> $(1)-build: $(1)-configure \
> $$($(2)_TARGET_BUILD)
>
> +ifeq ($($(2)_OVERRIDE_SRCDIR),)
> $(1)-configure: $(1)-patch \
> $$($(2)_TARGET_CONFIGURE)
> +else
> +$(1)-configure: $(1)-symlink \
> + $$($(2)_TARGET_CONFIGURE)
> +endif
> +
> +$(1)-symlink: $$($(2)_TARGET_SYMLINK)
>
> $(1)-patch: $(1)-extract $$($(2)_TARGET_PATCH)
>
> @@ -492,6 +507,7 @@ $$($(2)_TARGET_INSTALL_STAGING): PKG=$(2)
> $$($(2)_TARGET_INSTALL_HOST): PKG=$(2)
> $$($(2)_TARGET_BUILD): PKG=$(2)
> $$($(2)_TARGET_CONFIGURE): PKG=$(2)
> +$$($(2)_TARGET_SYMLINK): SRCDIR=$$($(2)_OVERRIDE_SRCDIR)
> $$($(2)_TARGET_PATCH): PKG=$(2)
> $$($(2)_TARGET_PATCH): NOHOSTPKG=$(3)
> $$($(2)_TARGET_EXTRACT): PKG=$(2)
> --
>
>
--
View this message in context: http://old.nabble.com/-RFC--Override-source-directories-tp31651180p31919307.html
Sent from the Buildroot (busybox) mailing list archive at Nabble.com.
next prev parent reply other threads:[~2011-06-24 12:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-18 21:48 [Buildroot] [RFC] Override source directories Thomas Petazzoni
2011-05-18 21:48 ` [Buildroot] [PATCH 1/4] package: enhance infrastructure to support source dir override Thomas Petazzoni
2011-06-24 12:04 ` Alper YILDIRIM [this message]
2011-06-24 12:44 ` Thomas Petazzoni
2011-05-18 21:48 ` [Buildroot] [PATCH 2/4] package: remove stamp files in <pkg>-dirclean Thomas Petazzoni
2011-05-18 21:48 ` [Buildroot] [PATCH 3/4] package: add <pkg>-rebuild and <pkg>-reconfigure Thomas Petazzoni
2011-05-18 21:48 ` [Buildroot] [PATCH 4/4] Include a local.mk for package overrides Thomas Petazzoni
2011-05-19 8:50 ` [Buildroot] [RFC] Override source directories Benoît Mauduit
2011-06-08 20:22 ` Alper Yıldırım
2011-06-09 6:38 ` Patryk Benderz
2011-06-10 21:21 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31919307.post@talk.nabble.com \
--to=yildirimalper@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.