From: Thomas Monjalon <thomas@monjalon.net>
To: Kefu Chai <tchaikov@gmail.com>
Cc: dev@dpdk.org, Avi Kivity <avi@scylladb.com>,
anatoly.burakov@intel.com,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v5 1/2] build: add meson options of atomic_mbuf_ref_counts
Date: Mon, 25 Oct 2021 17:55:17 +0200 [thread overview]
Message-ID: <3195786.qzLq50EVuH@thomas> (raw)
In-Reply-To: <YWfoY8P53k9ZYi08@bricha3-MOBL.ger.corp.intel.com>
14/10/2021 10:20, Bruce Richardson:
> On Thu, Oct 14, 2021 at 04:54:18AM +0800, Kefu Chai wrote:
> > RTE_MBUF_REFCNT_ATOMIC = 0 is not necessary for applications like
> > Seastar, where it's safe to assume that the mbuf refcnt is only
> > updated by a single core only.
> >
> > Signed-off-by: Kefu Chai <tchaikov@gmail.com>
> > ---
>
> For this, I think it's a setting that needs to be a global one for DPDK, so
> I'm ok with adding it as a meson option.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Changed the option name to "mbuf_refcnt_atomic" to match the flag.
Applied, thanks.
next prev parent reply other threads:[~2021-10-25 15:55 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 14:48 [dpdk-dev] [PATCH] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic" Kefu Chai
2021-09-02 15:02 ` Bruce Richardson
2021-09-02 15:05 ` [dpdk-dev] [PATCH v2] " Kefu Chai
2021-09-02 15:11 ` [dpdk-dev] [PATCH v3] build: add meson options of max_memseg_lists and atomic_mbuf_ref_counts Kefu Chai
2021-09-08 16:51 ` [dpdk-dev] [PATCH v4] " Kefu Chai
2021-09-20 7:51 ` kefu chai
2021-09-20 8:08 ` Bruce Richardson
2021-09-27 15:03 ` kefu chai
2021-10-13 15:38 ` Thomas Monjalon
2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 0/2] build: add meson option of "max_memseg_lists" and "mbuf_refcnt_atomic" Kefu Chai
2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 1/2] build: add meson options of atomic_mbuf_ref_counts Kefu Chai
2021-10-14 8:20 ` Bruce Richardson
2021-10-25 15:55 ` Thomas Monjalon [this message]
2021-10-13 20:54 ` [dpdk-dev] [PATCH v5 2/2] build: add meson options of max_memseg_lists Kefu Chai
2021-10-14 8:25 ` Bruce Richardson
2021-10-14 8:29 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3195786.qzLq50EVuH@thomas \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=avi@scylladb.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=tchaikov@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.