From: Thomas Monjalon <thomas@monjalon.net>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Cc: "Zeng, ZhichaoX" <zhichaox.zeng@intel.com>,
dev@dpdk.org, "Richardson, Bruce" <bruce.richardson@intel.com>,
Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Wu, Wenjun1" <wenjun1.wu@intel.com>,
"Gao, DaxueX" <daxuex.gao@intel.com>,
"david.marchand@redhat.com" <david.marchand@redhat.com>,
"Mcnamara, John" <john.mcnamara@intel.com>,
helin.zhang@intel.com
Subject: Re: [PATCH v2] net/iavf: fix compilation warnings
Date: Mon, 12 Jun 2023 16:15:07 +0200 [thread overview]
Message-ID: <3196107.aV6nBDHxoP@thomas> (raw)
In-Reply-To: <DM4PR11MB5994DF3E70256D7A9AEEBB3CD754A@DM4PR11MB5994.namprd11.prod.outlook.com>
12/06/2023 14:29, Zhang, Qi Z:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 12/06/2023 10:32, Gao, DaxueX:
> > > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > > > Use fallthrough comments to ignore compilation warnings instead of
> > > > diagnostic pragmas, which are not recognized by old GCC(below GCC7).
> > > >
> > > > Fixes: 95a1b0b23140 ("net/iavf: support Rx timestamp offload on
> > > > SSE")
> > > > Fixes: 4f58266da4d3 ("net/iavf: support Rx timestamp offload on
> > > > AVX2")
> > > > Fixes: d65eadb9e178 ("net/iavf: support Rx timestamp offload on
> > > > AVX512")
> > > > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> > > Tested-by: Daxue Gao <daxuex.gao@intel.com>
> >
> > Please squash the fix in the original commits above, so we won't have any
> > compilation issue when doing "git bisect".
> >
> > In the meantime, I am pulling the branch next-net-intel without the Rx
> > timestamp support for SSE/AVX2/AVX512.
> >
>
> Squashed to original patches in dpdk-next-net-intel.
It is still not compiling:
In function '_mm_testz_si128',
inlined from '_recv_raw_pkts_vec_flex_rxd' at ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1070:12:
/usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/smmintrin.h:69:10: error: 'mask_low' may be used uninitialized [-Werror=maybe-uninitialized]
69 | return __builtin_ia32_ptestz128 ((__v2di)__M, (__v2di)__V);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c: In function '_recv_raw_pkts_vec_flex_rxd':
../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1058:49: note: 'mask_low' was declared here
1058 | __m128i mask_low;
| ^~~~~~~~
In function '_mm_testz_si128',
inlined from '_recv_raw_pkts_vec_flex_rxd' at ../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1072:13:
/usr/lib/gcc/x86_64-pc-linux-gnu/13.1.1/include/smmintrin.h:69:10: error: 'mask_high' may be used uninitialized [-Werror=maybe-uninitialized]
69 | return __builtin_ia32_ptestz128 ((__v2di)__M, (__v2di)__V);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c: In function '_recv_raw_pkts_vec_flex_rxd':
../../dpdk/drivers/net/iavf/iavf_rxtx_vec_sse.c:1059:49: note: 'mask_high' was declared here
1059 | __m128i mask_high;
| ^~~~~~~~~
cc1: all warnings being treated as errors
next prev parent reply other threads:[~2023-06-12 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 5:41 [PATCH] net/iavf: fix old GCC compilation warnings Zhichao Zeng
2023-06-09 6:58 ` David Marchand
2023-06-09 7:19 ` Zeng, ZhichaoX
2023-06-09 9:02 ` [PATCH v2] net/iavf: fix " Zhichao Zeng
2023-06-12 8:32 ` Gao, DaxueX
2023-06-12 9:01 ` Thomas Monjalon
2023-06-12 12:29 ` Zhang, Qi Z
2023-06-12 14:15 ` Thomas Monjalon [this message]
2023-06-12 15:08 ` Zhang, Qi Z
2023-06-09 14:38 ` [PATCH] net/iavf: fix old GCC " Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3196107.aV6nBDHxoP@thomas \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=daxuex.gao@intel.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
--cc=jingjing.wu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=konstantin.v.ananyev@yandex.ru \
--cc=qi.z.zhang@intel.com \
--cc=wenjun1.wu@intel.com \
--cc=zhichaox.zeng@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.