All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephan Mueller <smueller@chronox.de>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>
Subject: Re: [PATCH 1/2] crypto: skcipher - Add top-level skcipher interface
Date: Fri, 21 Aug 2015 11:24:08 +0200	[thread overview]
Message-ID: <3197252.zpooAnFuUp@tauon.atsec.com> (raw)
In-Reply-To: <E1ZSKAT-00075n-MI@gondolin.me.apana.org.au>

Am Donnerstag, 20. August 2015, 15:21:45 schrieb Herbert Xu:

Hi Herbert,

>This patch introduces the crypto skcipher interface which aims
>to replace both blkcipher and ablkcipher.
>
>It's very similar to the existing ablkcipher interface.  The
>main difference is the removal of the givcrypt interface.  In
>order to make the transition easier for blkcipher users, there
>is a helper SKCIPHER_REQUEST_ON_STACK which can be used to place
>a request on the stack for synchronous transforms.

If I understand the patch set correctly, a caller uses the skcipher API and 
the API sets up the synchronous or asynchronous callbacks depending on the 
chosen cipher implementation.

Now, does a caller always need to create an skcipher_request and always need 
the async logic of providing a callback function and the like, even though a 
synchronous cipher is chosen? I.e. the caller has no means to use a 
synchronous cipher operation any more.

It looks to me like that, but I would like to confirm.

Thank you.

Ciao
Stephan

  reply	other threads:[~2015-08-21  9:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20  7:20 [PATCH 0/2] crypto: skcipher - Introduce new skcipher interface Herbert Xu
2015-08-20  7:21 ` [PATCH 1/2] crypto: skcipher - Add top-level " Herbert Xu
2015-08-21  9:24   ` Stephan Mueller [this message]
2015-08-21  9:27     ` Herbert Xu
2015-08-23 18:16       ` Stephan Mueller
2015-08-20  7:21 ` [PATCH 2/2] crypto: testmgr - Use new " Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3197252.zpooAnFuUp@tauon.atsec.com \
    --to=smueller@chronox.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.