From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support Date: Tue, 16 Dec 2014 01:37:51 +0200 Message-ID: <3197445.qizQc0zeRb@avalon> References: <1416045309-13359-1-git-send-email-ajaykumar.rs@samsung.com> <548ABAB6.6010200@collabora.co.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <548ABAB6.6010200@collabora.co.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , Sean Paul , Daniel Vetter , Ajay Kumar , Tomi Valkeinen , Ajay kumar , Kukjin Kim , Pannaga Bhushan Reddy Patel , Prashanth G , Javier Martinez Canillas , "linux-arm-kernel@lists.infradead.org" List-Id: linux-samsung-soc@vger.kernel.org SGkgSmF2aWVyLAoKT24gRnJpZGF5IDEyIERlY2VtYmVyIDIwMTQgMTA6NTE6NTAgSmF2aWVyIE1h cnRpbmV6IENhbmlsbGFzIHdyb3RlOgo+IEhlbGxvLAo+IAo+IE9uIDExLzE4LzIwMTQgMDc6MjAg QU0sIEFqYXkga3VtYXIgd3JvdGU6Cj4gPiBPbiBTYXQsIE5vdiAxNSwgMjAxNCBhdCAzOjI0IFBN LCBBamF5IEt1bWFyIHdyb3RlOgo+ID4+IFRoaXMgc2VyaWVzIGlzIGJhc2VkIG9uIG1hc3RlciBi cmFuY2ggb2YgTGludXMgdHJlZSBhdDoKPiA+PiBnaXQ6Ly9naXQua2VybmVsLm9yZy9wdWIvc2Nt L2xpbnV4L2tlcm5lbC9naXQvdG9ydmFsZHMvbGludXguZ2l0Cj4gCj4gVGhpcyBzZXJpZXMgaGFz IGJlZW4gaW4gdGhlIG1haWxpbmcgbGlzdHMgZm9yIG1vbnRocyBhbmQgaGF2ZSBiZWVuIHRlc3Rl ZAo+IGJ5IG1hbnkgcGVvcGxlLiBXaGF0IGVsc2UgaXMgbWlzc2luZyBiZWZvcmUgaXQgY2FuIGJl IG1lcmdlZD8KPiAKPiBJdCB3b3VsZCBiZSBncmVhdCB0byBoYXZlIHByb3BlciBkaXNwbGF5IHN1 cHBvcnQgb24gcGxhdGZvcm1zIHRoYXQgaGF2ZSBhCj4gZURQIHRvIExWRFMgYnJpZGdlIGNoaXAg KGUuZzogU25vdywgUGVhY2ggUGl0IGFuZCBTcHJpbmcgQ2hyb21lYm9va3MpIGFuZAo+IGV2ZXJ5 dGhpbmcgaXMgaW4gcGxhY2UgYnV0IHRoaXMgc2VyaWVzIHdoaWNoIGhhZCBiZWVuIG1pc3Npbmcg bWFueSBrZXJuZWwKPiByZWxlYXNlcyBhbHJlYWR5Lgo+IAo+ID4+IENoYW5nZXMgc2luY2UgVjc6 Cj4gPj4gICAgICAgICAtLSBBZGRyZXNzIGNvbW1lbnRzIGZyb20gVG9taSBhbmQgTGF1cmVudDoK PiA+PiAgICAgICAgICAgICAgICAgLS0gVXNlIHZpZGVvcG9ydHMgYW5kIGVuZHBvaW50cyB0byBy ZXByZXNlbnQgdGhlCj4gPj4gICAgICAgICAgICAgICAgIGNvbm5lY3Rpb24gYmV0d2Vlbgo+ID4+ ICAgICAgICAgICAgICAgICAKPiA+PiAgICAgICAgICAgICAgICAgICAgZW5jb2RlciwgYnJpZGdl IGFuZCB0aGUgcGFuZWwsIGluc3RlYWQgb2YgdXNpbmcKPiA+PiAgICAgICAgICAgICAgICAgICAg cGhhbmRsZXMuCj4gPj4gICAgICAgICAKPiA+PiAgICAgICAgIC0tIEFkZHJlc3MgY29tbWVudHMg ZnJvbSBEYW5pZWw6Cj4gPj4gICAgICAgICAgICAgICAgIC0tIE1ha2UgdGhlIHBhdGNoIGRlc2Ny aXB0aW9uIG1vcmUgZGVzY3JpcHRpdmUuCj4gPj4gICAgICAgICAgICAgICAgIC0tIHJlbW92ZSBk ZXZpY2UgcG9pbnRlciBmcm9tIGRybV9icmlkZ2UsIGFuZCBqdXN0IHVzZQo+ID4+ICAgICAgICAg ICAgICAgICAKPiA+PiAgICAgICAgICAgICAgICAgICAgZGV2aWNlX25vZGUgaW5zdGVhZC4KPiA+ PiAgICAgICAgICAgICAgICAgCj4gPj4gICAgICAgICAgICAgICAgIC0tIGRvbid0IHBhc3MgZW5j b2RlciBwb2ludGVyIHRvIGJyaWRnZV9hdHRhY2guCj4gPj4gICAgICAgICAKPiA+PiAgICAgICAg IC0tIEFkZHJlc3MgY29tbWVudHMgZnJvbSBTZWFuIFBhdWw6Cj4gPj4gICAgICAgICAgICAgICAg IC0tIFJlbW92ZSBicmlkZ2UgZnJvbSBtb2RlX2NvbmZpZywgYW5kIHB1bGwgb3V0Cj4gPj4gICAg ICAgICAgICAgICAgIGRybV9icmlkZ2UKPiA+PiAgICAgICAgICAgICAgICAgCj4gPj4gICAgICAg ICAgICAgICAgICAgIGZ1bmN0aW9ucyBmcm9tIGRybV9jcnRjLmMgdG8gZHJtX2JyaWRnZS5jCj4g Cj4gVG9taSBhbmQgTGF1cmVudCwKPiAKPiBZb3UgYXNrZWQgQWpheSB0byBjaGFuZ2UgaGlzIHNl cmllcyB0byB1c2UgdGhlIHZpZGVvIHBvcnQgYW5kIGVucG9pbnRzIERUCj4gYmluZGluZ3MgaW5z dGVhZCBvZiBwaGFuZGxlcywgY291bGQgeW91IHBsZWFzZSByZXZpZXcgaGlzIGxhdGVzdCB2ZXJz aW9uPwo+IAo+IEkgZ3Vlc3MgaXMgbm93IHRvbyBsYXRlIGZvciAzLjE5IHNpbmNlIHdlIGFyZSBp biB0aGUgbWlkZGxlIG9mIHRoZSBtZXJnZQo+IHdpbmRvdyBidXQgaXQgd291bGQgYmUgZ3JlYXQg aWYgdGhpcyBzZXJpZXMgY2FuIGF0IGxlYXN0IG1hZGUgaXQgdG8gMy4yMC4KCkkgZG9uJ3QgaGF2 ZSB0aW1lIHRvIHJldmlldyB0aGUgc2VyaWVzIGluIGRldGFpbHMgcmlnaHQgbm93LCBidXQgSSdt IGhhcHB5IAp3aXRoIHRoZSBEVCBiaW5kaW5ncywgYW5kIGhhdmUgbm8gYmlnIGlzc3VlIHdpdGgg dGhlIHJlc3Qgb2YgdGhlIHBhdGNoZXMuIEkgCmRvbid0IHJlYWxseSBsaWtlIHRoZSBvZl9kcm1f ZmluZF9icmlkZ2UoKSBjb25jZXB0IGludHJvZHVjZWQgaW4gMDMvMTQgYnV0IEkgCndvbid0IG5h Y2sgaXQgZ2l2ZW4gbGFjayBvZiB0aW1lIHRvIGltcGxlbWVudCBhbiBhbHRlcm5hdGl2ZSBwcm9w b3NhbC4gSXQncyBhbiAKaW50ZXJuYWwgQVBJLCBpdCBjYW4gYWx3YXlzIGJlIHJld29ya2VkIGxh dGVyIGFueXdheS4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlz dApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Tue, 16 Dec 2014 01:37:51 +0200 Subject: [PATCH V8 00/14] drm/exynos: few patches to enhance bridge chip support In-Reply-To: <548ABAB6.6010200@collabora.co.uk> References: <1416045309-13359-1-git-send-email-ajaykumar.rs@samsung.com> <548ABAB6.6010200@collabora.co.uk> Message-ID: <3197445.qizQc0zeRb@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Javier, On Friday 12 December 2014 10:51:50 Javier Martinez Canillas wrote: > Hello, > > On 11/18/2014 07:20 AM, Ajay kumar wrote: > > On Sat, Nov 15, 2014 at 3:24 PM, Ajay Kumar wrote: > >> This series is based on master branch of Linus tree at: > >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > This series has been in the mailing lists for months and have been tested > by many people. What else is missing before it can be merged? > > It would be great to have proper display support on platforms that have a > eDP to LVDS bridge chip (e.g: Snow, Peach Pit and Spring Chromebooks) and > everything is in place but this series which had been missing many kernel > releases already. > > >> Changes since V7: > >> -- Address comments from Tomi and Laurent: > >> -- Use videoports and endpoints to represent the > >> connection between > >> > >> encoder, bridge and the panel, instead of using > >> phandles. > >> > >> -- Address comments from Daniel: > >> -- Make the patch description more descriptive. > >> -- remove device pointer from drm_bridge, and just use > >> > >> device_node instead. > >> > >> -- don't pass encoder pointer to bridge_attach. > >> > >> -- Address comments from Sean Paul: > >> -- Remove bridge from mode_config, and pull out > >> drm_bridge > >> > >> functions from drm_crtc.c to drm_bridge.c > > Tomi and Laurent, > > You asked Ajay to change his series to use the video port and enpoints DT > bindings instead of phandles, could you please review his latest version? > > I guess is now too late for 3.19 since we are in the middle of the merge > window but it would be great if this series can at least made it to 3.20. I don't have time to review the series in details right now, but I'm happy with the DT bindings, and have no big issue with the rest of the patches. I don't really like the of_drm_find_bridge() concept introduced in 03/14 but I won't nack it given lack of time to implement an alternative proposal. It's an internal API, it can always be reworked later anyway. -- Regards, Laurent Pinchart