From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A80C3C18E5B for ; Sun, 8 Mar 2020 07:51:02 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3440920838 for ; Sun, 8 Mar 2020 07:51:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="X7y56Ofu"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e8HNVypb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3440920838 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 319811614; Sun, 8 Mar 2020 08:50:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 319811614 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1583653860; bh=MKiI7+FmOxPT8xE3d51jWp++sm3zJ9kB9slVHB9VB1o=; h=From:References:In-Reply-To:Date:Subject:To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=X7y56OfuEtt9nxiOAOX4lKls56G3uyMGZgiZmZq1a0VlFy0oqAeOfWjTvbAW8ERQR POi8AY56cU1plHgfb/EypDNrLVzJIiNwB9egcyzAU1XTx8cFkbRnFRBz7Bo7aukmWg +ORAYbVlw5Iij5wQpH/fkDReg7OMV1qQH0YNUE8g= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 06736F802A8; Sun, 8 Mar 2020 08:46:30 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B8839F801ED; Fri, 6 Mar 2020 23:50:56 +0100 (CET) Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 12C22F80126 for ; Fri, 6 Mar 2020 23:50:50 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 12C22F80126 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e8HNVypb" Received: by mail-lj1-x243.google.com with SMTP id f10so3884796ljn.6 for ; Fri, 06 Mar 2020 14:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=+KdFgHd0Khi4D1I+q98xetrP7WjqAjfW7zo+CRETAms=; b=e8HNVypbS1BSjAYaVJJGJ+lKqiyoZLEYraBW0NcV4WgM3WRpmeJseFIlMHSsduthi8 bfvxHTjVtPlItpMk7F/T9BgaTmF4A0GeTIML+V+gg1wHMUr1twtjejyU971EbA3I7srS P67lwS73bevLsMsn6lSRm+pieEbC3gt76dyLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=+KdFgHd0Khi4D1I+q98xetrP7WjqAjfW7zo+CRETAms=; b=F5AgLJVTENJ4bb2+B/asu3EEkDZqiXrw8rijdejMC4VrP42yBxd7OJjAJn0VOZadas 6yfY/bjWSdSIEoiyIFtFWvCDo8vC2hBeALwzCna9DQU/x8K2KxihWlg81ynqFkyu2dWd LClmxHsghzFExQ0gc5XP3n7HaSnR9HvcdFHOZ4NXhaLRJV7KaQJqC7vstKLTz1n27rFZ zgNjesvg6j6O68ScLWK2vRI8+KOXm+1doFp4JWn/9EcA8zksApuyMksJpZQ2UPqsaRLV MbIjMcKyLfvizkaia48ET5nFP3vnpAPut+VMxuWhUU236ZkyquC3n8YoFhgy2EAc1fLN V1Yw== X-Gm-Message-State: ANhLgQ2SRyBeCpuMwa2fhJdtKABsd1N21QFpD+pBZMvrHIxkutW+dexx QVLSCUD9M+XprgT7qFg5ejPLbwsUWP9UnzCPkVQgmp/VKFEmsANd X-Google-Smtp-Source: ADFU+vvb+PrrT95TpfxieL14D0NqyXJi/a9FHEMKFcoukv944eoKgmEzoL0AOVCOoUwoDUqsoNYVB8prKmFXlelzJYQ= X-Received: by 2002:a2e:80c3:: with SMTP id r3mr3329042ljg.105.1583535048747; Fri, 06 Mar 2020 14:50:48 -0800 (PST) From: Kevin Li References: <20200306222705.13309-1-kevin-ke.li@broadcom.com> <8d4fc59e-f892-7228-4369-f40ced5dc2d3@gmail.com> In-Reply-To: <8d4fc59e-f892-7228-4369-f40ced5dc2d3@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQK6AtPk+W1UvlC/8YJn5FlJAEq5hQIs4nExpmKljtA= Date: Fri, 6 Mar 2020 14:50:46 -0800 Message-ID: <31b665e609f3cfee935f4489a073af21@mail.gmail.com> Subject: RE: [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver To: Florian Fainelli , Mark Brown Content-Type: text/plain; charset="UTF-8" X-Mailman-Approved-At: Sun, 08 Mar 2020 08:46:09 +0100 Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Scott Branden , Ray Jui , Stephen Boyd , Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Hi Florian, It is called from bcm63xx-i2s-whistler.c. Maybe the name "_probe" function confused. It was 2 platform drivers, I combined them together now. Let me know if this answers your question, and what to do to address your question. Regards! Kevin -----Original Message----- From: Florian Fainelli [mailto:f.fainelli@gmail.com] Sent: Friday, March 06, 2020 2:34 PM To: Kevin Li ; Mark Brown Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; Kuninori Morimoto ; Scott Branden ; Liam Girdwood ; Ray Jui ; Takashi Iwai ; Jaroslav Kysela ; bcm-kernel-feedback-list@broadcom.com; Stephen Boyd ; linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver On 3/6/20 2:27 PM, Kevin Li wrote: > This patch adds Broadcom DSL/PON SoC audio driver with Whistler I2S > block. The SoC supported by this patch are BCM63158B0,BCM63178 and > BCM47622/6755. > > Signed-off-by: Kevin Li > --- [snip] > +int bcm63xx_soc_platform_probe(struct platform_device *pdev, > + struct bcm_i2s_priv *i2s_priv) { > + int ret; > + > + i2s_priv->r_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + if (!i2s_priv->r_irq) { > + dev_err(&pdev->dev, "Unable to get register irq resource.\n"); > + return -ENODEV; > + } > + > + ret = devm_request_irq(&pdev->dev, i2s_priv->r_irq->start, i2s_dma_isr, > + i2s_priv->r_irq->flags, "i2s_dma", (void *)i2s_priv); > + if (ret) { > + dev_err(&pdev->dev, > + "i2s_init: failed to request interrupt.ret=%d\n", ret); > + return ret; > + } > + > + return devm_snd_soc_register_component(&pdev->dev, > + &bcm63xx_soc_platform, NULL, 0); } > + > +int bcm63xx_soc_platform_remove(struct platform_device *pdev) { > + return 0; > +} How does one probe this module if the bcm63xx_soc_platform_probe() functions are not called from anywhere and/or hooked up to the module entry/exit points? Are you not missing a platform_driver entry which matches the compatible string you defined? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35B1BC10DCE for ; Fri, 6 Mar 2020 22:50:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0525E206D7 for ; Fri, 6 Mar 2020 22:50:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="sl3ShM2C"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e8HNVypb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0525E206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:MIME-Version :In-Reply-To:References:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SI2yrrmVj+ZKpVbQqeGS3FudmuIQE146f0ycAmaVRuw=; b=sl3ShM2CdD918K J5fzMo7zd5+oSxh0KWu9h8vXfW+VYdLOeafxtmyrokXin9GBOTPpw6mJejRTyyaPqbqB/uUtnVsn6 khcPF56Y5NTZJ++Dh/iOZYl3UlAaSUvB/iJgFhRAGV7YsMv2xP86RIiLCwi5byBx0+2dBWnHNM8RR 8GE9THrk9D27ga8tks5kGnjKM1HKfPf7Q4FRt3EFbX3vwTq0W9PEwqb9ug12/lA5SG/rDMPA/qAc7 J1FL6ITEJnX5SldmBXe/oNRQlwjG9K8VJdP+3DptQ/mvfGEx4wy56QAhj6bIynIhGu7oKTZYiZ2+y IKE7X2thcKR4GaOIIlOQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jALny-0004nh-Ld; Fri, 06 Mar 2020 22:50:54 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jALnu-0004nN-Jk for linux-arm-kernel@lists.infradead.org; Fri, 06 Mar 2020 22:50:52 +0000 Received: by mail-lj1-x244.google.com with SMTP id j19so3913892lji.1 for ; Fri, 06 Mar 2020 14:50:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=+KdFgHd0Khi4D1I+q98xetrP7WjqAjfW7zo+CRETAms=; b=e8HNVypbS1BSjAYaVJJGJ+lKqiyoZLEYraBW0NcV4WgM3WRpmeJseFIlMHSsduthi8 bfvxHTjVtPlItpMk7F/T9BgaTmF4A0GeTIML+V+gg1wHMUr1twtjejyU971EbA3I7srS P67lwS73bevLsMsn6lSRm+pieEbC3gt76dyLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=+KdFgHd0Khi4D1I+q98xetrP7WjqAjfW7zo+CRETAms=; b=MA5ciiMCxqZFQTn0XKdeZVkJQUwhsTYx0ZCSAfIPA4MUiWsu9OluZSSViu/moRavn/ 0w99kAr33a/Oyy0b6MhvSAkf8ws6DRoiPd4d9gTFBtmryzdD13dLW0mLqXu/JVKcaN0q omvW1HvxuDNMRfechYy/40lWl5rolBR+8g374CL7AVY+eQ5TC6CpwfsrVOEv3PDe/L7v IctKvIX+3xgSjU7o/iodZlH/OalaX/mljTb2AAejS4t6J7Wgv4I13MXqArN67y0lV/5t yxosdcH/5OX6vC7149rbO+xIbInzKhKrR8RFn9T9dfJwrJXMHHj4grKJMm9nn9g6RIsG KhYw== X-Gm-Message-State: ANhLgQ2+bjQGmGy2+pVQG68ROUu1nQ4ox5Bi8uCz5RB0vmbHzk5Cdt4x T1wTyF1PSA5finzPLaL+CI/fsF5+LS0vvzQGiHsTjg== X-Google-Smtp-Source: ADFU+vvb+PrrT95TpfxieL14D0NqyXJi/a9FHEMKFcoukv944eoKgmEzoL0AOVCOoUwoDUqsoNYVB8prKmFXlelzJYQ= X-Received: by 2002:a2e:80c3:: with SMTP id r3mr3329042ljg.105.1583535048747; Fri, 06 Mar 2020 14:50:48 -0800 (PST) From: Kevin Li References: <20200306222705.13309-1-kevin-ke.li@broadcom.com> <8d4fc59e-f892-7228-4369-f40ced5dc2d3@gmail.com> In-Reply-To: <8d4fc59e-f892-7228-4369-f40ced5dc2d3@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQK6AtPk+W1UvlC/8YJn5FlJAEq5hQIs4nExpmKljtA= Date: Fri, 6 Mar 2020 14:50:46 -0800 Message-ID: <31b665e609f3cfee935f4489a073af21@mail.gmail.com> Subject: RE: [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver To: Florian Fainelli , Mark Brown X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200306_145050_655742_85CB086E X-CRM114-Status: GOOD ( 14.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alsa-devel@alsa-project.org, Kuninori Morimoto , Scott Branden , Ray Jui , Stephen Boyd , Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , bcm-kernel-feedback-list@broadcom.com, Jaroslav Kysela , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Florian, It is called from bcm63xx-i2s-whistler.c. Maybe the name "_probe" function confused. It was 2 platform drivers, I combined them together now. Let me know if this answers your question, and what to do to address your question. Regards! Kevin -----Original Message----- From: Florian Fainelli [mailto:f.fainelli@gmail.com] Sent: Friday, March 06, 2020 2:34 PM To: Kevin Li ; Mark Brown Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; Kuninori Morimoto ; Scott Branden ; Liam Girdwood ; Ray Jui ; Takashi Iwai ; Jaroslav Kysela ; bcm-kernel-feedback-list@broadcom.com; Stephen Boyd ; linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver On 3/6/20 2:27 PM, Kevin Li wrote: > This patch adds Broadcom DSL/PON SoC audio driver with Whistler I2S > block. The SoC supported by this patch are BCM63158B0,BCM63178 and > BCM47622/6755. > > Signed-off-by: Kevin Li > --- [snip] > +int bcm63xx_soc_platform_probe(struct platform_device *pdev, > + struct bcm_i2s_priv *i2s_priv) { > + int ret; > + > + i2s_priv->r_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + if (!i2s_priv->r_irq) { > + dev_err(&pdev->dev, "Unable to get register irq resource.\n"); > + return -ENODEV; > + } > + > + ret = devm_request_irq(&pdev->dev, i2s_priv->r_irq->start, i2s_dma_isr, > + i2s_priv->r_irq->flags, "i2s_dma", (void *)i2s_priv); > + if (ret) { > + dev_err(&pdev->dev, > + "i2s_init: failed to request interrupt.ret=%d\n", ret); > + return ret; > + } > + > + return devm_snd_soc_register_component(&pdev->dev, > + &bcm63xx_soc_platform, NULL, 0); } > + > +int bcm63xx_soc_platform_remove(struct platform_device *pdev) { > + return 0; > +} How does one probe this module if the bcm63xx_soc_platform_probe() functions are not called from anywhere and/or hooked up to the module entry/exit points? Are you not missing a platform_driver entry which matches the compatible string you defined? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87A4CC10DCE for ; Fri, 6 Mar 2020 22:50:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 54F9D206D7 for ; Fri, 6 Mar 2020 22:50:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="e8HNVypb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726368AbgCFWuv (ORCPT ); Fri, 6 Mar 2020 17:50:51 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:38542 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726162AbgCFWuv (ORCPT ); Fri, 6 Mar 2020 17:50:51 -0500 Received: by mail-lj1-f195.google.com with SMTP id w1so3892613ljh.5 for ; Fri, 06 Mar 2020 14:50:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=+KdFgHd0Khi4D1I+q98xetrP7WjqAjfW7zo+CRETAms=; b=e8HNVypbS1BSjAYaVJJGJ+lKqiyoZLEYraBW0NcV4WgM3WRpmeJseFIlMHSsduthi8 bfvxHTjVtPlItpMk7F/T9BgaTmF4A0GeTIML+V+gg1wHMUr1twtjejyU971EbA3I7srS P67lwS73bevLsMsn6lSRm+pieEbC3gt76dyLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=+KdFgHd0Khi4D1I+q98xetrP7WjqAjfW7zo+CRETAms=; b=K+xdjgtKr0E8f0Zxd0ewUT9ZYDYBpj5uBX6DrR6PXntuFk+jiXnIr9jOqYeAZ7GCeY l+XVFTs8/tme0IuUpbCU/yeyQNzWQ96PKdDGtApQYKukWNUVq5z0tYv2I9HMU9yxyGYr UpcHTnzzCMnmwsIPpDn7wkh58UjzTZGCkkCOHaIlJBCuT6nzixqAnSCUW95xjB1aNhbk zlxoQ9f15GlGlViASQoh8e8YEtMhtwCIA214+nXfBS3F5fUH0IU43Ug12sK/7nmtkyro kMW9RrcnbZAvcDcvxMe5lBSKV75abB/zHG8KyHN+LINmah+TrVCz3bCgwPtBeYkWYPm8 3ksg== X-Gm-Message-State: ANhLgQ1UJ9stMIEguwvHl33LgVCMREpzPVDUP0OhiDWpETXnIiqThMwL O54owu6CNHh7DGBYP4sllKq/w9fJAQo2VTLG0pxqrA== X-Google-Smtp-Source: ADFU+vvb+PrrT95TpfxieL14D0NqyXJi/a9FHEMKFcoukv944eoKgmEzoL0AOVCOoUwoDUqsoNYVB8prKmFXlelzJYQ= X-Received: by 2002:a2e:80c3:: with SMTP id r3mr3329042ljg.105.1583535048747; Fri, 06 Mar 2020 14:50:48 -0800 (PST) From: Kevin Li References: <20200306222705.13309-1-kevin-ke.li@broadcom.com> <8d4fc59e-f892-7228-4369-f40ced5dc2d3@gmail.com> In-Reply-To: <8d4fc59e-f892-7228-4369-f40ced5dc2d3@gmail.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 15.0 Thread-Index: AQK6AtPk+W1UvlC/8YJn5FlJAEq5hQIs4nExpmKljtA= Date: Fri, 6 Mar 2020 14:50:46 -0800 Message-ID: <31b665e609f3cfee935f4489a073af21@mail.gmail.com> Subject: RE: [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver To: Florian Fainelli , Mark Brown Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Kuninori Morimoto , Scott Branden , Liam Girdwood , Ray Jui , Takashi Iwai , Jaroslav Kysela , bcm-kernel-feedback-list@broadcom.com, Stephen Boyd , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, It is called from bcm63xx-i2s-whistler.c. Maybe the name "_probe" function confused. It was 2 platform drivers, I combined them together now. Let me know if this answers your question, and what to do to address your question. Regards! Kevin -----Original Message----- From: Florian Fainelli [mailto:f.fainelli@gmail.com] Sent: Friday, March 06, 2020 2:34 PM To: Kevin Li ; Mark Brown Cc: alsa-devel@alsa-project.org; linux-kernel@vger.kernel.org; Kuninori Morimoto ; Scott Branden ; Liam Girdwood ; Ray Jui ; Takashi Iwai ; Jaroslav Kysela ; bcm-kernel-feedback-list@broadcom.com; Stephen Boyd ; linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ASoC: brcm: Add DSL/PON SoC audio driver On 3/6/20 2:27 PM, Kevin Li wrote: > This patch adds Broadcom DSL/PON SoC audio driver with Whistler I2S > block. The SoC supported by this patch are BCM63158B0,BCM63178 and > BCM47622/6755. > > Signed-off-by: Kevin Li > --- [snip] > +int bcm63xx_soc_platform_probe(struct platform_device *pdev, > + struct bcm_i2s_priv *i2s_priv) { > + int ret; > + > + i2s_priv->r_irq = platform_get_resource(pdev, IORESOURCE_IRQ, 0); > + if (!i2s_priv->r_irq) { > + dev_err(&pdev->dev, "Unable to get register irq resource.\n"); > + return -ENODEV; > + } > + > + ret = devm_request_irq(&pdev->dev, i2s_priv->r_irq->start, i2s_dma_isr, > + i2s_priv->r_irq->flags, "i2s_dma", (void *)i2s_priv); > + if (ret) { > + dev_err(&pdev->dev, > + "i2s_init: failed to request interrupt.ret=%d\n", ret); > + return ret; > + } > + > + return devm_snd_soc_register_component(&pdev->dev, > + &bcm63xx_soc_platform, NULL, 0); } > + > +int bcm63xx_soc_platform_remove(struct platform_device *pdev) { > + return 0; > +} How does one probe this module if the bcm63xx_soc_platform_probe() functions are not called from anywhere and/or hooked up to the module entry/exit points? Are you not missing a platform_driver entry which matches the compatible string you defined? -- Florian