From: Jiri Slaby <jirislaby@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>,
Eckert.Florian@googlemail.com, gregkh@linuxfoundation.org,
pavel@ucw.cz, lee@kernel.org, kabel@kernel.org,
u.kleine-koenig@pengutronix.de
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-leds@vger.kernel.org
Subject: Re: [PATCH v3 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces.
Date: Mon, 16 Oct 2023 14:32:25 +0200 [thread overview]
Message-ID: <31ec59fb-4bcf-4c70-996a-ea67b4bfcd2b@kernel.org> (raw)
In-Reply-To: <20231016071332.597654-2-fe@dev.tdt.de>
On 16. 10. 23, 9:13, Florian Eckert wrote:
> Tabs were used in the function description, to make this look more
> uniform, the tabs were replaced by spaces where necessary.
>
> Signed-off-by: Florian Eckert <fe@dev.tdt.de>
Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
LGTM (spihnx prefers spaces), except:
> @@ -3470,7 +3470,7 @@ int tty_register_driver(struct tty_driver *driver)
> EXPORT_SYMBOL(tty_register_driver);
>
> /**
> - * tty_unregister_driver -- unregister a tty driver
> + * tty_unregister_driver - unregister a tty driver
you should have noted you changed ndashes to dashes too. (As only the
latter is supported by sphinx.)
thanks,
--
js
suse labs
next prev parent reply other threads:[~2023-10-16 12:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-16 7:13 [PATCH v3 0/4] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-10-16 7:13 ` [PATCH v3 1/4] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-16 12:32 ` Jiri Slaby [this message]
2023-10-18 10:56 ` Florian Eckert
2023-10-18 13:34 ` Greg KH
2023-10-16 7:13 ` [PATCH v3 2/4] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-16 7:13 ` [PATCH v3 3/4] trigger: ledtrig-tty: move variable definition to the top Florian Eckert
2023-10-16 8:46 ` m.brock
2023-10-16 9:12 ` Florian Eckert
2023-10-16 12:39 ` Jiri Slaby
2023-10-19 9:12 ` m.brock
2023-10-16 7:13 ` [PATCH v3 4/4] trigger: ledtrig-tty: add new line mode to triggers Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31ec59fb-4bcf-4c70-996a-ea67b4bfcd2b@kernel.org \
--to=jirislaby@kernel.org \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=gregkh@linuxfoundation.org \
--cc=kabel@kernel.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.