From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH v6 1/7] drm/rockchip: vop: initialize registers directly Date: Thu, 27 Jul 2017 00:44:09 +0200 Message-ID: <3205727.pYBXLEh47x@phil> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Mark Yao Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: linux-rockchip.vger.kernel.org QW0gTWl0dHdvY2gsIDI2LiBKdWxpIDIwMTcsIDE0OjE5OjA1IENFU1Qgc2NocmllYiBNYXJrIFlh bzoKPiBBdCBwcmVzZW50IHdlIGFyZSB1c2luZyBpbml0X3RhYmxlIHRvIGluaXRpYWxpemUgc29t ZQo+IHJlZ2lzdGVycywgYnV0IHRoZSBSZWdpc3RlciBpbml0IHRhYmxlIHVzZSB1bi1kb2N1bWVu dCBkZWZpbmUsCj4gaXQgaXMgdW5yZWFkYWJsZSwgYW5kIHNvbWV0aW1lcyB3ZSBvbmx5IHdhbnQg dG8gdXBkYXRlIHRpbnkKPiBiaXRzLCBpbml0IHRhYmxlIG1ldGhvZCBpcyBub3QgZnJpZW5kbHks IGl0J3MgZGlmZmN1bHQgdG8KPiByZXVzZSBmb3IgZGlmZmVyZW5jZSBjaGlwcy4KPiAKPiBUbyBt YWtlIGl0IGNsZWFuLCBpbml0aWFsaXplIHJlZ2lzdGVycyBkaXJlY3RseSwgYW5kIGRyb3BzCj4g aW5pdF90YWJsZSBtZWNoYW5pc20gb3V0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IE1hcmsgWWFvIDxt YXJrLnlhb0Byb2NrLWNoaXBzLmNvbT4KCm9uIHJrMzAzNiBhbmQgcmszMjg4ClRlc3RlZC1ieTog SGVpa28gU3R1ZWJuZXIgPGhlaWtvQHNudGVjaC5kZT4KCgpIZWlrbwpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Thu, 27 Jul 2017 00:44:09 +0200 Subject: [PATCH v6 1/7] drm/rockchip: vop: initialize registers directly In-Reply-To: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> Message-ID: <3205727.pYBXLEh47x@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Mittwoch, 26. Juli 2017, 14:19:05 CEST schrieb Mark Yao: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly, it's diffcult to > reuse for difference chips. > > To make it clean, initialize registers directly, and drops > init_table mechanism out. > > Signed-off-by: Mark Yao on rk3036 and rk3288 Tested-by: Heiko Stuebner Heiko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751481AbdGZWoX (ORCPT ); Wed, 26 Jul 2017 18:44:23 -0400 Received: from gloria.sntech.de ([95.129.55.99]:57440 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751070AbdGZWoW (ORCPT ); Wed, 26 Jul 2017 18:44:22 -0400 From: Heiko Stuebner To: Mark Yao Cc: David Airlie , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 1/7] drm/rockchip: vop: initialize registers directly Date: Thu, 27 Jul 2017 00:44:09 +0200 Message-ID: <3205727.pYBXLEh47x@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> References: <1501049930-5794-1-git-send-email-mark.yao@rock-chips.com> <1501049946-5877-1-git-send-email-mark.yao@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Mittwoch, 26. Juli 2017, 14:19:05 CEST schrieb Mark Yao: > At present we are using init_table to initialize some > registers, but the Register init table use un-document define, > it is unreadable, and sometimes we only want to update tiny > bits, init table method is not friendly, it's diffcult to > reuse for difference chips. > > To make it clean, initialize registers directly, and drops > init_table mechanism out. > > Signed-off-by: Mark Yao on rk3036 and rk3288 Tested-by: Heiko Stuebner Heiko