From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: omap4: support for manually updated display Date: Mon, 10 Sep 2018 15:24:37 +0300 Message-ID: <3205865.8O8aibZXye@avalon> References: <20180830090456.GA17277@amd> <797c13fa-7a5b-a809-7dd0-14b01a3046be@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <797c13fa-7a5b-a809-7dd0-14b01a3046be@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Tomi Valkeinen Cc: mpartap@gmx.net, tony@atomide.com, merlijn@wizzup.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, sre@kernel.org, nekit1000@gmail.com, Pavel Machek , linux-omap@vger.kernel.org, linux-arm-kernel List-Id: linux-omap@vger.kernel.org SGVsbG8sCgpPbiBNb25kYXksIDEwIFNlcHRlbWJlciAyMDE4IDE0OjU5OjIzIEVFU1QgVG9taSBW YWxrZWluZW4gd3JvdGU6Cj4gSGkgUGF2ZWwsCj4gCj4gKGRyb3BwaW5nIERhdmUsIG5vIG5lZWQg dG8gc3BhbSBoaW0pCj4gCj4gT24gMzAvMDgvMTggMTI6MDQsIFBhdmVsIE1hY2hlayB3cm90ZToK PiA+IEhpIQo+ID4gCj4gPiBUaGVyZSdzIG5lYXQgc2VyaWVzIG9mIHBhdGNoZXMgb24KPiA+IAo+ ID4gaHR0cHM6Ly9naXQua2VybmVsLm9yZy9wdWIvc2NtL2xpbnV4L2tlcm5lbC9naXQvdG1saW5k L2xpbnV4LW9tYXAuZ2l0L2xvZy8KPiA+ID9oPWRyb2lkNC1wZW5kaW5nLXY0LjE5Cj4gPiAKPiA+ IFRoZXkgZW5hYmxlIGRpc3BsYXkgc3VwcG9ydCBmb3IgbXkgaGFyZHdhcmUuIEFzIHlvdSBjYW4g aW1hZ2luZSwKPiA+IGRpc3BsYXkgaXMgcmF0aGVyIGltcG9ydGFudCBmb3IgYSBjZWxscGhvbmUu Cj4gPiAKPiA+IFRvbWksIGNhbiB5b3UgdGFrZSB0aGUgcGF0Y2hlcz8gSSBjYW4gcmVzdWJtaXQg dGhlbSBpbiBlbWFpbCwgb3IKPiA+IHNodWZmbGUgdGhlbSB0byBhbm90aGVyIGJyYW5jaCB3aXRo b3V0IG1mZCBjaGFuZ2VzLCBvciBjbGVhbiB0aGVtIHVwCj4gPiBldGMuLi4KPiAKPiBBIGxhcmdl IG9tYXBkcm0gY2hhbmdlIHNldCBmcm9tIExhdXJlbnQgd2FzIG1lcmdlZCBpbnRvIGRybS1uZXh0 LCBhbmQKPiBJJ20gY2VydGFpbiB0aGV5IGNvbmZsaWN0IHdpdGggdGhpcyBzZXJpZXMuIExhdXJl bnQgYWxzbyBoYXMgY29udGludWVkCj4gdGhhdCB3b3JrLCBhbmQgd2hpbGUgdGhvc2UgbmV3IHBh dGNoZXMgaGF2ZW4ndCBiZWVuIHNlbnQgZm9yIHJldmlldyB5ZXQsCj4gSSBmZWFyIHRoZXknbGwg YWxzbyBjb25mbGljdCB3aXRoIHRoZXNlLgo+IAo+IFNvIGluIHRoZSBtaW5pbXVtLCBhIHJlYmFz ZSBvbiB0b3Agb2YgZHJtLW5leHQgaXMgbmVlZGVkLgo+IAo+IEkgYWxzbyBjb250aW51ZSB0byBi ZSB2ZXJ5IHdvcnJpZWQgdGhhdCBhZGRpbmcgRFNJIHN1cHBvcnQgdG8gb21hcGRybSBhdAo+IHRo aXMgc3RhZ2Ugd2lsbCBiZSBhIGh1Z2UgZXh0cmEgYnVyZGVuIGZvciBMYXVyZW50J3Mgd29yay4K PiAKPiBXZSBzaG91bGQgdHJhbnNmb3JtIHRoZSBwYW5lbC1kc2ktY20uYyB0b3dhcmRzIHRoZSBj b21tb24gRFJNIG1vZGVsLgo+IFdpdGggYSBxdWljayBsb29rLCB0aGVyZSBzZWVtcyB0byBiZSBh IGRyaXZlciBmb3IgU2Ftc3VuZydzIFM2RTYzSjBYMDMKPiBwYW5lbC4gU28gcG9zc2libHkgYWxs IHRoZSBEU0kgZmVhdHVyZXMgYXJlIHRoZXJlIGluIHRoZSBEUk0gZnJhbWV3b3JrLAo+IGJ1dCBz b21lb25lIG5lZWRzIHRvIGNoZWNrIHRoYXQgYW5kIHN0YXJ0IHdvcmtpbmcgb24gcGFuZWwtZHNp LWNtLmMgc28KPiB0aGF0IGl0J3MgcmVhZHkgd2hlbiB3ZSBmaW5hbGx5IHN3aXRjaCB0byB0aGUg RFJNIG1vZGVsLgo+IAo+IEluIG15IG9waW5pb24sIHdoaWNoIEkndmUgYWxzbyBleHByZXNzZWQg YmVmb3JlLCB0aGUgYWJvdmUgd29yayBpcyBtdWNoCj4gZWFzaWVyIHRvIGRvIGJ5IGZpcnN0IGNo YW5naW5nIHRoZSBvbWFwZHJtIHRvIERSTSBtb2RlbCwgd2l0aG91dCBhbnkgRFNJCj4gZGlzcGxh eXMsIGFuZCB0aGVuIGFkZCB0aGUgRFNJIGNvbW1hbmQgbW9kZSBzdXBwb3J0LiBCdXQgaWYgcGVv cGxlCj4gaW5zaXN0IG9uIGFkZGluZyB0aGUgRFNJIHN1cHBvcnQgYWxyZWFkeSBub3csIEkgd291 bGQgYXBwcmVjaWF0ZSB0aGUKPiBzYW1lIHBlb3BsZSB3b3JraW5nIG9uIHRoZSBEU0kgc3VwcG9y dCBzbyB0aGF0IExhdXJlbnQgZG9lc24ndCBoYXZlIHRvCj4gZG8gaXQgYWxsLgoKSSB3YW50IHRv IG1ha2UgaXQgY2xlYXIgdGhhdCBJIGRvbid0IHdhbnQgdG8gY2xhaW0gYW55IHByaXZpbGVnZSBp biBnZXR0aW5nIApwYXRjaGVzIG1lcmdlZCBmaXJzdC4gSSBhbSBob3dldmVyIHdvcnJpZWQgdGhh dCwgd2l0aG91dCBhbiBlYXN5IHdheSB0byB0ZXN0IApEU0kgc3VwcG9ydCwgYW5kIHdpdGhvdXQg ZW5vdWdoIHRpbWUgdG8gZm9jdXMgb24gaXQsIEkgd291bGQgYnJlYWsgd2hhdGV2ZXIgCndvdWxk IGJlIG1lcmdlZCBub3cgaW4gZnV0dXJlIHJld29ya3MuIEkgd291bGQgdGh1cyBsaWtlIHRvIGZp bmQgb3V0IGhvdyB0byAKY29sbGFib3JhdGUgb24gdGhpcyB0YXNrLCBob3BlZnVsbHkgdG8gbW92 ZSB0b3dhcmRzIHVzYWdlIG9mIGRybV9icmlkZ2UgYW5kIApkcm1fcGFuZWwgZm9yIERTSS1iYXNl ZCBwaXBlbGluZXMuCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcg bGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Mon, 10 Sep 2018 15:24:37 +0300 Subject: omap4: support for manually updated display In-Reply-To: <797c13fa-7a5b-a809-7dd0-14b01a3046be@ti.com> References: <20180830090456.GA17277@amd> <797c13fa-7a5b-a809-7dd0-14b01a3046be@ti.com> Message-ID: <3205865.8O8aibZXye@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello, On Monday, 10 September 2018 14:59:23 EEST Tomi Valkeinen wrote: > Hi Pavel, > > (dropping Dave, no need to spam him) > > On 30/08/18 12:04, Pavel Machek wrote: > > Hi! > > > > There's neat series of patches on > > > > https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/ > > ?h=droid4-pending-v4.19 > > > > They enable display support for my hardware. As you can imagine, > > display is rather important for a cellphone. > > > > Tomi, can you take the patches? I can resubmit them in email, or > > shuffle them to another branch without mfd changes, or clean them up > > etc... > > A large omapdrm change set from Laurent was merged into drm-next, and > I'm certain they conflict with this series. Laurent also has continued > that work, and while those new patches haven't been sent for review yet, > I fear they'll also conflict with these. > > So in the minimum, a rebase on top of drm-next is needed. > > I also continue to be very worried that adding DSI support to omapdrm at > this stage will be a huge extra burden for Laurent's work. > > We should transform the panel-dsi-cm.c towards the common DRM model. > With a quick look, there seems to be a driver for Samsung's S6E63J0X03 > panel. So possibly all the DSI features are there in the DRM framework, > but someone needs to check that and start working on panel-dsi-cm.c so > that it's ready when we finally switch to the DRM model. > > In my opinion, which I've also expressed before, the above work is much > easier to do by first changing the omapdrm to DRM model, without any DSI > displays, and then add the DSI command mode support. But if people > insist on adding the DSI support already now, I would appreciate the > same people working on the DSI support so that Laurent doesn't have to > do it all. I want to make it clear that I don't want to claim any privilege in getting patches merged first. I am however worried that, without an easy way to test DSI support, and without enough time to focus on it, I would break whatever would be merged now in future reworks. I would thus like to find out how to collaborate on this task, hopefully to move towards usage of drm_bridge and drm_panel for DSI-based pipelines. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E75A1C4321E for ; Mon, 10 Sep 2018 12:24:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 88CFF20866 for ; Mon, 10 Sep 2018 12:24:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="EbDmiEOt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 88CFF20866 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728591AbeIJRSV (ORCPT ); Mon, 10 Sep 2018 13:18:21 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:52494 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728357AbeIJRST (ORCPT ); Mon, 10 Sep 2018 13:18:19 -0400 Received: from avalon.localnet (dfj612ybrt5fhg77mgycy-3.rev.dnainternet.fi [IPv6:2001:14ba:21f5:5b00:2e86:4862:ef6a:2804]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 204E857; Mon, 10 Sep 2018 14:24:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1536582267; bh=E9hjhMv5RUBibOU8G/HI+xSlQMUvCtSNjZvVmRt4mss=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EbDmiEOtHRlXF8GhCrM4y09ZznT+mUKJIHWq4YxZ7JAmovx9TX3erDxmm33S5/Ase NQx9F8BK9UGfQ1y9ZPoue1oWq13Ff6I7vYHc2jgn6Mu/37aKigISRX5ylUGAVSiD6V M2icAfpvbkyRq4lxGt3WEjSs3Y49IQhSWq0RcvqU= From: Laurent Pinchart To: Tomi Valkeinen Cc: Pavel Machek , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org, nekit1000@gmail.com, mpartap@gmx.net, merlijn@wizzup.org Subject: Re: omap4: support for manually updated display Date: Mon, 10 Sep 2018 15:24:37 +0300 Message-ID: <3205865.8O8aibZXye@avalon> Organization: Ideas on Board Oy In-Reply-To: <797c13fa-7a5b-a809-7dd0-14b01a3046be@ti.com> References: <20180830090456.GA17277@amd> <797c13fa-7a5b-a809-7dd0-14b01a3046be@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Monday, 10 September 2018 14:59:23 EEST Tomi Valkeinen wrote: > Hi Pavel, > > (dropping Dave, no need to spam him) > > On 30/08/18 12:04, Pavel Machek wrote: > > Hi! > > > > There's neat series of patches on > > > > https://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap.git/log/ > > ?h=droid4-pending-v4.19 > > > > They enable display support for my hardware. As you can imagine, > > display is rather important for a cellphone. > > > > Tomi, can you take the patches? I can resubmit them in email, or > > shuffle them to another branch without mfd changes, or clean them up > > etc... > > A large omapdrm change set from Laurent was merged into drm-next, and > I'm certain they conflict with this series. Laurent also has continued > that work, and while those new patches haven't been sent for review yet, > I fear they'll also conflict with these. > > So in the minimum, a rebase on top of drm-next is needed. > > I also continue to be very worried that adding DSI support to omapdrm at > this stage will be a huge extra burden for Laurent's work. > > We should transform the panel-dsi-cm.c towards the common DRM model. > With a quick look, there seems to be a driver for Samsung's S6E63J0X03 > panel. So possibly all the DSI features are there in the DRM framework, > but someone needs to check that and start working on panel-dsi-cm.c so > that it's ready when we finally switch to the DRM model. > > In my opinion, which I've also expressed before, the above work is much > easier to do by first changing the omapdrm to DRM model, without any DSI > displays, and then add the DSI command mode support. But if people > insist on adding the DSI support already now, I would appreciate the > same people working on the DSI support so that Laurent doesn't have to > do it all. I want to make it clear that I don't want to claim any privilege in getting patches merged first. I am however worried that, without an easy way to test DSI support, and without enough time to focus on it, I would break whatever would be merged now in future reworks. I would thus like to find out how to collaborate on this task, hopefully to move towards usage of drm_bridge and drm_panel for DSI-based pipelines. -- Regards, Laurent Pinchart