From: Thomas Monjalon <thomas@monjalon.net>
To: "Wiles, Keith" <keith.wiles@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH 3/6] net/tap: check interface name in kvargs
Date: Tue, 15 Jan 2019 03:01:25 +0100 [thread overview]
Message-ID: <3206134.sXzW2Za7dA@xps> (raw)
In-Reply-To: <832D25F2-DEC4-4404-8A9F-4043D7609936@intel.com>
11/01/2019 20:50, Wiles, Keith:
>
> > On Jan 11, 2019, at 1:49 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> >
> > On Fri, 11 Jan 2019 19:37:00 +0000
> > "Wiles, Keith" <keith.wiles@intel.com> wrote:
> >
> >>> +/* make sure name is a possible Linux network device name */
> >>> +static bool is_valid_iface(const char *name)
> >>
> >> I am sorry, but the function name must be on the next line as per the style. I know you do not like it, but that is what the style states.
> >
> > I am surprised because most of the DPDK follows kernel style.
> > And in kernel style one line is preferred if line is not too long.
>
> Last time I looked at the DPDK coding style it is not the case. We do not really follow Linux coding style only started with it and made changes :-(
Not really. The original code style is borrowed from FreeBSD:
https://www.freebsd.org/cgi/man.cgi?query=style&sektion=9
next prev parent reply other threads:[~2019-01-15 2:01 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-11 18:06 [PATCH 0/6] net/tap: fixes and cleanups Stephen Hemminger
2019-01-11 18:06 ` [PATCH 1/6] net/tap: use strlcpy for interface name Stephen Hemminger
2019-01-11 18:06 ` [PATCH 2/6] net/tap: allow full length names Stephen Hemminger
2019-01-11 19:32 ` Wiles, Keith
2019-01-11 19:48 ` Stephen Hemminger
2019-01-11 19:49 ` Wiles, Keith
2019-01-11 18:06 ` [PATCH 3/6] net/tap: check interface name in kvargs Stephen Hemminger
2019-01-11 19:37 ` Wiles, Keith
2019-01-11 19:49 ` Stephen Hemminger
2019-01-11 19:50 ` Wiles, Keith
2019-01-15 2:01 ` Thomas Monjalon [this message]
2019-01-11 22:20 ` Luse, Paul E
2019-01-11 18:06 ` [PATCH 4/6] net/tap: lower the priority of log messages Stephen Hemminger
2019-01-11 18:06 ` [PATCH 5/6] net/tap: let kernel choose tun device name Stephen Hemminger
2019-01-11 19:43 ` Wiles, Keith
2019-01-11 18:06 ` [PATCH 6/6] net/tap: get rid of global tuntap_name Stephen Hemminger
2019-01-11 19:47 ` [PATCH 0/6] net/tap: fixes and cleanups Wiles, Keith
2019-01-11 20:35 ` [PATCH v2 " Stephen Hemminger
2019-01-11 20:35 ` [PATCH v2 1/7] net/tap: use strlcpy for interface name Stephen Hemminger
2019-01-11 20:35 ` [PATCH v2 2/7] net/tap: allow full length names Stephen Hemminger
2019-01-11 20:35 ` [PATCH v2 3/7] net/tap: check interface name in kvargs Stephen Hemminger
2019-01-11 20:35 ` [PATCH v2 4/7] net/tap: lower the priority of log messages Stephen Hemminger
2019-01-11 20:35 ` [PATCH v2 5/7] net/tap: let kernel choose tun device name Stephen Hemminger
2019-01-11 20:35 ` [PATCH v2 6/7] net/tap: get rid of global tuntap_name Stephen Hemminger
2019-01-11 20:35 ` [PATCH v2 7/7] net/tap: don't print pointer in info message Stephen Hemminger
2019-01-14 14:10 ` Ferruh Yigit
2019-01-14 15:07 ` Wiles, Keith
2019-01-14 14:10 ` [PATCH v2 0/6] net/tap: fixes and cleanups Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3206134.sXzW2Za7dA@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.