From: "Martin J. Bligh" <mbligh@mbligh.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, Con Kolivas <kernel@kolivas.org>
Subject: Re: 2.6.12-mm1 boot failure on NUMA box.
Date: Fri, 24 Jun 2005 10:09:27 -0700 [thread overview]
Message-ID: <320710000.1119632967@flay> (raw)
In-Reply-To: <20050624170112.GD6393@elte.hu>
>> OK, still broken with the last 3 backed out, but works with the last 4
>> backed out. So I guess it's scheduler-cache-hot-autodetect.patch that
>> breaks it. Con just sent me something else to try to fix it in order
>> to run next ... will do that.
>
> hm. Does it work if you disable migration-autodetect via passing in e.g.
> migration_cost=1000,2000,3000 on the boot line? Is it perhaps the
> excessive debugging that hurts.
>
> or does it work if you undo the chunk below? Seemed harmless, but has
> CONFIG_NUMA relevance.
>
> Ingo
>
> --- linux/arch/i386/kernel/timers/timer_tsc.c.orig
> +++ linux/arch/i386/kernel/timers/timer_tsc.c
> @@ -133,18 +133,15 @@ static unsigned long long monotonic_cloc
>
> /*
> * Scheduler clock - returns current time in nanosec units.
> + *
> + * it's not a problem if the TSC is unsynchronized,
> + * as the scheduler will carefully compensate for it.
> */
> unsigned long long sched_clock(void)
> {
> unsigned long long this_offset;
>
> - /*
> - * In the NUMA case we dont use the TSC as they are not
> - * synchronized across all CPUs.
> - */
> -#ifndef CONFIG_NUMA
> - if (!use_tsc)
> -#endif
> + if (!cpu_has_tsc)
> /* no locking but a rare wrong value is not a big deal */
> return jiffies_64 * (1000000000 / HZ);
Humpf. That does look dangerous on a NUMA-Q. The TSCs aren't synced,
and we can't use them .... have to use PIT, whether the CPUs have TSC
or not.
M.
next prev parent reply other threads:[~2005-06-24 17:13 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-21 5:07 2.6.12-mm1 boot failure on NUMA box Martin J. Bligh
2005-06-21 6:29 ` Andrew Morton
2005-06-21 14:22 ` Martin J. Bligh
2005-06-21 20:03 ` Andrew Morton
2005-06-24 14:11 ` Martin J. Bligh
2005-06-24 14:14 ` Con Kolivas
2005-06-24 15:31 ` Martin J. Bligh
2005-06-24 17:01 ` Ingo Molnar
2005-06-24 17:09 ` Martin J. Bligh [this message]
2005-06-24 19:52 ` Ingo Molnar
2005-06-24 20:08 ` Nish Aravamudan
2005-06-24 20:56 ` Martin J. Bligh
2005-06-25 4:00 ` Ingo Molnar
2005-06-25 6:42 ` Martin J. Bligh
2005-06-25 9:09 ` Ingo Molnar
2005-06-25 18:08 ` Lee Revell
2005-06-25 21:03 ` Martin J. Bligh
2005-06-25 21:54 ` Lee Revell
2005-06-28 22:09 ` Martin J. Bligh
[not found] <208690000.1119330454@[10.10.2.4].suse.lists.linux.kernel>
2005-06-21 11:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320710000.1119632967@flay \
--to=mbligh@mbligh.org \
--cc=akpm@osdl.org \
--cc=kernel@kolivas.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.