From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A8EF8C19F32 for ; Thu, 27 Feb 2025 15:24:36 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tnfk0-0001fp-H1; Thu, 27 Feb 2025 10:24:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnfjz-0001d4-EA for grub-devel@gnu.org; Thu, 27 Feb 2025 10:23:59 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tnfjx-0008JF-Bh for grub-devel@gnu.org; Thu, 27 Feb 2025 10:23:58 -0500 Received: from pps.filterd (m0356517.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 51RBCJ1F018914; Thu, 27 Feb 2025 15:23:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pp1; bh=1GekwK Ioo2WJLnCPn9fXHPifZOitd8XY8gt6oj8Dr9k=; b=tJ4gMi11vb07J92mpfE6EV 7jhKAj/TldEL9LZ7Zzf/zoDVBsq6sL4o5b/RNPG9DR+eupufzuCrpA6w2TrpAPwi laZ7n0c4cHe/ZtYPmZ9rkzb/1OPCxMeNtv3Suu/GXKSU/LR2y+BY/zxlB5YPH4N9 QZvcok/Xfz61QwsnNVtVDVjT0jnp4IGBrjR/Nn4EVK5zQbRlBMZzDMhtASfCAtN3 UQ/HKeMnLzT0PD16QmXAFSdGP1rLxOczugDOg1dNyYSnCmqThf6LZKywAxtecmMy 6HOruMajTX7TsqqlKBrVmBKoz6vJnvT1JYsMMkm+WPUvyN7jq8PYB+aTLyMGaYww == Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 452c3a45tg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Feb 2025 15:23:53 +0000 (GMT) Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 51RCxR2U027396; Thu, 27 Feb 2025 15:23:52 GMT Received: from smtprelay05.dal12v.mail.ibm.com ([172.16.1.7]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 44ytdks6wh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 27 Feb 2025 15:23:52 +0000 Received: from smtpav05.wdc07v.mail.ibm.com (smtpav05.wdc07v.mail.ibm.com [10.39.53.232]) by smtprelay05.dal12v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 51RFNocr63832386 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 27 Feb 2025 15:23:51 GMT Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B88BF58059; Thu, 27 Feb 2025 15:23:50 +0000 (GMT) Received: from smtpav05.wdc07v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id D0EBC58053; Thu, 27 Feb 2025 15:23:49 +0000 (GMT) Received: from ltc.linux.ibm.com (unknown [9.5.196.140]) by smtpav05.wdc07v.mail.ibm.com (Postfix) with ESMTP; Thu, 27 Feb 2025 15:23:49 +0000 (GMT) MIME-Version: 1.0 Date: Thu, 27 Feb 2025 20:53:49 +0530 From: sudhakar To: Stefan Berger Cc: grub-devel@gnu.org, dja@axtens.net, jan.setjeeilers@oracle.com, julian.klode@canonical.com, mate.kukri@canonical.com, pjones@redhat.com, avnish@linux.ibm.com, nayna@linux.ibm.com, ssrish@linux.ibm.com Subject: Re: [PATCH v1 19/21] appendedsig: Reads the default DB keys from ELF Note In-Reply-To: <657c822e-aab5-43c1-8e27-79f2bb236c02@linux.ibm.com> References: <20241218145647.1390837-1-sudhakar@linux.ibm.com> <20241218145647.1390837-20-sudhakar@linux.ibm.com> <657c822e-aab5-43c1-8e27-79f2bb236c02@linux.ibm.com> Message-ID: <32083eac64357a4f4bbf859fcb1d7960@linux.ibm.com> X-Sender: sudhakar@linux.ibm.com X-TM-AS-GCONF: 00 X-Proofpoint-GUID: vyCT10SzWw0iWmF3IV6A-uCE1VE5GtZg X-Proofpoint-ORIG-GUID: vyCT10SzWw0iWmF3IV6A-uCE1VE5GtZg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1057,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-02-27_06,2025-02-27_01,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 impostorscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 mlxlogscore=999 clxscore=1015 adultscore=0 spamscore=0 lowpriorityscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2502100000 definitions=main-2502270114 Received-SPF: pass client-ip=148.163.156.1; envelope-from=sudhakar@linux.ibm.com; helo=mx0a-001b2d01.pphosted.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: The development of GNU GRUB Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org Sender: grub-devel-bounces+grub-devel=archiver.kernel.org@gnu.org T24gMjAyNS0wMS0wMiAxODo0OSwgU3RlZmFuIEJlcmdlciB3cm90ZToKPiBPbiAxMi8xOC8yNCA5 OjU2IEFNLCBTdWRoYWthciBLdXBwdXNhbXkgd3JvdGU6Cj4+IGlmIHNlY3VyZSBib290IGVuYWJs ZWQgd2l0aCBQS1MgYW5kIHNldCB1c2Vfc3RhdGljX2tleXMgZmxhZywgaXQKPiAKPiBJZiBTZWN1 cmUgQm9vdCBpcyBlbmFibGVkIHdpdGggUEtTIGFuZCB0aGUgdXNlX3N0YXRpY19rZXlzIGZsYWcg aXMKPiBzZXQsIHRoZW4gcmVhZCB0aGUgREIgZGVmYXVsdCBrZXlzIGZyb20gdGhlIEVMRiBub3Rl IGFuZCBzdG9yZSB0aGVtIGluCj4gdGhlIHRydXN0ZWQgbGlzdCBidWZmZXIuCj4gCj4+IHJlYWRz IHRoZSBEQiBkZWZhdWx0IGtleXMgZnJvbSBFTEYgTm90ZSBhbmQgc3RvcmUgaXQgaW4gdHJ1c3Rl ZCBsaXN0IAo+PiBidWZmZXIuCj4+IAo+PiBTaWduZWQtb2ZmLWJ5OiBTdWRoYWthciBLdXBwdXNh bXkgPHN1ZGhha2FyQGxpbnV4LmlibS5jb20+Cj4+IC0tLQo+PiAgIGdydWItY29yZS9jb21tYW5k cy9hcHBlbmRlZHNpZy9hcHBlbmRlZHNpZy5jIHwgNTggCj4+ICsrKysrKysrKysrKysrLS0tLS0t Cj4+ICAgMSBmaWxlIGNoYW5nZWQsIDQxIGluc2VydGlvbnMoKyksIDE3IGRlbGV0aW9ucygtKQo+ PiAKPj4gZGlmZiAtLWdpdCBhL2dydWItY29yZS9jb21tYW5kcy9hcHBlbmRlZHNpZy9hcHBlbmRl ZHNpZy5jIAo+PiBiL2dydWItY29yZS9jb21tYW5kcy9hcHBlbmRlZHNpZy9hcHBlbmRlZHNpZy5j Cj4+IGluZGV4IDhiMDg0MDg3ZS4uOWE5ZjRlZjFjIDEwMDY0NAo+PiAtLS0gYS9ncnViLWNvcmUv Y29tbWFuZHMvYXBwZW5kZWRzaWcvYXBwZW5kZWRzaWcuYwo+PiArKysgYi9ncnViLWNvcmUvY29t bWFuZHMvYXBwZW5kZWRzaWcvYXBwZW5kZWRzaWcuYwo+PiBAQCAtMTA4Miw3ICsxMDgyLDcgQEAg Z3J1Yl9jcmVhdGVfZGlzdHJ1c3RlZF9saXN0ICh2b2lkKQo+PiAgICAqIHBhcnNlcyBpdCwgYW5k IGFkZHMgaXQgdG8gdGhlIHRydXN0ZWQgbGlzdC4KPj4gICAgKi8KPj4gICBzdGF0aWMgZ3J1Yl9l cnJfdAo+PiAtZ3J1Yl9idWlsZF9zdGF0aWNfdHJ1c3RlZF9saXN0IChjb25zdCBzdHJ1Y3QgZ3J1 Yl9tb2R1bGVfaGVhZGVyIAo+PiAqaGVhZGVyKQo+PiArZ3J1Yl9idWlsZF9zdGF0aWNfdHJ1c3Rl ZF9saXN0IChjb25zdCBzdHJ1Y3QgZ3J1Yl9tb2R1bGVfaGVhZGVyIAo+PiAqaGVhZGVyLCBjb25z dCBncnViX2Jvb2xfdCBtb2RlKQo+IAo+IEEgbW9yZSBtZWFuaW5nZnVsIHZhcmlhYmxlIG5hbWUg dGhhbiAnbW9kZScgd291bGQgYmUgZ29vZC4gbW9kZSA9IHRydWUKPiBvciBmYWxzZSBkb2Vzbid0 IG1lYW4gbXVjaC4KPiAKPj4gICB7Cj4+ICAgICBncnViX2Vycl90IGVyciA9IEdSVUJfRVJSX05P TkU7Cj4+ICAgICBzdHJ1Y3QgZ3J1Yl9maWxlIHBzZXVkb19maWxlOwo+PiBAQCAtMTEwMSw3ICsx MTAxLDE0IEBAIGdydWJfYnVpbGRfc3RhdGljX3RydXN0ZWRfbGlzdCAoY29uc3Qgc3RydWN0IAo+ PiBncnViX21vZHVsZV9oZWFkZXIgKmhlYWRlcikKPj4gICAgIGlmIChlcnIgIT0gR1JVQl9FUlJf Tk9ORSkKPj4gICAgICAgcmV0dXJuIGVycjsKPj4gICAtICBlcnIgPSBncnViX2FkZF9jZXJ0aWZp Y2F0ZSAoY2VydF9kYXRhLCBjZXJ0X2RhdGFfc2l6ZSwgJmdydWJfZGIsIAo+PiAxKTsKPj4gKyAg aWYgKG1vZGUpCj4+ICsgICAgewo+PiArICAgICAgZXJyID0gZ3J1Yl9pc19kaXN0cnVzdGVkX2Nl cnRfaGFzaCAoY2VydF9kYXRhLCBjZXJ0X2RhdGFfc2l6ZSk7Cj4+ICsgICAgICBpZiAoZXJyICE9 IEdSVUJfRVJSX05PTkUpCj4+ICsgICAgICAgIHJldHVybiBlcnI7Cj4+ICsgICAgfQo+PiArCj4+ ICsgIGVyciA9IGdydWJfYWRkX2NlcnRpZmljYXRlIChjZXJ0X2RhdGEsIGNlcnRfZGF0YV9zaXpl LCAmZ3J1Yl9kYiwgCj4+IG1vZGUpOwo+PiAgICAgaWYgKGNlcnRfZGF0YSAhPSBOVUxMKQo+PiAg ICAgICBncnViX2ZyZWUgKGNlcnRfZGF0YSk7Cj4+ICAgQEAgLTExNTQsNiArMTE2MSwyMCBAQCBn cnViX3JlbGVhc2VfZGlzdHJ1c3RlZF9saXN0ICh2b2lkKQo+PiAgICAgZ3J1Yl9tZW1zZXQgKCZn cnViX2RieCwgMHgwMCwgc2l6ZW9mIChncnViX2RieCkpOwo+PiAgIH0KPj4gICArc3RhdGljIGdy dWJfZXJyX3QKPj4gK2dydWJfbG9hZF9zdGF0aWNfa2V5cyAoY29uc3Qgc3RydWN0IGdydWJfbW9k dWxlX2hlYWRlciAqaGVhZGVyLCBjb25zdCAKPj4gZ3J1Yl9ib29sX3QgbW9kZSkKPj4gK3sKPj4g KyAgaW50IHJjID0gR1JVQl9FUlJfTk9ORTsKPj4gKyAgRk9SX01PRFVMRVMgKGhlYWRlcikKPj4g KyAgICB7Cj4+ICsgICAgICAvKiBOb3QgYW4gRUxGIG1vZHVsZSwgc2tpcC4gICovCj4+ICsgICAg ICBpZiAoaGVhZGVyLT50eXBlICE9IE9CSl9UWVBFX1g1MDlfUFVCS0VZKQo+PiArICAgICAgICBj b250aW51ZTsKPj4gKyAgICAgIHJjID0gZ3J1Yl9idWlsZF9zdGF0aWNfdHJ1c3RlZF9saXN0ICho ZWFkZXIsIG1vZGUpOwo+IAo+IERvIHlvdSBoYXZlIHRvIGNoZWNrIHJjIGF0IHRoaXMgcG9pbnQ/ Cj4gCj4+ICsgICAgfQo+PiArICByZXR1cm4gcmM7Cj4+ICt9Cj4+ICsKPj4gICBHUlVCX01PRF9J TklUIChhcHBlbmRlZHNpZykKPj4gICB7Cj4+ICAgICBpbnQgcmM7Cj4+IEBAIC0xMTcyLDI2ICsx MTkzLDI5IEBAIEdSVUJfTU9EX0lOSVQgKGFwcGVuZGVkc2lnKQo+PiAgICAgICBpZiAoIWdydWJf dXNlX3BsYXRmb3JtX2tleXN0b3JlICYmIGNoZWNrX3NpZ3MgPT0gCj4+IGNoZWNrX3NpZ3NfZm9y Y2VkKQo+PiAgICAgICB7Cj4+IC0gICAgICBGT1JfTU9EVUxFUyAoaGVhZGVyKQo+PiArICAgICAg cmMgPSBncnViX2xvYWRfc3RhdGljX2tleXMgKGhlYWRlciwgMCk7Cj4+ICsgICAgICBpZiAocmMg IT0gR1JVQl9FUlJfTk9ORSkKPj4gICAgICAgICAgIHsKPj4gLSAgICAgICAgICAvKiBOb3QgYW4g RUxGIG1vZHVsZSwgc2tpcC4gICovCj4+IC0gICAgICAgICAgaWYgKGhlYWRlci0+dHlwZSAhPSBP QkpfVFlQRV9YNTA5X1BVQktFWSkKPj4gLSAgICAgICAgICAgIGNvbnRpbnVlOwo+PiAtCj4+IC0g ICAgICAgICAgcmMgPSBncnViX2J1aWxkX3N0YXRpY190cnVzdGVkX2xpc3QgKGhlYWRlcik7Cj4+ IC0gICAgICAgICAgaWYgKHJjICE9IEdSVUJfRVJSX05PTkUpCj4+IC0gICAgICAgICAgICB7Cj4+ IC0gICAgICAgICAgICAgIGdydWJfcmVsZWFzZV90cnVzdGVkX2xpc3QgKCk7Cj4+IC0gICAgICAg ICAgICAgIGdydWJfZXJyb3IgKHJjLCAic3RhdGljIHRydXN0ZWQgbGlzdCBjcmVhdGlvbiBmYWls ZWQiKTsKPj4gLSAgICAgICAgICAgIH0KPj4gLSAgICAgICAgICBlbHNlCj4+IC0gICAgICAgICAg ICBncnViX3ByaW50ZiAoImFwcGVuZGVkc2lnOiB0aGUgdHJ1c3RlZCBsaXN0IG5vdyBoYXMgJSIg Cj4+IFBSSXVHUlVCX1NJWkUgIiBzdGF0aWMga2V5c1xuIiwKPj4gLSAgICAgICAgICAgICAgICAg ICAgICAgICBncnViX2RiLmtleV9lbnRyaWVzKTsKPj4gKyAgICAgICAgICBncnViX3JlbGVhc2Vf dHJ1c3RlZF9saXN0ICgpOwo+PiArICAgICAgICAgIGdydWJfZXJyb3IgKHJjLCAic3RhdGljIHRy dXN0ZWQgbGlzdCBjcmVhdGlvbiBmYWlsZWQiKTsKPj4gICAgICAgICAgIH0KPj4gKyAgICAgIGVs c2UKPj4gKyAgICAgICAgZ3J1Yl9wcmludGYgKCJhcHBlbmRlZHNpZzogdGhlIHRydXN0ZWQgbGlz dCBub3cgaGFzICUiIAo+PiBQUkl1R1JVQl9TSVpFICIgc3RhdGljIGtleXNcbiIsCj4+ICsgICAg ICAgICAgICAgICAgICAgICBncnViX2RiLmtleV9lbnRyaWVzKTsKPj4gKwo+PiAgICAgICB9Cj4+ ICAgICBlbHNlIGlmIChncnViX3VzZV9wbGF0Zm9ybV9rZXlzdG9yZSAmJiBjaGVja19zaWdzID09 IAo+PiBjaGVja19zaWdzX2ZvcmNlZCkKPj4gICAgICAgewo+PiAtICAgICAgcmMgPSBncnViX2Ny ZWF0ZV90cnVzdGVkX2xpc3QgKCk7Cj4+ICsKPj4gKyAgICAgIGlmIChncnViX3BsYXRmb3JtX2tl eXN0b3JlLnVzZV9zdGF0aWNfa2V5cyA9PSAxKQo+IAo+IGlmIChncnViX3BsYXRmb3JtX2tleXN0 b3JlLnVzZV9zdGF0aWNfa2V5cykKPiAKPj4gKyAgICAgICAgewo+PiArICAgICAgICAgIGdydWJf cHJpbnRmICgiV2FybmluZzogZGIgdmFyaWFibGUgaXMgbm90IGF2YWlsYWJsZSBhdCBQS1MgCj4+ IGFuZCB1c2luZyBhIHN0YXRpYyBrZXlzICIKPj4gKyAgICAgICAgICAgICAgICAgICAgICAgImFz IGEgZGVmYXVsdCBrZXkgaW4gdHJ1c3RlZCBsaXN0XG4iKTsKPj4gKyAgICAgICAgICByYyA9IGdy dWJfbG9hZF9zdGF0aWNfa2V5cyAoaGVhZGVyLCAxKTsKPj4gKyAgICAgICAgfQo+PiArICAgICAg ZWxzZQo+PiArICAgICAgICByYyA9IGdydWJfY3JlYXRlX3RydXN0ZWRfbGlzdCAoKTsKPj4gKwo+ PiAgICAgICAgIGlmIChyYyAhPSBHUlVCX0VSUl9OT05FKQo+PiAgICAgICAgICAgewo+PiAgICAg ICAgICAgICBncnViX3JlbGVhc2VfdHJ1c3RlZF9saXN0ICgpOwoKCmFkZHJlc3NlZCBhbGwgdGhl IGNvbW1lbnRzLiB0aGFuayB5b3UgU3RlZmFuLgoKVGhhbmtzLApTdWRoYWthciBLdXBwdXNhbXkK Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkdydWItZGV2 ZWwgbWFpbGluZyBsaXN0CkdydWItZGV2ZWxAZ251Lm9yZwpodHRwczovL2xpc3RzLmdudS5vcmcv bWFpbG1hbi9saXN0aW5mby9ncnViLWRldmVsCg==