From: Thomas Monjalon <thomas@monjalon.net>
To: Slava Ovsiienko <viacheslavo@mellanox.com>
Cc: dev@dpdk.org, Yongseok Koh <yskoh@mellanox.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup
Date: Tue, 16 Apr 2019 18:48:34 +0200 [thread overview]
Message-ID: <3211146.s7MNFNTEpE@xps> (raw)
In-Reply-To: <F627C86C-2D15-4516-B6F9-9BED06E27290@mellanox.com>
12/04/2019 21:52, Yongseok Koh:
>
> > On Apr 12, 2019, at 8:48 AM, Viacheslav Ovsiienko <viacheslavo@mellanox.com> wrote:
> >
> > At port detach routine after calling the rte_dev_remove()
> > testpmd performs some cleanup, checking the statuses of
> > remaining ports and closes the appropriate ones. The port
> > scanning is based on the new sibling iterator which uses the
> > invalid (already closed) port for reference. This patch
> > replaces the foreach iterator and uses the device object for
> > reference. It is worth to note this cleanup is not needed
> > for some drivers (at least for mlx5 and probably for others)
> > and is preserved due to possible compatibility issues.
> >
> > Fixes: 13302cd5bd63 ("app/testpmd: use port sibling iterator in device cleanup")
> >
> > Signed-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>
> > ---
> Acked-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
next prev parent reply other threads:[~2019-04-16 16:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 15:48 [dpdk-dev] [PATCH 1/1] app/testpmd: fix port detach cleanup Viacheslav Ovsiienko
2019-04-12 19:52 ` Yongseok Koh
2019-04-16 16:48 ` Thomas Monjalon [this message]
2019-04-16 17:05 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3211146.s7MNFNTEpE@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=viacheslavo@mellanox.com \
--cc=yskoh@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.