From: Thomas Monjalon <thomas@monjalon.net>
To: Jonas Pfefferle <jpf@zurich.ibm.com>
Cc: dev@dpdk.org, "Burakov, Anatoly" <anatoly.burakov@intel.com>,
jianfeng.tan@intel.com
Subject: Re: [PATCH] mem: warn if address hint is not respected
Date: Fri, 12 Jan 2018 00:36:14 +0100 [thread overview]
Message-ID: <3211441.Y6Jkbn8iFl@xps> (raw)
In-Reply-To: <55afaf0a-14cc-11b0-c7ec-21ea1bc2403f@intel.com>
07/11/2017 14:54, Burakov, Anatoly:
> On 06-Nov-17 8:26 PM, Thomas Monjalon wrote:
> > 31/10/2017 10:08, Jonas Pfefferle:
> >> Print a warning if the --base-virtaddr hint is not respected
> >> since this might lead to problems when mapping memory in
> >> the secondary process.
> >>
> >> Signed-off-by: Jonas Pfefferle <jpf@zurich.ibm.com>
> >
> > Anatoly, please review this patch.
> > It does not seem to fix something, so it is candidate for 18.02.
> >
>
> For some reason my Thunderbird ate the original email, so i'll reply to
> this one.
>
> One nitpick would be that we're calling get_virtual_area many times and
> it would probably be a good idea to make pagesize static and call
> sysconf only once. Otherwise,
>
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Applied, thanks
prev parent reply other threads:[~2018-01-11 23:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-31 9:08 [PATCH] mem: warn if address hint is not respected Jonas Pfefferle
2017-11-06 20:26 ` Thomas Monjalon
2017-11-07 13:54 ` Burakov, Anatoly
2017-11-08 11:51 ` Jonas Pfefferle1
2017-12-26 15:56 ` Xueming(Steven) Li
2018-01-03 9:22 ` Jonas Pfefferle
2018-01-03 9:37 ` Xueming(Steven) Li
2018-01-03 9:55 ` Jonas Pfefferle
2018-01-11 23:36 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3211441.Y6Jkbn8iFl@xps \
--to=thomas@monjalon.net \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=jianfeng.tan@intel.com \
--cc=jpf@zurich.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.