From: Florian Fainelli <f.fainelli@gmail.com>
To: "Álvaro Fernández Rojas" <noltari@gmail.com>,
andrew@lunn.ch, jonas.gorski@gmail.com, olteanv@gmail.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: dsa: tag_brcm: legacy: fix daisy-chained switches
Date: Tue, 21 Mar 2023 13:50:43 -0700 [thread overview]
Message-ID: <3217ce9f-1069-d63a-032c-9eeed92d896e@gmail.com> (raw)
In-Reply-To: <20230317120815.321871-1-noltari@gmail.com>
On 3/17/23 05:08, Álvaro Fernández Rojas wrote:
> When BCM63xx internal switches are connected to switches with a 4-byte
> Broadcom tag, it does not identify the packet as VLAN tagged, so it adds one
> based on its PVID (which is likely 0).
> Right now, the packet is received by the BCM63xx internal switch and the 6-byte
> tag is properly processed. The next step would to decode the corresponding
> 4-byte tag. However, the internal switch adds an invalid VLAN tag after the
> 6-byte tag and the 4-byte tag handling fails.
> In order to fix this we need to remove the invalid VLAN tag after the 6-byte
> tag before passing it to the 4-byte tag decoding.
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
prev parent reply other threads:[~2023-03-21 20:50 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 12:08 [PATCH] net: dsa: tag_brcm: legacy: fix daisy-chained switches Álvaro Fernández Rojas
2023-03-17 12:26 ` Michal Swiatkowski
2023-03-17 16:25 ` Álvaro Fernández Rojas
2023-03-17 16:32 ` Andrew Lunn
2023-03-17 16:36 ` Florian Fainelli
2023-03-17 16:40 ` Álvaro Fernández Rojas
2023-03-17 16:49 ` Jonas Gorski
2023-03-17 16:54 ` Florian Fainelli
2023-03-17 21:51 ` Álvaro Fernández Rojas
2023-03-17 22:03 ` Florian Fainelli
2023-03-19 9:55 ` [PATCH v2] " Álvaro Fernández Rojas
2023-03-21 1:58 ` Jakub Kicinski
2023-03-21 20:51 ` Florian Fainelli
2023-03-22 0:40 ` patchwork-bot+netdevbpf
2023-03-21 20:50 ` Florian Fainelli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3217ce9f-1069-d63a-032c-9eeed92d896e@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonas.gorski@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=noltari@gmail.com \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.