From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 8B7E321A421; Mon, 17 Feb 2025 17:10:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739812241; cv=none; b=esmCWSnU4syrhf5bpNCFNgTFtZG0fi4v4UMcX5ZauC1nIjepV2iJGUGyxqpi/PD+M9NtlPFR1x48YPaHcrlIFUfZCeUSaBZ32hvo9lYiP7G00F8puOO8thP40BP19hqUfdie2el1TFDftteBf3x5vl8qoFmzM24DsWjgt/WxEgc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739812241; c=relaxed/simple; bh=0+01KA7K2Nk/glEH3Wbcih7aJcSpkuWTCeB52iqLzPo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f+h3oBOyNVD+PounkwIdqqRiKBRdidcgrAv1DQjL3/9LbadGGNHGs+TkiYONrNlQi4IaOwQuvMArniczoOoeKg+xTqlxxOovonzecRvOYt5UlbzhhnhRnykBwwjn3Sc0joMrWAWSD64Do5y2Aw97cVX2Qxq8cF6ntdCnrt5sP8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 820E0152B; Mon, 17 Feb 2025 09:10:57 -0800 (PST) Received: from [10.1.27.38] (e122027.cambridge.arm.com [10.1.27.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A530C3F5A1; Mon, 17 Feb 2025 09:10:34 -0800 (PST) Message-ID: <321804ef-f852-47cf-afd7-723666ec8f62@arm.com> Date: Mon, 17 Feb 2025 17:10:32 +0000 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/7] pmdomain: rockchip: Add smc call to inform firmware To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Shawn Lin , Rob Herring , "James E . J . Bottomley" , "Martin K . Petersen" , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , "Rafael J . Wysocki" Cc: Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , YiFeng Zhao , Liang Chen , linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <1738736156-119203-1-git-send-email-shawn.lin@rock-chips.com> <1738736156-119203-5-git-send-email-shawn.lin@rock-chips.com> <2579724.BzM5BlMlMQ@diego> From: Steven Price Content-Language: en-GB In-Reply-To: <2579724.BzM5BlMlMQ@diego> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 17/02/2025 15:16, Heiko Stübner wrote: > Hi Steven, > > Am Montag, 17. Februar 2025, 15:47:21 MEZ schrieb Steven Price: >> On 05/02/2025 06:15, Shawn Lin wrote: >>> Inform firmware to keep the power domain on or off. >>> >>> Suggested-by: Ulf Hansson >>> Signed-off-by: Shawn Lin >>> --- >> >> This patch is causing my Firefly RK3288 to fail to boot, it hangs >> shortly after reaching user space, but the bootup messages include the >> suspicious line "Bad mode in prefetch abort handler detected". >> I suspect the firmware on this board doesn't support this new SMC >> correctly. Reverting this patch on top of linux-next gets everything >> working again. > > Is your board actually running some trusted firmware? Not as far as I know. > Stock rk3288 never had tf-a / psci [0], I did work on that for a while, > but don't think that ever took off. > > I'm wondering who the smcc call is calling, but don't know about > about smcc stuff. Good question - it's quite possible things are blowing up just because there's nothing there to handle the SMC. My DTB is as upstream: cpus { #address-cells = <0x01>; #size-cells = <0x00>; enable-method = "rockchip,rk3066-smp"; rockchip,pmu = <0x06>; I haven't investigated why this code is attempting to call an SMC on this board. Steve > [0] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/rockchip/rk3288.dtsi#n63 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 682C1C021A9 for ; Mon, 17 Feb 2025 17:58:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FgPZOnlQPIB9KFjZ7WqF61gCIV325yrx1FVXsqK4l6U=; b=nR3dG8+0mEICgn 8q8adk9Pw67ewi2IHoJzTFK/anS36Q0kCEKwd5VNTV8vSAPzxFfRM1jp+EONkNKGVC4+vU68Lkfyf O7cAudwKvv9AFyb/8lyK9PjSE4iNJijCoNe/gQHnQRWPTHhiz08xbhXBEK/HmFI0whEDbkQ29EqPE nAVu+H4N6BR2MTcdlF7XmAvR8iqrWwQQxkd4Sdpob8tjcaPMXXxqpBruezrmJS4qA2EBdz0ZwClBf ADjzjAj8mbn7nWm3XRdZeLZWnO3b6QF8RS/X+g/0SjOlu51Hj0m1HldbRJzibN3LVRH3NGOP5eVp6 7MzNm01KW6JtIREUiXkg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tk5OI-00000005Xkq-0M0x; Mon, 17 Feb 2025 17:58:46 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tk4dj-00000005PJO-22KD for linux-rockchip@lists.infradead.org; Mon, 17 Feb 2025 17:10:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 820E0152B; Mon, 17 Feb 2025 09:10:57 -0800 (PST) Received: from [10.1.27.38] (e122027.cambridge.arm.com [10.1.27.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id A530C3F5A1; Mon, 17 Feb 2025 09:10:34 -0800 (PST) Message-ID: <321804ef-f852-47cf-afd7-723666ec8f62@arm.com> Date: Mon, 17 Feb 2025 17:10:32 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 4/7] pmdomain: rockchip: Add smc call to inform firmware To: =?UTF-8?Q?Heiko_St=C3=BCbner?= , Shawn Lin , Rob Herring , "James E . J . Bottomley" , "Martin K . Petersen" , Krzysztof Kozlowski , Conor Dooley , Ulf Hansson , "Rafael J . Wysocki" Cc: Manivannan Sadhasivam , Alim Akhtar , Avri Altman , Bart Van Assche , YiFeng Zhao , Liang Chen , linux-scsi@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <1738736156-119203-1-git-send-email-shawn.lin@rock-chips.com> <1738736156-119203-5-git-send-email-shawn.lin@rock-chips.com> <2579724.BzM5BlMlMQ@diego> From: Steven Price Content-Language: en-GB In-Reply-To: <2579724.BzM5BlMlMQ@diego> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250217_091039_566284_6E06F3EC X-CRM114-Status: GOOD ( 13.73 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org T24gMTcvMDIvMjAyNSAxNToxNiwgSGVpa28gU3TDvGJuZXIgd3JvdGU6Cj4gSGkgU3RldmVuLAo+ IAo+IEFtIE1vbnRhZywgMTcuIEZlYnJ1YXIgMjAyNSwgMTU6NDc6MjEgTUVaIHNjaHJpZWIgU3Rl dmVuIFByaWNlOgo+PiBPbiAwNS8wMi8yMDI1IDA2OjE1LCBTaGF3biBMaW4gd3JvdGU6Cj4+PiBJ bmZvcm0gZmlybXdhcmUgdG8ga2VlcCB0aGUgcG93ZXIgZG9tYWluIG9uIG9yIG9mZi4KPj4+Cj4+ PiBTdWdnZXN0ZWQtYnk6IFVsZiBIYW5zc29uIDx1bGYuaGFuc3NvbkBsaW5hcm8ub3JnPgo+Pj4g U2lnbmVkLW9mZi1ieTogU2hhd24gTGluIDxzaGF3bi5saW5Acm9jay1jaGlwcy5jb20+Cj4+PiAt LS0KPj4KPj4gVGhpcyBwYXRjaCBpcyBjYXVzaW5nIG15IEZpcmVmbHkgUkszMjg4IHRvIGZhaWwg dG8gYm9vdCwgaXQgaGFuZ3MgCj4+IHNob3J0bHkgYWZ0ZXIgcmVhY2hpbmcgdXNlciBzcGFjZSwg YnV0IHRoZSBib290dXAgbWVzc2FnZXMgaW5jbHVkZSB0aGUgCj4+IHN1c3BpY2lvdXMgbGluZSAi QmFkIG1vZGUgaW4gcHJlZmV0Y2ggYWJvcnQgaGFuZGxlciBkZXRlY3RlZCIuCj4+IEkgc3VzcGVj dCB0aGUgZmlybXdhcmUgb24gdGhpcyBib2FyZCBkb2Vzbid0IHN1cHBvcnQgdGhpcyBuZXcgU01D IAo+PiBjb3JyZWN0bHkuIFJldmVydGluZyB0aGlzIHBhdGNoIG9uIHRvcCBvZiBsaW51eC1uZXh0 IGdldHMgZXZlcnl0aGluZyAKPj4gd29ya2luZyBhZ2Fpbi4KPiAKPiBJcyB5b3VyIGJvYXJkIGFj dHVhbGx5IHJ1bm5pbmcgc29tZSB0cnVzdGVkIGZpcm13YXJlPwoKTm90IGFzIGZhciBhcyBJIGtu b3cuCgo+IFN0b2NrIHJrMzI4OCBuZXZlciBoYWQgdGYtYSAvIHBzY2kgWzBdLCBJIGRpZCB3b3Jr IG9uIHRoYXQgZm9yIGEgd2hpbGUsCj4gYnV0IGRvbid0IHRoaW5rIHRoYXQgZXZlciB0b29rIG9m Zi4KPiAKPiBJJ20gd29uZGVyaW5nIHdobyB0aGUgc21jYyBjYWxsIGlzIGNhbGxpbmcsIGJ1dCBk b24ndCBrbm93IGFib3V0Cj4gYWJvdXQgc21jYyBzdHVmZi4KCkdvb2QgcXVlc3Rpb24gLSBpdCdz IHF1aXRlIHBvc3NpYmxlIHRoaW5ncyBhcmUgYmxvd2luZyB1cCBqdXN0IGJlY2F1c2UKdGhlcmUn cyBub3RoaW5nIHRoZXJlIHRvIGhhbmRsZSB0aGUgU01DLiBNeSBEVEIgaXMgYXMgdXBzdHJlYW06 CgogICAgICAgIGNwdXMgewogICAgICAgICAgICAgICAgI2FkZHJlc3MtY2VsbHMgPSA8MHgwMT47 CiAgICAgICAgICAgICAgICAjc2l6ZS1jZWxscyA9IDwweDAwPjsKICAgICAgICAgICAgICAgIGVu YWJsZS1tZXRob2QgPSAicm9ja2NoaXAscmszMDY2LXNtcCI7CiAgICAgICAgICAgICAgICByb2Nr Y2hpcCxwbXUgPSA8MHgwNj47CgpJIGhhdmVuJ3QgaW52ZXN0aWdhdGVkIHdoeSB0aGlzIGNvZGUg aXMgYXR0ZW1wdGluZyB0byBjYWxsIGFuIFNNQyBvbgp0aGlzIGJvYXJkLgoKU3RldmUKCj4gWzBd IGh0dHBzOi8vZ2l0Lmtlcm5lbC5vcmcvcHViL3NjbS9saW51eC9rZXJuZWwvZ2l0L3RvcnZhbGRz L2xpbnV4LmdpdC90cmVlL2FyY2gvYXJtL2Jvb3QvZHRzL3JvY2tjaGlwL3JrMzI4OC5kdHNpI242 Mwo+IAo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K TGludXgtcm9ja2NoaXAgbWFpbGluZyBsaXN0CkxpbnV4LXJvY2tjaGlwQGxpc3RzLmluZnJhZGVh ZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1y b2NrY2hpcAo=