From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Santosh Shukla <santosh.shukla@caviumnetworks.com>
Cc: Olivier Matz <olivier.matz@6wind.com>,
dev@dpdk.org, David Hunt <david.hunt@intel.com>
Subject: Re: [PATCH] test_mempool: remove unused mp_ext var
Date: Thu, 21 Jul 2016 23:57:26 +0200 [thread overview]
Message-ID: <3219554.rj5DkKP6AW@xps13> (raw)
In-Reply-To: <24109515.NGORzl0sje@xps13>
2016-07-21 15:35, Thomas Monjalon:
> 2016-07-21 15:28, Olivier Matz:
> > Hi Santosh,
> >
> > On 07/21/2016 01:49 PM, Santosh Shukla wrote:
> > > test_mempool func not using pointer variable 'mp_ext' and incorrectly freed. So
> > > removing ptr var. Now freeing mp_stack var.
> > >
> > > Signed-off-by: Santosh Shukla <santosh.shukla@caviumnetworks.com>
> >
> > Strange, it seems these modifications were present in latest patch from
> > David Hunt (v6). Maybe a bad manipulation during the push?
>
> Yes sorry, it seems to be a wrong manipulation, the v5 was pushed.
> This patch seems to fix my error, thanks.
>
> > The "Fixes:" line should be added though.
Fixes: ea151eb48a04 ("app/test: migrate custom mempool handler to stack handler")
> > Acked-by: Olivier Matz <olivier.matz@6wind.com>
Applied, thanks
prev parent reply other threads:[~2016-07-21 21:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 11:49 [PATCH] test_mempool: remove unused mp_ext var Santosh Shukla
2016-07-21 13:28 ` Olivier Matz
2016-07-21 13:35 ` Thomas Monjalon
2016-07-21 21:57 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3219554.rj5DkKP6AW@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=olivier.matz@6wind.com \
--cc=santosh.shukla@caviumnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.