From: David Howells <dhowells@redhat.com>
To: raven@themaw.net
Cc: dhowells@redhat.com, autofs@linux.kernel.org, viro@ZenIV.linux.org.uk
Subject: Bug in autofs4_d_automount()?
Date: Sat, 18 Jun 2011 00:29:48 +0100 [thread overview]
Message-ID: <32229.1308353388@redhat.com> (raw)
Hi Ian,
At the top of autofs4_d_automount() you have:
/* The daemon never triggers a mount. */
if (autofs4_oz_mode(sbi))
return NULL;
I think this should be returning -EISDIR. If by some chance we do get here in
Oz mode, this will cause the kernel to just loop forever. A return of NULL is
meant to indicate that you got a collision and that it should recheck the
mountpoint - but it does not advance path in follow_managed().
-EISDIR is the return to indicate this is to be treated as a normal directory.
David
next reply other threads:[~2011-06-17 23:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-17 23:29 David Howells [this message]
2011-06-18 9:49 ` Bug in autofs4_d_automount()? Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32229.1308353388@redhat.com \
--to=dhowells@redhat.com \
--cc=autofs@linux.kernel.org \
--cc=raven@themaw.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.