All of lore.kernel.org
 help / color / mirror / Atom feed
From: 함명주 <myungjoo.ham@samsung.com>
To: "Jean Delvare" <jdelvare@suse.de>, 최찬우 <cw00.choi@samsung.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] extcon: sm5502: Drop useless include
Date: Tue, 16 Sep 2014 23:38:09 +0000 (GMT)	[thread overview]
Message-ID: <32259363.443141410910688801.JavaMail.weblogic@epml01> (raw)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=euc-kr, Size: 934 bytes --]

> Don't include <linux/input.h> when the driver does not use anything
> from this header file.
> 
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

Chanwoo, please review/merge the patch when you return.

Cheers,
MyungJoo

> ---
>  drivers/extcon/extcon-sm5502.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- a/drivers/extcon/extcon-sm5502.c
> +++ b/drivers/extcon/extcon-sm5502.c
> @@ -17,7 +17,6 @@
>  
>  #include <linux/err.h>
>  #include <linux/i2c.h>
> -#include <linux/input.h>
>  #include <linux/interrupt.h>
>  #include <linux/irqdomain.h>
>  #include <linux/kernel.h>
> 
> -- 
> Jean Delvare
> SUSE L3 Support
> 
> 
> 
ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

             reply	other threads:[~2014-09-16 23:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-16 23:38 함명주 [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-09-16 21:16 [PATCH] extcon: sm5502: Drop useless include Jean Delvare
2014-09-22  7:01 ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32259363.443141410910688801.JavaMail.weblogic@epml01 \
    --to=myungjoo.ham@samsung.com \
    --cc=cw00.choi@samsung.com \
    --cc=jdelvare@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.