From: Subhash Jadavani <subhashj@codeaurora.org>
To: kusumi.tomohiro@gmail.com
Cc: martin.petersen@oracle.com, vinholikatti@gmail.com,
linux-scsi@vger.kernel.org, Tomohiro Kusumi <tkusumi@tuxera.com>,
linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH 5/6] scsi: ufs: remove deprecated enum for hw interrupt
Date: Tue, 28 Mar 2017 22:07:46 -0700 [thread overview]
Message-ID: <322b92e49c576c1571b648a2fbe7985f@codeaurora.org> (raw)
In-Reply-To: <20170328134929.25599-5-tkusumi@tuxera.com>
On 2017-03-28 06:49, kusumi.tomohiro@gmail.com wrote:
> From: Tomohiro Kusumi <tkusumi@tuxera.com>
>
> These flags are no longer needed after 2fbd009b in 2013.
>
> Signed-off-by: Tomohiro Kusumi <tkusumi@tuxera.com>
> ---
> drivers/scsi/ufs/ufshcd.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 089b76f..109a762 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -143,13 +143,6 @@ enum {
> UFSHCD_UIC_DME_ERROR = (1 << 5), /* DME error */
> };
>
> -/* Interrupt configuration options */
> -enum {
> - UFSHCD_INT_DISABLE,
> - UFSHCD_INT_ENABLE,
> - UFSHCD_INT_CLEAR,
> -};
> -
> #define ufshcd_set_eh_in_progress(h) \
> ((h)->eh_flags |= UFSHCD_EH_IN_PROGRESS)
> #define ufshcd_eh_in_progress(h) \
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-03-29 5:07 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 13:49 [PATCH 1/6] scsi: ufs: make ufshcd_is_{device_present,hba_active}() return bool kusumi.tomohiro
2017-03-28 13:49 ` [PATCH 2/6] scsi: ufs: use existing macro CONTROLLER_ENABLE to test register bit kusumi.tomohiro
2017-03-29 5:02 ` Subhash Jadavani
2017-03-28 13:49 ` [PATCH 3/6] scsi: ufs: non functional macro fix kusumi.tomohiro
2017-03-29 5:03 ` Subhash Jadavani
2017-03-28 13:49 ` [PATCH 4/6] scsi: ufs: add missing macros for register bits from UFSHCI spec kusumi.tomohiro
2017-03-29 5:04 ` Subhash Jadavani
2017-03-28 13:49 ` [PATCH 5/6] scsi: ufs: remove deprecated enum for hw interrupt kusumi.tomohiro
2017-03-29 5:07 ` Subhash Jadavani [this message]
2017-03-28 13:49 ` [PATCH 6/6] scsi: ufs: just use sizeof() for snprintf() kusumi.tomohiro
2017-03-29 5:08 ` Subhash Jadavani
2017-03-29 4:59 ` [PATCH 1/6] scsi: ufs: make ufshcd_is_{device_present,hba_active}() return bool Subhash Jadavani
2017-03-30 2:44 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=322b92e49c576c1571b648a2fbe7985f@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=kusumi.tomohiro@gmail.com \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=tkusumi@tuxera.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.