From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989AbcBHOzx (ORCPT ); Mon, 8 Feb 2016 09:55:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47256 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752074AbcBHOzt (ORCPT ); Mon, 8 Feb 2016 09:55:49 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1454938472.2648.173.camel@linux.vnet.ibm.com> References: <1454938472.2648.173.camel@linux.vnet.ibm.com> <1453318283.2858.27.camel@linux.vnet.ibm.com> <20160119113026.23238.4498.stgit@warthog.procyon.org.uk> <20160119113041.23238.44728.stgit@warthog.procyon.org.uk> <24522.1454513272@warthog.procyon.org.uk> To: Mimi Zohar Cc: dhowells@redhat.com, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, petkan@mip-labs.com, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 02/20] KEYS: Add a system blacklist keyring [ver #2] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32305.1454943347.1@warthog.procyon.org.uk> Date: Mon, 08 Feb 2016 14:55:47 +0000 Message-ID: <32306.1454943347@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Mimi Zohar wrote: > By separating out the blacklist keyring from the issue of trust, you'll have > smaller patch sets that can more easily be reviewed. (Reviewing anything > having to do with certificates is difficult enough.) It would also allow > you to upstream the two patch sets independently of each other. Unfortunately, there's a dependency between the subsets you're talking about in the form of the restriction function passed to keyring_alloc() - an argument that's only made available in the other subset, so they cannot be completely independent. That said, the trust changes don't require the blacklist changes. David