All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: Antonio Quartulli <antonio@meshcoding.com>
Cc: The list for a Better Approach To Mobile Ad-hoc Networking
	<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH 0/3] batctl: Use libnl(-tiny) for netlink communication
Date: Fri, 17 Jan 2014 10:37:38 +0100	[thread overview]
Message-ID: <32326825.BW0GZpyDjI@bentobox> (raw)
In-Reply-To: <52D84B0A.10208@meshcoding.com>

[-- Attachment #1: Type: text/plain, Size: 1012 bytes --]

On Thursday 16 January 2014 22:11:38 Antonio Quartulli wrote:
> I think that it may still be the case that we want to compile batctl on
> an host without libnl.

We == "I have this use case"?

> In the end batman-adv can run on Ethernet and we may have an embedded
> system with no wifi which has no libnl at all.

(Now a little bit sarcasm): batctl can also run without batman-adv, please 
allow to drop the useless sysfs/debugfs stuff ;)

> I was wondering....what if we check if libnl is installed or not and in
> case it is missing we disable the address translation and vlan operations?
> In this way we can add the dependency to libnl and avoid code
> duplication but at the same time we keep libnl-free users happy.

I agree that it is possible but would like to avoid to provide a "fallback" 
because it justs adds more complexity without an actual use case (please 
correct me but I don't see it right now).

If you still think it is necessary then please feel free to add it later.

Kind regards,
	Sven

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-01-17  9:37 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-06 19:35 [B.A.T.M.A.N.] [PATCH 0/3] batctl: Use libnl(-tiny) for netlink communication Sven Eckelmann
2014-01-06 19:37 ` [B.A.T.M.A.N.] [PATCH 1/3] batctl: Avoid name clash "rtnl_open" with libnl Sven Eckelmann
2014-01-06 19:37   ` [B.A.T.M.A.N.] [PATCH 2/3] batctl: Use libnl to implement mac resolver Sven Eckelmann
2014-01-23  8:21     ` Marek Lindner
2014-01-06 19:37   ` [B.A.T.M.A.N.] [PATCH 3/3] batctl: Use libnl to implement vlan parent device resolver Sven Eckelmann
2014-01-27  6:22     ` Marek Lindner
2014-01-23  7:28   ` [B.A.T.M.A.N.] [PATCH 1/3] batctl: Avoid name clash "rtnl_open" with libnl Marek Lindner
2014-01-16 21:11 ` [B.A.T.M.A.N.] [PATCH 0/3] batctl: Use libnl(-tiny) for netlink communication Antonio Quartulli
2014-01-17  9:37   ` Sven Eckelmann [this message]
2014-01-19 10:20     ` Antonio Quartulli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32326825.BW0GZpyDjI@bentobox \
    --to=sven@narfation.org \
    --cc=antonio@meshcoding.com \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.