From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH] mbuf: clarify comment on adding TX offload flags
Date: Thu, 09 Jul 2015 15:59:35 +0200 [thread overview]
Message-ID: <3236231.fXvrao6sCh@xps13> (raw)
In-Reply-To: <1436448159-8394-1-git-send-email-bruce.richardson@intel.com>
2015-07-09 14:22, Bruce Richardson:
> The comment for TX offload flags stated that those flags started at bit
> 55 and then were added to the right of that, leaving 8 bits reserved for
> generic mbuf (i.e. non-offload) use. This comment may not have been
> clear as 5 of the 8 flags which were reserved have now been used for TX
> offloads.
We failed to properly review some patches which are now integrated in
version 1.8. So you cannot fix it without breaking API.
It's a bit sad but your patch fixing the comment is reasonnable.
Fixes: 711ba9e23e68 ("mbuf: remove aliasing of Tx offloading flags with Rx ones")
Fixes: 1c3b7c33e977 ("mbuf: add Tx offloading flags for tunnels")
next prev parent reply other threads:[~2015-07-09 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 13:22 [PATCH] mbuf: clarify comment on adding TX offload flags Bruce Richardson
2015-07-09 13:46 ` Eduard Gibert
2015-07-09 13:59 ` Thomas Monjalon [this message]
2015-07-15 10:16 ` Olivier MATZ
2015-07-16 12:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3236231.fXvrao6sCh@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.