From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CECFBC77B61 for ; Tue, 25 Apr 2023 05:38:59 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 5062486172; Tue, 25 Apr 2023 07:38:57 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; secure) header.d=gmx.de header.i=xypron.glpk@gmx.de header.b="HQjrRwY2"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 7C34B8617C; Tue, 25 Apr 2023 07:38:55 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7001686157 for ; Tue, 25 Apr 2023 07:38:52 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=xypron.glpk@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.de; s=s31663417; t=1682401109; i=xypron.glpk@gmx.de; bh=YN5ZCsv83cAsW42ZImptrdMlispVpyMTgOg0XW4GmU0=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=HQjrRwY26N/DjQlcP7/BpFdd5dTuEYodMPrf50DQJ1QHP6VN2F7tFKWc/8KlxBzSu f/lTl4iIQIhv6dgYax5/8ij4BhdBBpV/QLsg83QhDpeEIrr0AEOeGHYwi+G85OhMYI F3kALxgxa+cjoBCFsW6fI1IBbfz9Y1iiPw6NwdYGgwbP4ezJ9MVyzgRezSuv69RQVm E4Bt0On531TNzEPJ2kUxegrkrNwYDiDHbhNkFk3zSshXWw+YZP+ETpK0Pd+DHj8hzo 4X+dooPs25NNAARnh72sTKWjoyqsCsUovNMs62WPYe0tzbrZhgenpkMrkxuzFmZFhG kAKGIRn+fknSQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.46.60] ([62.168.35.125]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1McH9Y-1qRcfB1Nwi-00cdOZ; Tue, 25 Apr 2023 07:38:29 +0200 Message-ID: <323f74e2-4c31-130f-df9c-6d5517c6f34e@gmx.de> Date: Tue, 25 Apr 2023 07:38:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 19/19] doc: board: ti: Update documentation for binman flow Content-Language: en-US To: Simon Glass Cc: Neha Malcom Francis , u-boot@lists.denx.de, afd@ti.com, vigneshr@ti.com, rogerq@kernel.org, alpernebiyasak@gmail.com, nm@ti.com, bb@ti.com, u-kumar1@ti.com, Tom Rini References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-20-n-francis@ti.com> <20230424204915.GM1134230@bill-the-cat> From: Heinrich Schuchardt In-Reply-To: <20230424204915.GM1134230@bill-the-cat> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:D+p+Z7qBnG49652FlBLGM4TMEOjluiNeiQMoAFu2ajKxBquHWHW Jma/jmhMu5jZqlvaZm1ETamiZ5xX5Rfp7QnkiUrxpY7KfVq359D8rrOUuFbB9Kq0Iy0mmEI 6iVUhK0+IkjQPjnQ7SQkJ7ZHPezZrxBE49sl8WLB4MCWdI+87xIx/3adY1VhuI+Ej2MCza2 3tcFPpb3BwL/G9TPhWVMg== UI-OutboundReport: notjunk:1;M01:P0:kkJmzgjTQsg=;IL5jm3bP1jXvlQSZCmbJFSKo0rN bS/gGOQNOK6CDb0WHNxtbQ85wIH/888uv0MIsLEC+UwVeb3HP1CqI6g6LqrYIaV9Wk312F5mb x2TUBWTN0zhF5Cjf5MR2wJzk62xI1EJl8PQhWiO6oP2QL64NeNLcUc7KdIYGpGKgLRwVqHIe/ khaIFvKQKLNTreBMiLGPi+lTEGyxOSR9z2QrJI25jyHYKBpTEoX9GgUx2ou9lNyXQmzRTqUdu j6IZ/qhpVyNKMgcplfI8+Pyt9qTT+9vBgEhZ3fgt99uCWCIpLeXvXha6SlJqBi+tSZrIol3Mr h1jV6pUuusxF0tGWC30E8YuswPDZKstzQsA71jBxlvTg8CxvNqs+Z+6KKyjwRXMgrTmqsRU+4 etYbvGbfAnrwE/lJO6tDvcz3zW/PvU5EQulyaMnhiL0jSblVPlZv87QWqVl552JcSue3TP9We 10bExh0X1V+4TowEAyakWDZDDnixW3NJ4WPdp4GwXz4hZKze+4xnF2FSbYZ8LgPTT3tBNfkTN fFqaZoPlODcX0T3XrSzD8bApFxH4NEnLkdDHMeO/uk343km+YNXS5kJNPVjY3+3/TMU7wiwTE gXvnT9iGwfLmpTkCqaC/6ZREtJ7BD9Iso54a/CLBjt8qdkwnNUUdKHwkUCU49GLiUaNL+n7X8 Te1vQ/Faef/X+PK+34MrPeXBM8T5W83hKLQY8pAiQYYrTwF3/xP+/EhEwIdOeJamdh+yWYIKv PfcP4rrZY7zPXsj/cCMOR7fbgYaZCTH9g77kCYyTZp1KAcMn+JZNFkmLggT/9A4hv/aCqkULf 5XUpAjQnycVcb4k/zm1Santk6dvDwjbqg55WU9xDJ/Logl8RI+ymGCseO5NsXfZ2eHxQaDJ4m IZIN8iM/urGQq1lGkwToO2+o/6AWC7ttshR3YH3e+DH7PTI7NRY4Aq6xzBrnVt3ybjZUWRmDL TDOkSMvKOv3vONH34cyXt0hpUAs= X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On 4/24/23 22:49, Tom Rini wrote: > On Mon, Apr 24, 2023 at 01:42:17PM -0600, Simon Glass wrote: >> Hi Neha, >> >> On Fri, 21 Apr 2023 at 06:33, Neha Malcom Francis wr= ote: >>> >>> Earlier documentation specified builds for generating bootloader image= s >>> using an external TI repository k3-image-gen and core-secdev-k3. Modif= y >>> this to using the binman flow so that user understands how to build th= e >>> final boot images. >>> >>> Signed-off-by: Neha Malcom Francis >>> --- >>> doc/board/ti/am62x_sk.rst | 20 ++++-------- >>> doc/board/ti/j721e_evm.rst | 37 ++++++++------------- >>> doc/board/ti/k3.rst | 67 ++++++++++--------------------------= -- >>> 3 files changed, 36 insertions(+), 88 deletions(-) >> >> Reviewed-by: Simon Glass >> >>> >>> diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti/am62x_sk.rst >>> index b1b7d99bef..f5e0774899 100644 >>> --- a/doc/board/ti/am62x_sk.rst >>> +++ b/doc/board/ti/am62x_sk.rst >>> @@ -115,23 +115,19 @@ Below is the pictorial representation of boot fl= ow: >>> >>> Sources: >>> -------- >>> -1. SYSFW: >>> - Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git >>> - Branch: master >>> - >>> -2. ATF: >>> +1. ATF: >>> Tree: https://github.com/ARM-software/arm-trusted-firmware.gi= t >>> Branch: master >>> >>> -3. OPTEE: >>> +2. OPTEE: >>> Tree: https://github.com/OP-TEE/optee_os.git >>> Branch: master >>> >>> -4. U-Boot: >>> +3. U-Boot: >>> Tree: https://source.denx.de/u-boot/u-boot >>> Branch: master >>> >>> -5. TI Linux Firmware: >>> +4. TI Linux Firmware: >>> Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.g= it >>> Branch: ti-linux-firmware >>> >>> @@ -156,18 +152,14 @@ Build procedure: >>> .. code-block:: text >>> >>> $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- am62x_e= vm_r5_defconfig O=3D/tmp/r5 >>> - $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- O=3D/tmp= /r5 >>> - $ cd >>> - $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- SOC=3Dam= 62x SBL=3D/tmp/r5/spl/u-boot-spl.bin SYSFW_PATH=3D/ti-sysfw/ti-fs-firmware-am62x-gp.bin >>> - >>> -Use the tiboot3.bin generated from last command >>> + $ make ARCH=3Darm CROSS_COMPILE=3Darm-none-linux-gnueabihf- O=3D/tmp= /r5 BINMAN_INDIRS=3D >>> >>> * 3.2 A53: >>> >>> .. code-block:: text >>> >>> $ make ARCH=3Darm CROSS_COMPILE=3Daarch64-none-linux-gnu- am62x_evm= _a53_defconfig O=3D/tmp/a53 >>> - $ make ARCH=3Darm CROSS_COMPILE=3Daarch64-none-linux-gnu- ATF=3D/build/k3/lite/release/bl31.bin TEE=3D/= out/arm-plat-k3/core/tee-pager_v2.bin DM=3D/ti-= dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f O=3D/tmp/a53 >>> + $ make ARCH=3Darm CROSS_COMPILE=3Daarch64-none-linux-gnu- BL31=3D/build/k3/lite/release/bl31.bin TEE=3D= /out/arm-plat-k3/core/tee-pager_v2.bin BINMAN_INDIRS=3D >>> >>> Target Images >>> -------------- >>> diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti/j721e_evm.rst >>> index e898601c41..c90e2b8279 100644 >>> --- a/doc/board/ti/j721e_evm.rst >>> +++ b/doc/board/ti/j721e_evm.rst >>> @@ -130,67 +130,56 @@ support. Below is the pictorial representation o= f boot flow: >>> >>> Sources: >>> -------- >>> -1. SYSFW: >>> - Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git >>> - Branch: master >>> - >>> -2. ATF: >>> +1. ATF: >>> Tree: https://github.com/ARM-software/arm-trusted-firmware.gi= t >>> Branch: master >>> >>> -3. OPTEE: >>> +2. OPTEE: >>> Tree: https://github.com/OP-TEE/optee_os.git >>> Branch: master >>> >>> -4. DM Firmware: >>> - Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.gi= t >>> - Branch: ti-linux-firmware >>> - >>> -5. U-Boot: >>> +3. U-Boot: >>> Tree: https://source.denx.de/u-boot/u-boot >>> Branch: master >>> >>> +4. TI Linux Firmware: >>> + Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.gi= t >>> + Branch: ti-linux-firmware >>> + >>> Build procedure: >>> ---------------- >>> -1. SYSFW: >>> - >>> -.. code-block:: bash >>> - >>> - make CROSS_COMPILE=3Darm-linux-gnueabihf- SOC=3Dj721e >>> - >>> -2. ATF: >>> +1. ATF: >>> >>> .. code-block:: bash >>> >>> make CROSS_COMPILE=3Daarch64-linux-gnu- ARCH=3Daarch64 PLAT=3Dk3= TARGET_BOARD=3Dgeneric SPD=3Dopteed >>> >>> -3. OPTEE: >>> +2. OPTEE: >>> >>> .. code-block:: bash >>> >>> make PLATFORM=3Dk3-j721e CFG_ARM64_core=3Dy >>> >>> -4. U-Boot: >>> +3. U-Boot: >>> >>> * 4.1 R5: >>> >>> .. code-block:: bash >>> >>> make CROSS_COMPILE=3Darm-linux-gnueabihf- j721e_evm_r5_defconfig= O=3Dbuild/r5 CROSS_COMPILE is superfluous here. >>> - make CROSS_COMPILE=3Darm-linux-gnueabihf- O=3Dbuild/r5 >>> + make CROSS_COMPILE=3Darm-linux-gnueabihf- O=3Dbuild/r5 BINMAN_IND= IRS=3D Don't we have to indicate the locations of the TF-A binary and SYSFW_PATH? >>> >>> * 4.2 A72: >>> >>> .. code-block:: bash >>> >>> make CROSS_COMPILE=3Daarch64-linux-gnu- j721e_evm_a72_defconfig = O=3Dbuild/a72 CROSS_COMPILE is superfluous here. >>> - make CROSS_COMPILE=3Daarch64-linux-gnu- ATF=3D/build/k3/= generic/release/bl31.bin TEE=3D/out/arm-plat-k3/core/tee-pag= er_v2.bin DM=3D/ti-dm/j721e/ipc_echo_testb_mcu1_0_release_str= ip.xer5f O=3Dbuild/a72 >>> + make CROSS_COMPILE=3Daarch64-linux-gnu- BL31=3D/build/k3= /generic/release/bl31.bin TEE=3D/out/arm-plat-k3/core/tee-pa= ger_v2.bin BINMAN_INDIRS=3D Where do we indicate SYSFW_PATH? >> >> Is there an 'O=3Dbuild/a72' missing there? > > Not strictly missing, no. One of those style things for Heinrich is, we > should be consistent in our examples both in terms of O=3D (when not > strictly required, it is for the _r5 variant since you must keep some of > that build for the Cortex-A part, so that you can get something that > boots the physical machine, in the end). > >> You can combine these as well, by using 'j721e_evm_a72_defconfig all' >> to both configure and build. >> >> Also it might be nice to keep the line length shorter if you can. > > Other parts for Heinrich to chime in, to have consistent on all the > board examples. > O=3D is not really needed outside of 'make tests'. So I think dropping it from examples is fine if the document in itself stays consistent. We should try to stick to 80 characters per line in documentation for the sake of readers who read the source (as described in https://u-boot.readthedocs.io/en/latest/develop/docstyle.html). Even in HTML pages it is not nice if you have to scroll horizontally to read the complete command. Please, use \ to split the bash command over multiple lines. Best regards Heinrich