All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Henry Nadeau <hnadeau@iol.unh.edu>
Cc: dev@dpdk.org
Subject: Re: [PATCH v4] devtools: spell check
Date: Thu, 20 Jan 2022 16:10:31 +0100	[thread overview]
Message-ID: <3242036.RL5eaSpR8r@thomas> (raw)
In-Reply-To: <20211201165954.16153-1-hnadeau@iol.unh.edu>

01/12/2021 17:59, Henry Nadeau:
>  A spell check script to check for errors in patches. An
>  example of usage being cat PATCH_FILE | spell_check.sh.

Does it mean all words are checked? Code and comments?
I think there is no need to check the code.

Note we are already using another tool, codespell inside checkpatch,
based on a dictionary built with this script:	devtools/build-dict.sh

Do you know how aspell compares with codespell?

>  Errors will be
>  printed to console, following the file they are located in. Word exclusions
>  can be made by making additions to the dictionary, and problematic patterns
>  can be added to the regex filter.
> 
> Signed-off-by: Henry Nadeau <hnadeau@iol.unh.edu>
> ---
>  devtools/spell_check.sh             |  121 ++
>  devtools/spell_check_dictionary.txt | 2160 +++++++++++++++++++++++++++
>  devtools/spell_check_regex.txt      |    2 +
>  3 files changed, 2283 insertions(+)

I think it is too much effort to maintain the dictionary and exclusions.
I understand it avoids false positive, but I don't imagine contributors
updating the dictionary as part of their patch.



      reply	other threads:[~2022-01-20 15:10 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-12 18:14 [PATCH v2] devtools: spell check Henry Nadeau
2021-11-12 19:23 ` Stephen Hemminger
2021-12-01 14:47 ` [PATCH v3] " Henry Nadeau
2021-12-01 16:59 ` [PATCH v4] " Henry Nadeau
2022-01-20 15:10   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3242036.RL5eaSpR8r@thomas \
    --to=thomas@monjalon.net \
    --cc=dev@dpdk.org \
    --cc=hnadeau@iol.unh.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.