From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Date: Thu, 12 Oct 2017 16:17:07 +0000 Subject: Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size Message-Id: <3245965.OqUEzHD6FT@amdc3058> List-Id: References: <20170919213201.31845-1-colin.king@canonical.com> In-Reply-To: <20170919213201.31845-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org [ added dri-devel ML to cc: ] On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote: > From: Colin Ian King > > Don't populate the read-only const array post_divs on the stack, > nstead make it static. Makes the object code smaller by 90 bytes: > > Before: > text data bss dec hex filename > 40231 8584 896 49711 c22f radeon_base.o > > After: > text data bss dec hex filename > 39914 8744 960 49618 c1d2 radeon_base.o > > Signed-off-by: Colin Ian King Are these results obtained using the same compiler as the other patches (gcc version 7.2.0, x86_64)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bartlomiej Zolnierkiewicz Subject: Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size Date: Thu, 12 Oct 2017 18:17:07 +0200 Message-ID: <3245965.OqUEzHD6FT@amdc3058> References: <20170919213201.31845-1-colin.king@canonical.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8C7976E88E for ; Thu, 12 Oct 2017 16:17:13 +0000 (UTC) In-reply-to: <20170919213201.31845-1-colin.king@canonical.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Colin King Cc: linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org ClsgYWRkZWQgZHJpLWRldmVsIE1MIHRvIGNjOiBdCgpPbiBUdWVzZGF5LCBTZXB0ZW1iZXIgMTks IDIwMTcgMTA6MzI6MDEgUE0gQ29saW4gS2luZyB3cm90ZToKPiBGcm9tOiBDb2xpbiBJYW4gS2lu ZyA8Y29saW4ua2luZ0BjYW5vbmljYWwuY29tPgo+IAo+IERvbid0IHBvcHVsYXRlIHRoZSByZWFk LW9ubHkgY29uc3QgYXJyYXkgcG9zdF9kaXZzIG9uIHRoZSBzdGFjaywKPiBuc3RlYWQgbWFrZSBp dCBzdGF0aWMuIE1ha2VzIHRoZSBvYmplY3QgY29kZSBzbWFsbGVyIGJ5IDkwIGJ5dGVzOgo+IAo+ IEJlZm9yZToKPiAgICB0ZXh0CSAgIGRhdGEJICAgIGJzcwkgICAgZGVjCSAgICBoZXgJZmlsZW5h bWUKPiAgIDQwMjMxCSAgIDg1ODQJICAgIDg5NgkgIDQ5NzExCSAgIGMyMmYJcmFkZW9uX2Jhc2Uu bwo+IAo+IEFmdGVyOgo+ICAgIHRleHQJICAgZGF0YQkgICAgYnNzCSAgICBkZWMJICAgIGhleAlm aWxlbmFtZQo+ICAgMzk5MTQJICAgODc0NAkgICAgOTYwCSAgNDk2MTgJICAgYzFkMglyYWRlb25f YmFzZS5vCj4gCj4gU2lnbmVkLW9mZi1ieTogQ29saW4gSWFuIEtpbmcgPGNvbGluLmtpbmdAY2Fu b25pY2FsLmNvbT4KCkFyZSB0aGVzZSByZXN1bHRzIG9idGFpbmVkIHVzaW5nIHRoZSBzYW1lIGNv bXBpbGVyIGFzIHRoZSBvdGhlciBwYXRjaGVzCihnY2MgdmVyc2lvbiA3LjIuMCwgeDg2XzY0KT8K CkJlc3QgcmVnYXJkcywKLS0KQmFydGxvbWllaiBab2xuaWVya2lld2ljegpTYW1zdW5nIFImRCBJ bnN0aXR1dGUgUG9sYW5kClNhbXN1bmcgRWxlY3Ryb25pY3MKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754788AbdJLQRS (ORCPT ); Thu, 12 Oct 2017 12:17:18 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:20966 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752849AbdJLQRN (ORCPT ); Thu, 12 Oct 2017 12:17:13 -0400 X-AuditID: b6c32a36-c21ff70000018158-aa-59df958666d1 From: Bartlomiej Zolnierkiewicz To: Colin King Cc: Benjamin Herrenschmidt , linux-fbdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH] video: fbdev: radeon: make const array post_divs static, reduces object code size Date: Thu, 12 Oct 2017 18:17:07 +0200 Message-id: <3245965.OqUEzHD6FT@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170919213201.31845-1-colin.king@canonical.com> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset="us-ascii" X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsWy7bCmnm7b1PuRBrtPKlp8aGpltvi9upfN 4srX92wWW29JW5zo+8BqcXnXHDYHNo9ZDb1sHj1vWlg97ncfZ/L4vEkugCWKyyYlNSezLLVI 3y6BK2PH0v+MBUvYKj48/8vcwHiWpYuRg0NCwESib6NtFyMXh5DADkaJnfO6WSCc74wSe85e ZIQp2vlVEiK+gVHix9GVzBDOV0aJSd2LmLoYOTnYBKwkJravAmsQEdCUOH+uCKSGWWAbo8Tz HV3sIHFhgQyJgysUQMpZBFQlFp94yQpi8wKV3/n1jg3EFhXwktiyrx1sJKeAncTKu1vYIGoE JX5MvscCYjMLyEvs2z+VFcLWkTh7bB0jyC4JgQ1sEu9nPWAESUgIuEhMvPWbHcIWlnh1fAs7 xDPSEpeO2kKEpzNKbP8tAdG7mVFi1e4JUPXWEoePX4RawCfx7msPK0Qvr0RHmxBEiYfElxPP mSBsR4lPK3ZDA24io8SVgyfYJjDKzkJy9ywkd89CcvcCRuZVjGKpBcW56anFhgVGesWJucWl eel6yfm5mxjBqUDLbAfjonM+hxgFOBiVeHgFqu5HCrEmlhVX5h5ilOBgVhLh9egECvGmJFZW pRblxxeV5qQWH2KU5mBREucVXX8tQkggPbEkNTs1tSC1CCbLxMEp1cBYn91ZJl6RJ5inqiOy RT9Ay0ptp1rBOZljx/+fYf8opWi9LUrUUG9ensrb9QULu7Sqwjfv8L1xXNeyX+o9/8TLE+zs +6b1VXq/++G2KM9DZz6jkTNnffLH9HJjzxMrWs7Ebzw6s9svUOFora6E+rTf3/vkXA+c6/Kz Vpk149L1rLxFb/6ca1diKc5INNRiLipOBACD6m/JAQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsVy+t9jQd22qfcjDa408lp8aGpltvi9upfN 4srX92wWW29JW5zo+8BqcXnXHDYHNo9ZDb1sHj1vWlg97ncfZ/L4vEkugCWKyyYlNSezLLVI 3y6BK2PH0v+MBUvYKj48/8vcwHiWpYuRg0NCwERi51fJLkYuDiGBdYwSZyddY4ZwvjJKzNnT wdrFyMnBJmAlMbF9FSNIg4iApsT5c0UgNcwC2xglPry6xgZSIyyQIfFn8ylGEJtFQFVi8YmX YL28QPV3fr0DqxEV8JLYsq+dCcTmFLCTWHl3CxvEssmMEtdmr4dqEJT4MfkeC4jNLCAvsW// VFYIW0ti/c7jTBMY+WchKZuFpGwWkrIFjMyrGCVTC4pz03OLjQoM81LL9YoTc4tL89L1kvNz NzECA3jbYa2+HYz3l8QfYhTgYFTi4RWouh8pxJpYVlyZe4hRgoNZSYTXoxMoxJuSWFmVWpQf X1Sak1p8iFGag0VJnPd23rFIIYH0xJLU7NTUgtQimCwTB6dUA6OYv9HEGef407dlLHa7cjfY Zt78M5mf/imn6tnv/lU8XUpN/9fupZ2bipnNFn4T5Nj45oKDc8XnyKRv5p/kInVkyp6fbr24 +MJS5V8vCh02Wv/6orCKp4C3YZ8b++ftSvkZy6KOfJ71YG5Y/Oceq2atuTomB8JZWO2Zkwuu bUyb3cT88meJ1g8lluKMREMt5qLiRADtcUXiXAIAAA== X-CMS-MailID: 20171012161710epcas1p4c15eed8409b0c4a56ec73c4e47239f1e X-Msg-Generator: CA X-Sender-IP: 182.195.42.142 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 101P X-CMS-RootMailID: 20170919213206epcas2p3a2bea87468fa266cf1c94829444ab162 X-RootMTR: 20170919213206epcas2p3a2bea87468fa266cf1c94829444ab162 References: <20170919213201.31845-1-colin.king@canonical.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ added dri-devel ML to cc: ] On Tuesday, September 19, 2017 10:32:01 PM Colin King wrote: > From: Colin Ian King > > Don't populate the read-only const array post_divs on the stack, > nstead make it static. Makes the object code smaller by 90 bytes: > > Before: > text data bss dec hex filename > 40231 8584 896 49711 c22f radeon_base.o > > After: > text data bss dec hex filename > 39914 8744 960 49618 c1d2 radeon_base.o > > Signed-off-by: Colin Ian King Are these results obtained using the same compiler as the other patches (gcc version 7.2.0, x86_64)? Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics