From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] igb_uio: support devices with at least 1 bar defined Date: Wed, 15 Mar 2017 14:01:27 +0100 Message-ID: <3246014.IauPTycO94@xps13> References: <1489509189-166941-1-git-send-email-allain.legacy@windriver.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit To: Allain Legacy Return-path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 732B9214A for ; Wed, 15 Mar 2017 14:01:29 +0100 (CET) Received: by mail-wm0-f47.google.com with SMTP id n11so22376358wma.0 for ; Wed, 15 Mar 2017 06:01:29 -0700 (PDT) In-Reply-To: List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 2017-03-14 16:59, Ferruh Yigit: > On 3/14/2017 4:33 PM, Allain Legacy wrote: > > From: Matt Peters > > > > Allow the BAR setup to succeed if a device has at least 1 BAR region > > defined. Previously, the device probe would only succeed if at least one > > memory BAR existed, but there are devices that have only port I/O BARs. > > > > For example, on Virtual Box a virtio device has only a single I/O BAR > > because by default MSI-X is not enabled. While in qemu/kvm the virtio > > device has MSI-X enabled and therefore has both an I/O and Memory BAR. > > > > The following are excerpts from "lspci -nnvvvv -s 00:09.0" on both types of > > systems. > > > > Virtual Box: > > > > Region 0: I/O ports at d260 [size=32] > > Capabilities: [80] #00 [0000] > > > > QEMU/KVM: > > > > Region 0: I/O ports at c060 [size=32] > > Region 1: Memory at febd1000 (32-bit, non-prefetchable) [size=4K] > > Expansion ROM at feb80000 [disabled] [size=256K] > > Capabilities: [40] MSI-X: Enable+ Count=3 Masked- > > Vector table: BAR=1 offset=00000000 > > PBA: BAR=1 offset=00000800 > > > > Signed-off-by: Matt Peters > > Signed-off-by: Allain Legacy > > Acked-by: Ferruh Yigit Applied, thanks