All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabio Estevam <fabioestevam@yahoo.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM: MX31: print WRSR to indicate the source of the last reset
Date: Thu, 10 Mar 2011 05:47:15 -0800 (PST)	[thread overview]
Message-ID: <324735.19801.qm@web39408.mail.mud.yahoo.com> (raw)
In-Reply-To: <1299754388-31648-1-git-send-email-agust@denx.de>

Hi Anatolij,

--- On Thu, 3/10/11, Anatolij Gustschin <agust@denx.de> wrote:
....?? ???
> mx31_get_mcu_main_clk() / 1000000);
> +??? struct wdog_regs *wdog = (struct> wdog_regs *)WDOG_BASE;
> +
> +??? printf("CPU:???Freescale i.MX31 at %d MHz (WRSR=0x%04x)\n",
> +??
> mx31_get_mcu_main_clk() / 1000000, wdog->wrsr);
>  ??? return 0;

Wouldn?t it be better to show a string for the reset source, rather than a pure register value?

I sent a similar patch yesterday for MX31PDK: http://permalink.gmane.org/gmane.comp.boot-loaders.u-boot/95615

,but I agree that moving it to the generic code is a better idea.

Regards,

Fabio Estevam



      

  reply	other threads:[~2011-03-10 13:47 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-10 10:53 [U-Boot] [PATCH 1/2] ARM: MX31: print WRSR to indicate the source of the last reset Anatolij Gustschin
2011-03-10 13:47 ` Fabio Estevam [this message]
2011-03-12 13:22   ` Anatolij Gustschin
2011-03-10 15:07 ` Stefano Babic
2011-03-12 13:15   ` Anatolij Gustschin
2011-03-14 11:55     ` Stefano Babic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=324735.19801.qm@web39408.mail.mud.yahoo.com \
    --to=fabioestevam@yahoo.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.