All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: linux-kernel@vger.kernel.org
Subject: Re: Announce: modutils 2.3.23 is available
Date: Wed, 20 Dec 2000 11:43:13 +1100	[thread overview]
Message-ID: <3249.977272993@kao2.melbourne.sgi.com> (raw)
In-Reply-To: Your message of "Sun, 17 Dec 2000 10:45:41 +1100." <31418.977010341@ocs3.ocs-net>

modutils 2.3.23 has a bug with empty MODULE_GENERIC_STRING entries,
depmod loops.

Index: 23.11/depmod/depmod.c
--- 23.11/depmod/depmod.c Sun, 17 Dec 2000 10:18:04 +1100 kaos (modutils-2.3/b/43_depmod.c 1.39 644)
+++ 23.11(w)/depmod/depmod.c Wed, 20 Dec 2000 08:13:18 +1100 kaos (modutils-2.3/b/43_depmod.c 1.39 644)
@@ -388,9 +388,8 @@ static void extract_generic_string(struc
 			error("unterminated generic string '%*s'", p - s, s);
 			break;
 		}
-		if (p == s)		/* empty string? */
+		if (p++ == s)		/* empty string? */
 			continue;
-		p++;	/* step over NUL */
 		mod->generic_string = xrealloc(mod->generic_string, ++(mod->n_generic_string)*sizeof(*(mod->generic_string)));
 		latest = mod->generic_string + mod->n_generic_string-1;
 		*latest = xstrdup(s);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
Please read the FAQ at http://www.tux.org/lkml/

  reply	other threads:[~2000-12-20  1:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-12-16 23:45 Announce: modutils 2.3.23 is available Keith Owens
2000-12-20  0:43 ` Keith Owens [this message]
2000-12-20  9:31   ` Christian Gennerat
2000-12-20  9:44     ` Nicholas Miell
2000-12-20 21:13     ` Keith Owens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3249.977272993@kao2.melbourne.sgi.com \
    --to=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.