From: "Paul Moore" <paul.moore@hp.com>
To: <akpm@osdl.org>
Cc: <adam@yggdrasil.com>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>
Subject: Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]
Date: 26 Dec 2006 00:30:00 -0500 [thread overview]
Message-ID: <3249937847.23410275@mail.hp.com> (raw)
-----Original Message-----
From: Andrew Morton <akpm@osdl.org>
Date: Sunday, Dec 24, 2006 7:25 pm
Subject: Re: selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12]
On Mon, 25 Dec 2006 05:21:24 +0800
>"Adam J. Richter" <adam@yggdrasil.com> wrote:
>
>> Under 2.6.20-rc1 and 2.6.20-rc2, I get the following complaint
> for several network programs running on my system:
>
> [ 156.381868] BUG: sleeping function called from invalid context at net/core/sock.c:1523
> [ 156.381876] in_atomic():1, irqs_disabled():0
> [ 156.381881] no locks held by kio_http/9693.
> [ 156.381886] [<c01057a2>] show_trace_log_lvl+0x1a/0x2f
> [ 156.381900] [<c0105dab>] show_trace+0x12/0x14
> [ 156.381908] [<c0105e48>] dump_stack+0x16/0x18
> [ 156.381917] [<c011e30f>] __might_sleep+0xe5/0xeb
> [ 156.381926] [<c025942a>] lock_sock_nested+0x1d/0xc4
> [ 156.381937] [<c01cc570>] selinux_netlbl_inode_permission+0x5a/0x8e
> [ 156.381946] [<c01c2505>] selinux_file_permission+0x96/0x9b
> [ 156.381954] [<c0175a0a>] vfs_write+0x8d/0x167
> [ 156.381962] [<c017605a>] sys_write+0x3f/0x63
> [ 156.381971] [<c01040c0>] syscall_call+0x7/0xb
> [ 156.381980] =======================
>
>
>There's a glaring bug in selinux_netlbl_inode_permission() - taking lock_sock() inside rcu_read_lock().
>
>I would again draw attention to Documentation/SubmitChecklist. In
>particular please always always always enable all kernel debugging options when developing and testing new kernel code. And everything else in that file, too.
>
I apologize for the mistake - I'm still trying to get a firm grasp on some of the finer points of Linux kernel development and I obviously missed something here. Unfortunately, due to the holiday I won't be able to write/test/submit a patch until after the first of the year but I promise to do so as soon as I am able.
. paul moore
. linux security @ hp
next reply other threads:[~2006-12-26 5:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-26 5:30 Paul Moore [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-01-04 11:32 selinux networking: sleeping functin called from invalid context in 2.6.20-rc[12] Adam J. Richter
2006-12-24 21:21 Adam J. Richter
2006-12-25 0:15 ` Parag Warudkar
2006-12-25 0:25 ` Andrew Morton
2007-01-02 7:58 ` Adam J. Richter
2007-01-02 21:25 ` Paul Moore
2007-01-02 23:37 ` David Miller
2007-01-03 20:46 ` Paul Moore
2007-01-02 21:14 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3249937847.23410275@mail.hp.com \
--to=paul.moore@hp.com \
--cc=adam@yggdrasil.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.