From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Helin Zhang <helin.zhang@intel.com>
Cc: dev@dpdk.org
Subject: Re: [PATCH v3 0/2] fix compile with ICC and clang
Date: Tue, 19 May 2015 12:32:50 +0200 [thread overview]
Message-ID: <3255170.m2Jvvj9c1g@xps13> (raw)
In-Reply-To: <20150518154325.GA8740@bricha3-MOBL3>
2015-05-18 16:43, Bruce Richardson:
> On Mon, May 18, 2015 at 11:40:54PM +0800, Helin Zhang wrote:
> > Compile warnings on ICC and clang can be found, and treated as errors.
> > Disabling those warnings forcedly can fix them.
> >
> > v2 changes:
> > Added the fix for the compile error on clang.
> >
> > v3 changes:
> > Reworded the commit titles.
>
> Series Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
I reworded the commit message and added reference to the breaking commit:
http://dpdk.org/browse/dpdk/commit/?id=ff5c3960017cf
Please consider giving this kind of explanation when fixing things,
especially for special handling of base drivers.
next prev parent reply other threads:[~2015-05-19 10:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 13:52 [PATCH] i40e: compile fix on ICC 13.0.0 Helin Zhang
2015-05-18 15:03 ` [PATCH v2 0/2] compile fixes on ICC and clang Helin Zhang
2015-05-18 15:03 ` [PATCH v2 1/2] i40e/base: compile fix on ICC 13.0.0 Helin Zhang
2015-05-18 15:11 ` Bruce Richardson
2015-05-18 15:13 ` Bruce Richardson
2015-05-18 15:03 ` [PATCH v2 2/2] i40e/base: compile fix on clang 3.3 Helin Zhang
2015-05-18 15:11 ` Bruce Richardson
2015-05-18 15:40 ` [PATCH v3 0/2] fix compile with ICC and clang Helin Zhang
2015-05-18 15:40 ` [PATCH v3 1/2] i40e/base: fix compile with ICC 13.0.0 Helin Zhang
2015-05-18 15:40 ` [PATCH v3 2/2] i40e/base: fix compile with clang 3.3 Helin Zhang
2015-05-18 15:43 ` [PATCH v3 0/2] fix compile with ICC and clang Bruce Richardson
2015-05-19 10:32 ` Thomas Monjalon [this message]
2015-05-19 14:12 ` Zhang, Helin
2015-05-19 1:25 ` [PATCH v2 0/2] compile fixes on " Tetsuya Mukawa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3255170.m2Jvvj9c1g@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=dev@dpdk.org \
--cc=helin.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.