All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ben Walker <benjamin.walker@intel.com>
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH] eal: Fix device registration on FreeBSD
Date: Mon, 27 Mar 2017 12:01:51 +0200	[thread overview]
Message-ID: <3259292.ro3bpgFpyD@xps13> (raw)
In-Reply-To: <0ff897d0-0541-652b-c77b-6369c3e41a67@nxp.com>

2017-03-27 11:34, Shreyansh Jain:
> On Wednesday 22 March 2017 12:02 AM, Ben Walker wrote:
> > The FreeBSD implementation wasn't registering new devices
> > with the device framework on start up. However, common
> > code attempts to unregister them on shutdown which causes
> > a SEGFAULT. This fix makes the FreeBSD code do the same
> > thing as the Linux code for registration.
> >
> > Signed-off-by: Ben Walker <benjamin.walker@intel.com>
> > ---
> >  lib/librte_eal/bsdapp/eal/eal_pci.c | 6 ++++--
> >  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> I can't vouch for BSD as I don't have that environment to verify. But, 
> the patch looks fine to me as compared to Linux changes.
> 
> so, if my Ack makes sense:
> 
> Acked-by: Shreyansh Jain <shreyansh.jain@nxp.com>

Applied, thanks

      reply	other threads:[~2017-03-27 10:01 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-21 18:32 [PATCH] eal: Fix device registration on FreeBSD Ben Walker
2017-03-27  6:04 ` Shreyansh Jain
2017-03-27 10:01   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3259292.ro3bpgFpyD@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=benjamin.walker@intel.com \
    --cc=dev@dpdk.org \
    --cc=shreyansh.jain@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.