All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Piotr Łobacz" <p.lobacz@welotec.com>
To: "openembedded-core@lists.openembedded.org"
	<openembedded-core@lists.openembedded.org>,
	Richard Purdie <richard.purdie@linuxfoundation.org>
Subject: Re: [OE-Core][PATCH] curl-native: add missing ca-certificates.crt file
Date: Mon, 13 Nov 2023 11:38:37 +0000	[thread overview]
Message-ID: <3259483.aeNJFYEL58@latitude> (raw)
In-Reply-To: <238464863e9bdea94b8773983a8e79df07c30607.camel@linuxfoundation.org>

Dnia poniedziałek, 13 listopada 2023 12:35:23 CET Richard Purdie pisze:
> On Fri, 2023-11-10 at 20:37 +0100, Piotr Łobacz wrote:
> > By default curl is being configured with:
> > 
> > --with-ca-bundle=${sysconfdir}/ssl/certs/ca-certificates.crt
> > 
> > which causes an issue for native build, when calling
> > curl-native command, as certificates file is missing.
> > 
> > This commit fixes the issue.
> > 
> > Signed-off-by: Piotr Łobacz <p.lobacz@welotec.com>
> > ---
> > 
> >  meta/recipes-support/curl/curl_8.4.0.bb | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/meta/recipes-support/curl/curl_8.4.0.bb
> > b/meta/recipes-support/curl/curl_8.4.0.bb index 5f97730bf4..165a116139
> > 100644
> > --- a/meta/recipes-support/curl/curl_8.4.0.bb
> > +++ b/meta/recipes-support/curl/curl_8.4.0.bb
> > @@ -130,7 +130,9 @@ PACKAGES =+ "lib${BPN}"
> > 
> >  FILES:lib${BPN} = "${libdir}/lib*.so.*"
> >  RRECOMMENDS:lib${BPN} += "ca-certificates"
> > 
> > +DEPENDS:append:class-native = " ca-certificates-native"
> > 
> > +SYSROOT_DIRS:append =" /etc/ssl/certs"
> > 
> >  FILES:${PN} += "${datadir}/zsh"
> >  
> >  inherit multilib_script
> 
> Adding the dependency I can understand but the SYSROOT_DIRS append
> would need to be in the ca-certificates recipe to be of any use as I
> understand it?

Yeah, my mistake ca-certificates recipe needs this sorry haven't noticed.
> 
> Also, wouldn't a += instead of a append work for SYSROOT_DIRS?

It should I can change it and test.

> 
> Cheers,
> 
> Richard

BR
Piotr


  reply	other threads:[~2023-11-13 11:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10 19:37 [OE-Core][PATCH] curl-native: add missing ca-certificates.crt file Piotr Łobacz
2023-11-13 11:35 ` Richard Purdie
2023-11-13 11:38   ` Piotr Łobacz [this message]
2023-11-13 17:44 ` Ross Burton
2023-11-15 21:49   ` ODP: " Piotr Łobacz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3259483.aeNJFYEL58@latitude \
    --to=p.lobacz@welotec.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.