From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Arvind Yadav <arvind.yadav.cs@gmail.com>,
leoli@freescale.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Removing lots of IS_ERR_VALUE abuses and compilation warning.
Date: Thu, 07 Jul 2016 17:45:53 +0200 [thread overview]
Message-ID: <3262228.FZLtnpegJr@wuerfel> (raw)
In-Reply-To: <1467904336-3588-1-git-send-email-arvind.yadav.cs@gmail.com>
On Thursday, July 7, 2016 8:42:16 PM CEST Arvind Yadav wrote:
> Passing value in IS_ERR_VALUE() is wrong, as they
> pass an 'int' into a function that takes an 'unsigned long'
> argument. This happens to work because the type is sign-extended
> on 64-bit architectures before it gets converted into an
> unsigned type.
>
> Passing an 'unsigned short' or 'unsigned int'
> argument into IS_ERR_VALUE() is guaranteed to be broken, as are
> 8-bit integers and types that are wider than 'unsigned long'.
>
> Any user will get compilation warning for that do not pass an
> 'unsigned long' argument.
>
> Commit '287980e49f; - This change is alreday fixes lots of other
> worst abusers.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>
Acked-by: Arnd Bergmann <arnd@arndb.de>
just notice about your submission that the changelog is whitespace
damaged, you probably got the leading whitespace when you pasted
a git log into the commit.
Arnd
next prev parent reply other threads:[~2016-07-07 15:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 15:12 [PATCH] Removing lots of IS_ERR_VALUE abuses and compilation warning Arvind Yadav
2016-07-07 15:45 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-07 15:52 Arvind Yadav
2016-07-07 16:00 Arvind Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3262228.FZLtnpegJr@wuerfel \
--to=arnd@arndb.de \
--cc=arvind.yadav.cs@gmail.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.