From mboxrd@z Thu Jan  1 00:00:00 1970
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 2/3] drm/omap: displays: connector-hdmi: Support for hot
 plug detection
Date: Tue, 23 May 2017 12:45:27 +0300
Message-ID: <3265236.TtRcDxutng@avalon>
References: <20170515090312.32051-1-peter.ujfalusi@ti.com>
 <20170515090312.32051-3-peter.ujfalusi@ti.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from galahad.ideasonboard.com (galahad.ideasonboard.com
 [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 67E516E134
 for <dri-devel@lists.freedesktop.org>; Tue, 23 May 2017 09:45:11 +0000 (UTC)
In-Reply-To: <20170515090312.32051-3-peter.ujfalusi@ti.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: tomi.valkeinen@ti.com, dri-devel@lists.freedesktop.org, jsarha@ti.com, linux-kernel@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

SGkgUGV0ZXIsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIE1vbmRheSAxNSBNYXkgMjAx
NyAxMjowMzoxMSBQZXRlciBVamZhbHVzaSB3cm90ZToKPiBJZiB0aGUgaHBkX2dwaW8gaXMgdmFs
aWQsIHVzZSBpbnRlcnJ1cHQgaGFuZGxlciB0byByZWFjdCB0byBIUEQgY2hhbmdlcy4KPiBJbiBj
YXNlIHRoZSBocGRfZ3BpbyBpcyBub3QgdmFsaWQsIHRyeSB0byBlbmFibGUgaHBkIGRldGVjdGlv
biBvbiB0aGUKPiBlbmNvZGVyIGlmIGl0IHN1cHBvcnRzIGl0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6
IFBldGVyIFVqZmFsdXNpIDxwZXRlci51amZhbHVzaUB0aS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv
Z3B1L2RybS9vbWFwZHJtL2Rpc3BsYXlzL2Nvbm5lY3Rvci1oZG1pLmMgfCAxMDQgKysrKysrKysr
KysrKysrKysrKwo+ICAxIGZpbGUgY2hhbmdlZCwgMTA0IGluc2VydGlvbnMoKykKPiAKPiBkaWZm
IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZGlzcGxheXMvY29ubmVjdG9yLWhkbWku
Ywo+IGIvZHJpdmVycy9ncHUvZHJtL29tYXBkcm0vZGlzcGxheXMvY29ubmVjdG9yLWhkbWkuYyBp
bmRleAo+IDFlZjEzMDY0MWJhZS4uM2E5MGY4OWFkYTc3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv
Z3B1L2RybS9vbWFwZHJtL2Rpc3BsYXlzL2Nvbm5lY3Rvci1oZG1pLmMKPiArKysgYi9kcml2ZXJz
L2dwdS9kcm0vb21hcGRybS9kaXNwbGF5cy9jb25uZWN0b3ItaGRtaS5jCj4gQEAgLTE1LDYgKzE1
LDcgQEAKPiAgI2luY2x1ZGUgPGxpbnV4L3BsYXRmb3JtX2RldmljZS5oPgo+ICAjaW5jbHVkZSA8
bGludXgvb2YuaD4KPiAgI2luY2x1ZGUgPGxpbnV4L29mX2dwaW8uaD4KPiArI2luY2x1ZGUgPGxp
bnV4L3NwaW5sb2NrLmg+CgpEaWQgeW91IG1lYW4gbGludXgvbXV0ZXguaCA/Cgo+IAo+ICAjaW5j
bHVkZSA8ZHJtL2RybV9lZGlkLmg+Cj4gICNpbmNsdWRlIDx2aWRlby9vbWFwLXBhbmVsLWRhdGEu
aD4KPiBAQCAtMzgsNiArMzksMTAgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCB2aWRlb21vZGUgaGRt
aWNfZGVmYXVsdF92bSA9IHsKPiAgc3RydWN0IHBhbmVsX2Rydl9kYXRhIHsKPiAgCXN0cnVjdCBv
bWFwX2Rzc19kZXZpY2UgZHNzZGV2Owo+ICAJc3RydWN0IG9tYXBfZHNzX2RldmljZSAqaW47Cj4g
Kwl2b2lkICgqaHBkX2NiKSh2b2lkICpjYl9kYXRhLCBlbnVtIGRybV9jb25uZWN0b3Jfc3RhdHVz
IHN0YXR1cyk7Cj4gKwl2b2lkICpocGRfY2JfZGF0YTsKPiArCWJvb2wgaHBkX2VuYWJsZWQ7Cj4g
KwlzdHJ1Y3QgbXV0ZXggaHBkX2xvY2s7Cj4gCj4gIAlzdHJ1Y3QgZGV2aWNlICpkZXY7Cj4gCj4g
QEAgLTE2OCw2ICsxNzMsNzAgQEAgc3RhdGljIGJvb2wgaGRtaWNfZGV0ZWN0KHN0cnVjdCBvbWFw
X2Rzc19kZXZpY2UKPiAqZHNzZGV2KSByZXR1cm4gaW4tPm9wcy5oZG1pLT5kZXRlY3QoaW4pOwo+
ICB9Cj4gCj4gK3N0YXRpYyBpbnQgaGRtaWNfcmVnaXN0ZXJfaHBkX2NiKHN0cnVjdCBvbWFwX2Rz
c19kZXZpY2UgKmRzc2RldiwKPiArCQkJCSB2b2lkICgqY2IpKHZvaWQgKmNiX2RhdGEsCj4gKwkJ
CQkJICAgIGVudW0gZHJtX2Nvbm5lY3Rvcl9zdGF0dXMgc3RhdHVzKSwKPiArCQkJCSB2b2lkICpj
Yl9kYXRhKQo+ICt7Cj4gKwlzdHJ1Y3QgcGFuZWxfZHJ2X2RhdGEgKmRkYXRhID0gdG9fcGFuZWxf
ZGF0YShkc3NkZXYpOwo+ICsJc3RydWN0IG9tYXBfZHNzX2RldmljZSAqaW4gPSBkZGF0YS0+aW47
Cj4gKwo+ICsJaWYgKGdwaW9faXNfdmFsaWQoZGRhdGEtPmhwZF9ncGlvKSkgewo+ICsJCW11dGV4
X2xvY2soJmRkYXRhLT5ocGRfbG9jayk7Cj4gKwkJZGRhdGEtPmhwZF9jYiA9IGNiOwo+ICsJCWRk
YXRhLT5ocGRfY2JfZGF0YSA9IGNiX2RhdGE7Cj4gKwkJbXV0ZXhfdW5sb2NrKCZkZGF0YS0+aHBk
X2xvY2spOwo+ICsJCXJldHVybiAwOwo+ICsJfSBlbHNlIGlmIChpbi0+b3BzLmhkbWktPnJlZ2lz
dGVyX2hwZF9jYikgewo+ICsJCXJldHVybiBpbi0+b3BzLmhkbWktPnJlZ2lzdGVyX2hwZF9jYihp
biwgY2IsIGNiX2RhdGEpOwo+ICsJfQo+ICsKPiArCXJldHVybiAtRU5PVFNVUFA7Cj4gK30KPiAr
Cj4gK3N0YXRpYyB2b2lkIGhkbWljX3VucmVnaXN0ZXJfaHBkX2NiKHN0cnVjdCBvbWFwX2Rzc19k
ZXZpY2UgKmRzc2RldikKPiArewo+ICsJc3RydWN0IHBhbmVsX2Rydl9kYXRhICpkZGF0YSA9IHRv
X3BhbmVsX2RhdGEoZHNzZGV2KTsKPiArCXN0cnVjdCBvbWFwX2Rzc19kZXZpY2UgKmluID0gZGRh
dGEtPmluOwo+ICsKPiArCWlmIChncGlvX2lzX3ZhbGlkKGRkYXRhLT5ocGRfZ3BpbykpIHsKPiAr
CQltdXRleF9sb2NrKCZkZGF0YS0+aHBkX2xvY2spOwo+ICsJCWRkYXRhLT5ocGRfY2IgPSBOVUxM
Owo+ICsJCWRkYXRhLT5ocGRfY2JfZGF0YSA9IE5VTEw7Cj4gKwkJbXV0ZXhfdW5sb2NrKCZkZGF0
YS0+aHBkX2xvY2spOwo+ICsJfSBlbHNlIGlmIChpbi0+b3BzLmhkbWktPnVucmVnaXN0ZXJfaHBk
X2NiKSB7Cj4gKwkJaW4tPm9wcy5oZG1pLT51bnJlZ2lzdGVyX2hwZF9jYihpbik7Cj4gKwl9Cj4g
K30KPiArCj4gK3N0YXRpYyB2b2lkIGhkbWljX2VuYWJsZV9ocGQoc3RydWN0IG9tYXBfZHNzX2Rl
dmljZSAqZHNzZGV2KQo+ICt7Cj4gKwlzdHJ1Y3QgcGFuZWxfZHJ2X2RhdGEgKmRkYXRhID0gdG9f
cGFuZWxfZGF0YShkc3NkZXYpOwo+ICsJc3RydWN0IG9tYXBfZHNzX2RldmljZSAqaW4gPSBkZGF0
YS0+aW47Cj4gKwo+ICsJaWYgKGdwaW9faXNfdmFsaWQoZGRhdGEtPmhwZF9ncGlvKSkgewo+ICsJ
CW11dGV4X2xvY2soJmRkYXRhLT5ocGRfbG9jayk7Cj4gKwkJZGRhdGEtPmhwZF9lbmFibGVkID0g
dHJ1ZTsKPiArCQltdXRleF91bmxvY2soJmRkYXRhLT5ocGRfbG9jayk7Cj4gKwl9IGVsc2UgaWYg
KGluLT5vcHMuaGRtaS0+ZW5hYmxlX2hwZCkgewo+ICsJCWluLT5vcHMuaGRtaS0+ZW5hYmxlX2hw
ZChpbik7Cj4gKwl9Cj4gK30KPiArCj4gK3N0YXRpYyB2b2lkIGhkbWljX2Rpc2FibGVfaHBkKHN0
cnVjdCBvbWFwX2Rzc19kZXZpY2UgKmRzc2RldikKPiArewo+ICsJc3RydWN0IHBhbmVsX2Rydl9k
YXRhICpkZGF0YSA9IHRvX3BhbmVsX2RhdGEoZHNzZGV2KTsKPiArCXN0cnVjdCBvbWFwX2Rzc19k
ZXZpY2UgKmluID0gZGRhdGEtPmluOwo+ICsKPiArCWlmIChncGlvX2lzX3ZhbGlkKGRkYXRhLT5o
cGRfZ3BpbykpIHsKPiArCQltdXRleF9sb2NrKCZkZGF0YS0+aHBkX2xvY2spOwo+ICsJCWRkYXRh
LT5ocGRfZW5hYmxlZCA9IGZhbHNlOwo+ICsJCW11dGV4X3VubG9jaygmZGRhdGEtPmhwZF9sb2Nr
KTsKPiArCX0gZWxzZSBpZiAoaW4tPm9wcy5oZG1pLT5kaXNhYmxlX2hwZCkgewo+ICsJCWluLT5v
cHMuaGRtaS0+ZGlzYWJsZV9ocGQoaW4pOwo+ICsJfQo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGhk
bWljX3NldF9oZG1pX21vZGUoc3RydWN0IG9tYXBfZHNzX2RldmljZSAqZHNzZGV2LCBib29sCj4g
aGRtaV9tb2RlKSB7Cj4gIAlzdHJ1Y3QgcGFuZWxfZHJ2X2RhdGEgKmRkYXRhID0gdG9fcGFuZWxf
ZGF0YShkc3NkZXYpOwo+IEBAIC0yMDAsMTAgKzI2OSwzNCBAQCBzdGF0aWMgc3RydWN0IG9tYXBf
ZHNzX2RyaXZlciBoZG1pY19kcml2ZXIgPSB7Cj4gCj4gIAkucmVhZF9lZGlkCQk9IGhkbWljX3Jl
YWRfZWRpZCwKPiAgCS5kZXRlY3QJCQk9IGhkbWljX2RldGVjdCwKPiArCS5yZWdpc3Rlcl9ocGRf
Y2IJPSBoZG1pY19yZWdpc3Rlcl9ocGRfY2IsCj4gKwkudW5yZWdpc3Rlcl9ocGRfY2IJPSBoZG1p
Y191bnJlZ2lzdGVyX2hwZF9jYiwKPiArCS5lbmFibGVfaHBkCQk9IGhkbWljX2VuYWJsZV9ocGQs
Cj4gKwkuZGlzYWJsZV9ocGQJCT0gaGRtaWNfZGlzYWJsZV9ocGQsCj4gIAkuc2V0X2hkbWlfbW9k
ZQkJPSBoZG1pY19zZXRfaGRtaV9tb2RlLAo+ICAJLnNldF9oZG1pX2luZm9mcmFtZQk9IGhkbWlj
X3NldF9pbmZvZnJhbWUsCj4gIH07Cj4gCj4gK3N0YXRpYyBpcnFyZXR1cm5fdCBoZG1pY19ocGRf
aXNyKGludCBpcnEsIHZvaWQgKmRhdGEpCj4gK3sKPiArCXN0cnVjdCBwYW5lbF9kcnZfZGF0YSAq
ZGRhdGEgPSBkYXRhOwo+ICsKPiArCW11dGV4X2xvY2soJmRkYXRhLT5ocGRfbG9jayk7Cj4gKwlp
ZiAoZGRhdGEtPmhwZF9lbmFibGVkICYmIGRkYXRhLT5ocGRfY2IpIHsKPiArCQllbnVtIGRybV9j
b25uZWN0b3Jfc3RhdHVzIHN0YXR1czsKPiArCj4gKwkJaWYgKGhkbWljX2RldGVjdCgmZGRhdGEt
PmRzc2RldikpCj4gKwkJCXN0YXR1cyA9IGNvbm5lY3Rvcl9zdGF0dXNfY29ubmVjdGVkOwo+ICsJ
CWVsc2UKPiArCQkJc3RhdHVzID0gY29ubmVjdG9yX3N0YXR1c19kaXNjb25uZWN0ZWQ7Cj4gKwo+
ICsJCWRkYXRhLT5ocGRfY2IoZGRhdGEtPmhwZF9jYl9kYXRhLCBzdGF0dXMpOwo+ICsJfQo+ICsJ
bXV0ZXhfdW5sb2NrKCZkZGF0YS0+aHBkX2xvY2spOwoKU2hvdWxkbid0IGRkYXRhLT5ocGRfY2Io
KSBiZSBjYWxsZWQgd2l0aG91dCB0aGUgbXV0ZXggaGVsZCA/IEkgZG9uJ3QgdGhpbmsgCmNvcmUg
Y29kZSBzaG91bGQgcmVseSBvbiBjYWxsZXJzIHRvIGhhbmRsZSBsb2NraW5nIGluIHRoaXMgY2Fz
ZS4KCgo+ICsJcmV0dXJuIElSUV9IQU5ETEVEOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGhkbWlj
X3Byb2JlX29mKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBkZXYpCj4gIHsKPiAgCXN0cnVjdCBw
YW5lbF9kcnZfZGF0YSAqZGRhdGEgPSBwbGF0Zm9ybV9nZXRfZHJ2ZGF0YShwZGV2KTsKPiBAQCAt
MjQ5LDExICszNDIsMjIgQEAgc3RhdGljIGludCBoZG1pY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f
ZGV2aWNlICpwZGV2KQo+ICAJaWYgKHIpCj4gIAkJcmV0dXJuIHI7Cj4gCj4gKwltdXRleF9pbml0
KCZkZGF0YS0+aHBkX2xvY2spOwo+ICsKPiAgCWlmIChncGlvX2lzX3ZhbGlkKGRkYXRhLT5ocGRf
Z3BpbykpIHsKPiAgCQlyID0gZGV2bV9ncGlvX3JlcXVlc3Rfb25lKCZwZGV2LT5kZXYsIGRkYXRh
LT5ocGRfZ3BpbywKPiAgCQkJCUdQSU9GX0RJUl9JTiwgImhkbWlfaHBkIik7Cj4gIAkJaWYgKHIp
Cj4gIAkJCWdvdG8gZXJyX3JlZzsKPiArCj4gKwkJciA9IGRldm1fcmVxdWVzdF90aHJlYWRlZF9p
cnEoJnBkZXYtPmRldiwKPiArCQkJCWdwaW9fdG9faXJxKGRkYXRhLT5ocGRfZ3BpbyksCgpXaGF0
IGlzIGhwZF9ncGlvIGlzIHZhbGlkIGJ1dCBoYXMgbm8gSVJRIHN1cHBvcnQgPwoKPiArCQkJCU5V
TEwsIGhkbWljX2hwZF9pc3IsCj4gKwkJCQlJUlFGX1RSSUdHRVJfUklTSU5HIHwgSVJRRl9UUklH
R0VSX0ZBTExJTkcgfAo+ICsJCQkJSVJRRl9PTkVTSE9ULAo+ICsJCQkJImhkbWljIGhwZCIsIGRk
YXRhKTsKPiArCQlpZiAocikKPiArCQkJZ290byBlcnJfcmVnOwo+ICAJfQo+IAo+ICAJZGRhdGEt
PnZtID0gaGRtaWNfZGVmYXVsdF92bTsKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoK
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S967269AbdEWJpQ (ORCPT <rfc822;w@1wt.eu>);
        Tue, 23 May 2017 05:45:16 -0400
Received: from galahad.ideasonboard.com ([185.26.127.97]:46249 "EHLO
        galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757409AbdEWJpL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 23 May 2017 05:45:11 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc: tomi.valkeinen@ti.com, airlied@linux.ie, jsarha@ti.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] drm/omap: displays: connector-hdmi: Support for hot plug detection
Date: Tue, 23 May 2017 12:45:27 +0300
Message-ID: <3265236.TtRcDxutng@avalon>
User-Agent: KMail/4.14.10 (Linux/4.9.16-gentoo; KDE/4.14.32; x86_64; ; )
In-Reply-To: <20170515090312.32051-3-peter.ujfalusi@ti.com>
References: <20170515090312.32051-1-peter.ujfalusi@ti.com> <20170515090312.32051-3-peter.ujfalusi@ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

Thank you for the patch.

On Monday 15 May 2017 12:03:11 Peter Ujfalusi wrote:
> If the hpd_gpio is valid, use interrupt handler to react to HPD changes.
> In case the hpd_gpio is not valid, try to enable hpd detection on the
> encoder if it supports it.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/gpu/drm/omapdrm/displays/connector-hdmi.c | 104 +++++++++++++++++++
>  1 file changed, 104 insertions(+)
> 
> diff --git a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c index
> 1ef130641bae..3a90f89ada77 100644
> --- a/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> +++ b/drivers/gpu/drm/omapdrm/displays/connector-hdmi.c
> @@ -15,6 +15,7 @@
>  #include <linux/platform_device.h>
>  #include <linux/of.h>
>  #include <linux/of_gpio.h>
> +#include <linux/spinlock.h>

Did you mean linux/mutex.h ?

> 
>  #include <drm/drm_edid.h>
>  #include <video/omap-panel-data.h>
> @@ -38,6 +39,10 @@ static const struct videomode hdmic_default_vm = {
>  struct panel_drv_data {
>  	struct omap_dss_device dssdev;
>  	struct omap_dss_device *in;
> +	void (*hpd_cb)(void *cb_data, enum drm_connector_status status);
> +	void *hpd_cb_data;
> +	bool hpd_enabled;
> +	struct mutex hpd_lock;
> 
>  	struct device *dev;
> 
> @@ -168,6 +173,70 @@ static bool hdmic_detect(struct omap_dss_device
> *dssdev) return in->ops.hdmi->detect(in);
>  }
> 
> +static int hdmic_register_hpd_cb(struct omap_dss_device *dssdev,
> +				 void (*cb)(void *cb_data,
> +					    enum drm_connector_status status),
> +				 void *cb_data)
> +{
> +	struct panel_drv_data *ddata = to_panel_data(dssdev);
> +	struct omap_dss_device *in = ddata->in;
> +
> +	if (gpio_is_valid(ddata->hpd_gpio)) {
> +		mutex_lock(&ddata->hpd_lock);
> +		ddata->hpd_cb = cb;
> +		ddata->hpd_cb_data = cb_data;
> +		mutex_unlock(&ddata->hpd_lock);
> +		return 0;
> +	} else if (in->ops.hdmi->register_hpd_cb) {
> +		return in->ops.hdmi->register_hpd_cb(in, cb, cb_data);
> +	}
> +
> +	return -ENOTSUPP;
> +}
> +
> +static void hdmic_unregister_hpd_cb(struct omap_dss_device *dssdev)
> +{
> +	struct panel_drv_data *ddata = to_panel_data(dssdev);
> +	struct omap_dss_device *in = ddata->in;
> +
> +	if (gpio_is_valid(ddata->hpd_gpio)) {
> +		mutex_lock(&ddata->hpd_lock);
> +		ddata->hpd_cb = NULL;
> +		ddata->hpd_cb_data = NULL;
> +		mutex_unlock(&ddata->hpd_lock);
> +	} else if (in->ops.hdmi->unregister_hpd_cb) {
> +		in->ops.hdmi->unregister_hpd_cb(in);
> +	}
> +}
> +
> +static void hdmic_enable_hpd(struct omap_dss_device *dssdev)
> +{
> +	struct panel_drv_data *ddata = to_panel_data(dssdev);
> +	struct omap_dss_device *in = ddata->in;
> +
> +	if (gpio_is_valid(ddata->hpd_gpio)) {
> +		mutex_lock(&ddata->hpd_lock);
> +		ddata->hpd_enabled = true;
> +		mutex_unlock(&ddata->hpd_lock);
> +	} else if (in->ops.hdmi->enable_hpd) {
> +		in->ops.hdmi->enable_hpd(in);
> +	}
> +}
> +
> +static void hdmic_disable_hpd(struct omap_dss_device *dssdev)
> +{
> +	struct panel_drv_data *ddata = to_panel_data(dssdev);
> +	struct omap_dss_device *in = ddata->in;
> +
> +	if (gpio_is_valid(ddata->hpd_gpio)) {
> +		mutex_lock(&ddata->hpd_lock);
> +		ddata->hpd_enabled = false;
> +		mutex_unlock(&ddata->hpd_lock);
> +	} else if (in->ops.hdmi->disable_hpd) {
> +		in->ops.hdmi->disable_hpd(in);
> +	}
> +}
> +
>  static int hdmic_set_hdmi_mode(struct omap_dss_device *dssdev, bool
> hdmi_mode) {
>  	struct panel_drv_data *ddata = to_panel_data(dssdev);
> @@ -200,10 +269,34 @@ static struct omap_dss_driver hdmic_driver = {
> 
>  	.read_edid		= hdmic_read_edid,
>  	.detect			= hdmic_detect,
> +	.register_hpd_cb	= hdmic_register_hpd_cb,
> +	.unregister_hpd_cb	= hdmic_unregister_hpd_cb,
> +	.enable_hpd		= hdmic_enable_hpd,
> +	.disable_hpd		= hdmic_disable_hpd,
>  	.set_hdmi_mode		= hdmic_set_hdmi_mode,
>  	.set_hdmi_infoframe	= hdmic_set_infoframe,
>  };
> 
> +static irqreturn_t hdmic_hpd_isr(int irq, void *data)
> +{
> +	struct panel_drv_data *ddata = data;
> +
> +	mutex_lock(&ddata->hpd_lock);
> +	if (ddata->hpd_enabled && ddata->hpd_cb) {
> +		enum drm_connector_status status;
> +
> +		if (hdmic_detect(&ddata->dssdev))
> +			status = connector_status_connected;
> +		else
> +			status = connector_status_disconnected;
> +
> +		ddata->hpd_cb(ddata->hpd_cb_data, status);
> +	}
> +	mutex_unlock(&ddata->hpd_lock);

Shouldn't ddata->hpd_cb() be called without the mutex held ? I don't think 
core code should rely on callers to handle locking in this case.


> +	return IRQ_HANDLED;
> +}
> +
>  static int hdmic_probe_of(struct platform_device *pdev)
>  {
>  	struct panel_drv_data *ddata = platform_get_drvdata(pdev);
> @@ -249,11 +342,22 @@ static int hdmic_probe(struct platform_device *pdev)
>  	if (r)
>  		return r;
> 
> +	mutex_init(&ddata->hpd_lock);
> +
>  	if (gpio_is_valid(ddata->hpd_gpio)) {
>  		r = devm_gpio_request_one(&pdev->dev, ddata->hpd_gpio,
>  				GPIOF_DIR_IN, "hdmi_hpd");
>  		if (r)
>  			goto err_reg;
> +
> +		r = devm_request_threaded_irq(&pdev->dev,
> +				gpio_to_irq(ddata->hpd_gpio),

What is hpd_gpio is valid but has no IRQ support ?

> +				NULL, hdmic_hpd_isr,
> +				IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING |
> +				IRQF_ONESHOT,
> +				"hdmic hpd", ddata);
> +		if (r)
> +			goto err_reg;
>  	}
> 
>  	ddata->vm = hdmic_default_vm;

-- 
Regards,

Laurent Pinchart