From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAC70C43460 for ; Tue, 4 May 2021 15:35:57 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 648976115B for ; Tue, 4 May 2021 15:35:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 648976115B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BD2486EB1C; Tue, 4 May 2021 15:35:56 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F2996EB1C for ; Tue, 4 May 2021 15:35:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620142554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjANuhmunmxl1tjd4moAyPGINXbx5GlWhcPk5Awa2JU=; b=J3cm8yJMBhCYCRRMruAKc4Pyo/MeksX/PT2NysDL8jTzxGQ9GkKWvuSeSCHiN6tSrEvbE1 YNumQDDvUc/pdyuczhZe5iyB4VQT8nmAdQEttEPPeLFtXwYZwvTPxcEB6prZRqygUj3BXY ccAeRRom/ifU10SpSLFtSUW09l02o0U= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-519-rbttNzXFNLavlyBZGUf6dA-1; Tue, 04 May 2021 11:35:53 -0400 X-MC-Unique: rbttNzXFNLavlyBZGUf6dA-1 Received: by mail-ed1-f71.google.com with SMTP id g19-20020a0564021813b029038811907178so6579154edy.14 for ; Tue, 04 May 2021 08:35:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FjANuhmunmxl1tjd4moAyPGINXbx5GlWhcPk5Awa2JU=; b=lMSO1wUlEx1ebeHgFx3nKTUad6ikxbR1IP9SN5vcw5dK9YmkY2INH92P7H0UBa8iOx dDSWvGoAlvTKj8G42GJnBQOFNHc/md9oe/p2j/GeO3QXqZEhdjbR+MB9c89n0CeclAmJ i09Oh8GsZmVtkxrAjJFZWD80hmWbAvUBh6DGtIlQU2fMs2ylk3QgMhdZ5vVbi9xSdZaG /eAkoMc7MzhYkjP5tD3NVyNuJwDEYw/0vOh/2npFs5kMjA25VcPdglP9zYab4z0AHIYL frLGTkjSPR5uJisa+IM7Q5y6ZEEyxGs1eYledbnEOV159KYV0O5ye1oG+x+kBt/cO0e7 95/w== X-Gm-Message-State: AOAM533a6if9i84EGZMJh0XkuLxt/1iqM4tX6qLnNIG0rt63gvxHFs45 IuKiPRUu2tLVZ/ocUKduTBwSR/CBqFmpqaHyuQy57/nUga/4ku1x+x+aTbeieNsMYFQaernXUNv Jg6zypNal8hkDCBIKPL+413Cb1uSm X-Received: by 2002:a17:906:cd27:: with SMTP id oz39mr18874307ejb.129.1620142550774; Tue, 04 May 2021 08:35:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmyw0dujywRY0BkQgCLf9VxiL7liqXtJ0bEMhZiU1xqc+xgw8QvX8u6muUU7TbNtZxdprzkg== X-Received: by 2002:a17:906:cd27:: with SMTP id oz39mr18874288ejb.129.1620142550583; Tue, 04 May 2021 08:35:50 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id d18sm1584825eja.71.2021.05.04.08.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 May 2021 08:35:50 -0700 (PDT) To: Heikki Krogerus , Imre Deak References: <20210503154647.142551-1-hdegoede@redhat.com> <20210503154647.142551-5-hdegoede@redhat.com> From: Hans de Goede Message-ID: <326621fe-cc4e-ad77-c87e-922a655bfbc8@redhat.com> Date: Tue, 4 May 2021 17:35:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2) X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, Thomas Zimmermann , David Airlie , Greg Kroah-Hartman , intel-gfx , platform-driver-x86@vger.kernel.org, Maxime Ripard , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, On 5/4/21 5:10 PM, Heikki Krogerus wrote: >> +/** >> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector >> + * @connector: connector to report the event on >> + * @data: data related to the event >> + * >> + * On some hardware a hotplug event notification may come from outside the display >> + * driver / device. An example of this is some USB Type-C setups where the hardware >> + * muxes the DisplayPort data and aux-lines but does not pass the altmode HPD >> + * status bit to the GPU's DP HPD pin. >> + * >> + * This function can be used to report these out-of-band events after obtaining >> + * a drm_connector reference through calling drm_connector_find_by_fwnode(). >> + */ >> +void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, >> + struct drm_connector_oob_hotplug_event_data *data) >> +{ >> + struct drm_connector *connector; >> + >> + connector = drm_connector_find_by_fwnode(connector_fwnode); >> + if (IS_ERR(connector)) >> + return; >> + >> + if (connector->funcs->oob_hotplug_event) >> + connector->funcs->oob_hotplug_event(connector, data); >> + >> + drm_connector_put(connector); >> +} >> +EXPORT_SYMBOL(drm_connector_oob_hotplug_event); > > So it does looks like the "data" parameter is not needed at all: Well Imre did indicate that having the number of lanes is useful, so for the next version I'll drop the orientation but I plan to keep the number of lanes if that is ok with you. Not having passing along this info was one of the reasons why my previous attempt at this was nacked, so dropping it all together feels wrong. Regards, Hans _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EEDAC433B4 for ; Tue, 4 May 2021 15:35:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1B39D6117A for ; Tue, 4 May 2021 15:35:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230500AbhEDPgt (ORCPT ); Tue, 4 May 2021 11:36:49 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:28860 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230112AbhEDPgt (ORCPT ); Tue, 4 May 2021 11:36:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620142553; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjANuhmunmxl1tjd4moAyPGINXbx5GlWhcPk5Awa2JU=; b=cZbKbJJHCLweKWrBpbqEOh4gs/sFF1LTRBCB7h3nazJ1Cll8mkCqkVJF3jzssqIh7hSheN N1n9hVi4W1nfDrYaFTQybA+8GSO9kPq/j6LZfefwZ9vfRFkPqGkTQw3dvwwk13F+aiXjxC Leykx0bns6YgrCYzKMwFn9XlV4Ogsh4= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-210-ojDszxQqMDW6-sRm1l7JxA-1; Tue, 04 May 2021 11:35:52 -0400 X-MC-Unique: ojDszxQqMDW6-sRm1l7JxA-1 Received: by mail-ed1-f69.google.com with SMTP id y15-20020aa7d50f0000b02903885ee98723so6543855edq.16 for ; Tue, 04 May 2021 08:35:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FjANuhmunmxl1tjd4moAyPGINXbx5GlWhcPk5Awa2JU=; b=FarXQh30qQSvTvuTArAewCOxr/IDzdUQiOnvHjpq5ksPP4lie+56aInaFCwdk6kjkh cQxC3vQ6j5wIu9phIrabrXyyyqKU9iWl0mbFh4FBz1+6FdFnKjSI/WgcGubJ8Etli8da Pk8qut9b6w1lo5wJj68owOAIDW87XeK7n+2pvq0SEv0rJxxgyxBXzCPOBoqNJwWFct38 rhnIJznqQC+Ynh1o8u7dmOHWsc9IR9yXYmGv7H2mP9S9lVZpseNTm5E0AyAgDFkiNOLt nJ8Zejg0mEi/08kf8UyntIP6dHAWCUTQ/uofDpQ+zjxvN30TnG9i52AGENV1Q7rcKj8i o20w== X-Gm-Message-State: AOAM531PQwpH8Lq3qeWXETro7gWKiuBKDrvu7F7YvCWk6nex3TBa+0I2 rGCpxFwo1IKZy9Y/n17vtOeJPylOcB00i7nxuurbBYxayoRX5xbvBiCHgpp9cuNkDbt/RYZkpdm t9PqhO8sz5KoeIF9mxNytMcdTh5ISlT22JPK7aCVW64Z3AKtO8/e56BRvnwal3Piw84Pz3NhZ X-Received: by 2002:a17:906:cd27:: with SMTP id oz39mr18874322ejb.129.1620142550860; Tue, 04 May 2021 08:35:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmyw0dujywRY0BkQgCLf9VxiL7liqXtJ0bEMhZiU1xqc+xgw8QvX8u6muUU7TbNtZxdprzkg== X-Received: by 2002:a17:906:cd27:: with SMTP id oz39mr18874288ejb.129.1620142550583; Tue, 04 May 2021 08:35:50 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id d18sm1584825eja.71.2021.05.04.08.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 May 2021 08:35:50 -0700 (PDT) Subject: Re: [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2) To: Heikki Krogerus , Imre Deak Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Daniel Vetter , David Airlie , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Greg Kroah-Hartman , Guenter Roeck , intel-gfx , dri-devel@lists.freedesktop.org, platform-driver-x86@vger.kernel.org, linux-usb@vger.kernel.org References: <20210503154647.142551-1-hdegoede@redhat.com> <20210503154647.142551-5-hdegoede@redhat.com> From: Hans de Goede Message-ID: <326621fe-cc4e-ad77-c87e-922a655bfbc8@redhat.com> Date: Tue, 4 May 2021 17:35:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi, On 5/4/21 5:10 PM, Heikki Krogerus wrote: >> +/** >> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector >> + * @connector: connector to report the event on >> + * @data: data related to the event >> + * >> + * On some hardware a hotplug event notification may come from outside the display >> + * driver / device. An example of this is some USB Type-C setups where the hardware >> + * muxes the DisplayPort data and aux-lines but does not pass the altmode HPD >> + * status bit to the GPU's DP HPD pin. >> + * >> + * This function can be used to report these out-of-band events after obtaining >> + * a drm_connector reference through calling drm_connector_find_by_fwnode(). >> + */ >> +void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, >> + struct drm_connector_oob_hotplug_event_data *data) >> +{ >> + struct drm_connector *connector; >> + >> + connector = drm_connector_find_by_fwnode(connector_fwnode); >> + if (IS_ERR(connector)) >> + return; >> + >> + if (connector->funcs->oob_hotplug_event) >> + connector->funcs->oob_hotplug_event(connector, data); >> + >> + drm_connector_put(connector); >> +} >> +EXPORT_SYMBOL(drm_connector_oob_hotplug_event); > > So it does looks like the "data" parameter is not needed at all: Well Imre did indicate that having the number of lanes is useful, so for the next version I'll drop the orientation but I plan to keep the number of lanes if that is ok with you. Not having passing along this info was one of the reasons why my previous attempt at this was nacked, so dropping it all together feels wrong. Regards, Hans From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729DBC433ED for ; Tue, 4 May 2021 15:35:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F1476117A for ; Tue, 4 May 2021 15:35:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F1476117A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 06DCF6EB22; Tue, 4 May 2021 15:35:57 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5EB8A6EB1C for ; Tue, 4 May 2021 15:35:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1620142555; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FjANuhmunmxl1tjd4moAyPGINXbx5GlWhcPk5Awa2JU=; b=aA7Q87LQHJivZpVxmtw4t/4z609E74BGQIQQwY/M90Rl91PrjcxequxmyzW4F0tvD+pG1D kvP1i7eIbjBRgdMNFlvChGF2pU5nfSsPLopNood1Z7JVA9ut110jXhjQjAmqrnAxr9ko4h 0oANpUcj3Gu1VgQ/1o0lfjeLA+21YDc= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-570-ifkGY8J1OnC0wLkJHQOhVw-1; Tue, 04 May 2021 11:35:53 -0400 X-MC-Unique: ifkGY8J1OnC0wLkJHQOhVw-1 Received: by mail-ed1-f69.google.com with SMTP id d13-20020a056402144db0290387e63c95d8so6611258edx.11 for ; Tue, 04 May 2021 08:35:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FjANuhmunmxl1tjd4moAyPGINXbx5GlWhcPk5Awa2JU=; b=fJKV3LaVWBqW215PLr80Xf0cjQMeeS1nEmSDLOKSHOA5iYyzt6QyBKkGzA37W0pipC vmoN4btxB3GtPh0nlbwryj9WC09yCz1tSHDe5AvT+KBxpUdSbGJpjsFjtTTrU2AkHhnP 8ckr26e0EphMlQslRafo21vuhPs0Tqa60EqzN4r7AH0rdaU6zyWxQcjVKsQpQqW8tyHt sWWKDebPCeucHUtcCn83uob2bxlgELk3gz8tqQvipG5buqbYH+k2bMTDiKUoW0vu3NKK KFtX7HNCWOJ27UzF0ml5i5BwyGWZb/GmE/tGRb02Fi54MKwkzT2VSGw1qieo7c4yr5qu 1qPg== X-Gm-Message-State: AOAM533SHTIi1uxHdokkhDiNlNo4fDr/W6k9NiYtKXyoYC6wQX3pLn3F mFxyNXCPvwBS5gglg0Ipw6ZpGIznWdW39TV3BTCsMP/zeaQ9hQPueb7oK5pnYOYFRXzx86Exav7 LVU8jmyKCvxO1hqC3Vj3i0iyq6Qc9 X-Received: by 2002:a17:906:cd27:: with SMTP id oz39mr18874308ejb.129.1620142550774; Tue, 04 May 2021 08:35:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxmyw0dujywRY0BkQgCLf9VxiL7liqXtJ0bEMhZiU1xqc+xgw8QvX8u6muUU7TbNtZxdprzkg== X-Received: by 2002:a17:906:cd27:: with SMTP id oz39mr18874288ejb.129.1620142550583; Tue, 04 May 2021 08:35:50 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c1e-bf00-1054-9d19-e0f0-8214.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:1054:9d19:e0f0:8214]) by smtp.gmail.com with ESMTPSA id d18sm1584825eja.71.2021.05.04.08.35.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 May 2021 08:35:50 -0700 (PDT) Subject: Re: [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2) To: Heikki Krogerus , Imre Deak References: <20210503154647.142551-1-hdegoede@redhat.com> <20210503154647.142551-5-hdegoede@redhat.com> From: Hans de Goede Message-ID: <326621fe-cc4e-ad77-c87e-922a655bfbc8@redhat.com> Date: Tue, 4 May 2021 17:35:49 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=hdegoede@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, linux-usb@vger.kernel.org, Thomas Zimmermann , David Airlie , Greg Kroah-Hartman , intel-gfx , platform-driver-x86@vger.kernel.org, Rodrigo Vivi , Guenter Roeck Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 5/4/21 5:10 PM, Heikki Krogerus wrote: >> +/** >> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to connector >> + * @connector: connector to report the event on >> + * @data: data related to the event >> + * >> + * On some hardware a hotplug event notification may come from outside the display >> + * driver / device. An example of this is some USB Type-C setups where the hardware >> + * muxes the DisplayPort data and aux-lines but does not pass the altmode HPD >> + * status bit to the GPU's DP HPD pin. >> + * >> + * This function can be used to report these out-of-band events after obtaining >> + * a drm_connector reference through calling drm_connector_find_by_fwnode(). >> + */ >> +void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwnode, >> + struct drm_connector_oob_hotplug_event_data *data) >> +{ >> + struct drm_connector *connector; >> + >> + connector = drm_connector_find_by_fwnode(connector_fwnode); >> + if (IS_ERR(connector)) >> + return; >> + >> + if (connector->funcs->oob_hotplug_event) >> + connector->funcs->oob_hotplug_event(connector, data); >> + >> + drm_connector_put(connector); >> +} >> +EXPORT_SYMBOL(drm_connector_oob_hotplug_event); > > So it does looks like the "data" parameter is not needed at all: Well Imre did indicate that having the number of lanes is useful, so for the next version I'll drop the orientation but I plan to keep the number of lanes if that is ok with you. Not having passing along this info was one of the reasons why my previous attempt at this was nacked, so dropping it all together feels wrong. Regards, Hans _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel