From: David Howells <dhowells@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: dhowells@redhat.com, Roland McGrath <roland@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
James Morris <jmorris@namei.org>,
Tom Horsley <tom.horsley@att.net>,
linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex
Date: Fri, 04 Sep 2009 15:47:36 +0100 [thread overview]
Message-ID: <32710.1252075656@redhat.com> (raw)
In-Reply-To: <20090904133956.GA9232@redhat.com>
Oleg Nesterov <oleg@redhat.com> wrote:
> - install_exec_creds() drops the mutex after commit_creds(),
> and thus before tracehook_report_exec()->ptrace_stop().
Thanks!
> -
> - /* cred_guard_mutex must be held at least to this point to prevent
> - * ptrace_attach() from altering our determination of the task's
> - * credentials; any time after this it may be unlocked */
> -
Why are you removing this comment, btw? In what way does your patch
invalidate it?
David
next prev parent reply other threads:[~2009-09-04 14:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-03 16:05 [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex Oleg Nesterov
2009-09-03 20:09 ` Roland McGrath
2009-09-04 8:43 ` David Howells
2009-09-04 13:39 ` Oleg Nesterov
2009-09-04 14:47 ` David Howells [this message]
2009-09-04 15:49 ` Oleg Nesterov
2009-09-04 17:26 ` [PATCH v3] " Oleg Nesterov
2009-09-04 19:42 ` Andrew Morton
2009-09-04 21:33 ` Oleg Nesterov
2009-09-09 21:57 ` Chuck Ebbert
2009-09-09 22:58 ` Oleg Nesterov
2009-09-04 8:39 ` [PATCH 1/1] " David Howells
2009-09-04 9:24 ` Roland McGrath
2009-09-04 12:46 ` Oleg Nesterov
2009-09-04 13:39 ` David Howells
2009-09-04 13:55 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32710.1252075656@redhat.com \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
--cc=stable@kernel.org \
--cc=tom.horsley@att.net \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.