From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v4 8/8] app: add a new app proc_info
Date: Thu, 09 Jul 2015 03:39:35 +0200
Message-ID: <3280448.8fAfYn9D23@xps13>
References: <1436118000-132275-1-git-send-email-maryam.tahhan@intel.com>
 <1436118000-132275-9-git-send-email-maryam.tahhan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Maryam Tahhan <maryam.tahhan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com
 [209.85.212.177]) by dpdk.org (Postfix) with ESMTP id 664AE569A
 for <dev@dpdk.org>; Thu,  9 Jul 2015 03:40:41 +0200 (CEST)
Received: by wiclp1 with SMTP id lp1so95942816wic.0
 for <dev@dpdk.org>; Wed, 08 Jul 2015 18:40:41 -0700 (PDT)
In-Reply-To: <1436118000-132275-9-git-send-email-maryam.tahhan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2015-07-05 18:40, Maryam Tahhan:
> proc_info displays statistics information including extened stats for

typo: extended

> given DPDK ports and dumps the memory information for DPDK.
> 
> Signed-off-by: Maryam Tahhan <maryam.tahhan@intel.com>
> ---
>  MAINTAINERS            |   4 +
>  app/Makefile           |   1 +
>  app/proc_info/Makefile |  45 +++++
>  app/proc_info/main.c   | 512 +++++++++++++++++++++++++++++++++++++++++++++++++
>  mk/rte.sdktest.mk      |   4 +-
>  5 files changed, 564 insertions(+), 2 deletions(-)

A doc would be useful.

> +DIRS-$(CONFIG_RTE_LIBRTE_EAL_LINUXAPP) += proc_info

Why only Linux?

> +#   Copyright(c) 2010-2014 Intel Corporation. All rights reserved.

Too old :)

> +	if ((!port->rx_queue_stats_mapping_enabled) && (!port->tx_queue_stats_mapping_enabled)) {
> +		printf("  RX-packets: %-10"PRIu64" RX-missed: %-10"PRIu64" RX-bytes:  "
> +		       "%-"PRIu64"\n",
> +		       stats.ipackets, stats.imissed, stats.ibytes);
> +		printf("  RX-badcrc:  %-10"PRIu64" RX-badlen: %-10"PRIu64" RX-errors: "
> +		       "%-"PRIu64"\n",
> +		       stats.ibadcrc, stats.ibadlen, stats.ierrors);
> +		printf("  RX-nombuf:  %-10"PRIu64"\n",
> +		       stats.rx_nombuf);
> +		printf("  TX-packets: %-10"PRIu64" TX-errors: %-10"PRIu64" TX-bytes:  "
> +		       "%-"PRIu64"\n",
> +		       stats.opackets, stats.oerrors, stats.obytes);
> +	} else {
> +		printf("  RX-packets:              %10"PRIu64"    RX-errors: %10"PRIu64
> +		       "    RX-bytes: %10"PRIu64"\n",
> +		       stats.ipackets, stats.ierrors, stats.ibytes);
> +		printf("  RX-badcrc:               %10"PRIu64"    RX-badlen: %10"PRIu64
> +		       "  RX-errors:  %10"PRIu64"\n",
> +		       stats.ibadcrc, stats.ibadlen, stats.ierrors);
> +		printf("  RX-nombuf:               %10"PRIu64"\n",
> +		       stats.rx_nombuf);
> +		printf("  TX-packets:              %10"PRIu64"    TX-errors: %10"PRIu64
> +		       "    TX-bytes: %10"PRIu64"\n",
> +		       stats.opackets, stats.oerrors, stats.obytes);
> +	}

Why the formatting is different depending of device-specific stats mapping?

> +	if (port->rx_queue_stats_mapping_enabled) {
> +		printf("\n");
> +		for (i = 0; i < RTE_ETHDEV_QUEUE_STAT_CNTRS; i++) {
> +			printf("  Stats reg %2d RX-packets: %10"PRIu64
> +			       "    RX-errors: %10"PRIu64
> +			       "    RX-bytes: %10"PRIu64"\n",
> +			       i, stats.q_ipackets[i], stats.q_errors[i], stats.q_ibytes[i]);
> +		}
> +	}

Why restricting stats per queue to devices requiring a mapping?

> -		$(RTE_OUTPUT)/app/dump_cfg --file-prefix=ring_perf ; \

This should have been removed in previous patch.