All of lore.kernel.org
 help / color / mirror / Atom feed
From: Heiko Stuebner <heiko@sntech.de>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Liang Chen <cl@rock-chips.com>,
	frank-w@public-files.de
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: enable rk809 audio codec on the rk3568 evb1
Date: Wed, 23 Feb 2022 00:11:12 +0100	[thread overview]
Message-ID: <3287619.yDqD7nnjd0@phil> (raw)
In-Reply-To: <20220222175004.1308990-2-michael.riesch@wolfvision.net>

Hi,

Am Dienstag, 22. Februar 2022, 18:50:04 CET schrieb Michael Riesch:
> Enable the Rockchip RK809 audio codec on the Rockchip RK3568
> EVB1. This requires the VCCIO_ACODEC voltage regulator to be set
> to always on.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

[...]

> @@ -282,6 +301,7 @@ regulator-state-mem {
>  
>  			vccio_acodec: LDO_REG4 {
>  				regulator-name = "vccio_acodec";
> +				regulator-always-on;

As this seems to supply the codec (in the rk809?) shouldn't the
sound part model that relationship and handle regulators
instead of requiring an arbitary regulator to be always on?


Heiko

>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
>  
> @@ -366,6 +386,10 @@ regulator-state-mem {
>  				};
>  			};
>  		};
> +
> +		codec {
> +			mic-in-differential;
> +		};
>  	};
>  };
>  
> @@ -386,6 +410,11 @@ touchscreen0: goodix@14 {
>  	};
>  };
>  
> +&i2s1_8ch {
> +	rockchip,trcm-sync-tx-only;
> +	status = "okay";
> +};
> +
>  &mdio0 {
>  	rgmii_phy0: ethernet-phy@0 {
>  		compatible = "ethernet-phy-ieee802.3-c22";
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Liang Chen <cl@rock-chips.com>,
	frank-w@public-files.de
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: enable rk809 audio codec on the rk3568 evb1
Date: Wed, 23 Feb 2022 00:11:12 +0100	[thread overview]
Message-ID: <3287619.yDqD7nnjd0@phil> (raw)
In-Reply-To: <20220222175004.1308990-2-michael.riesch@wolfvision.net>

Hi,

Am Dienstag, 22. Februar 2022, 18:50:04 CET schrieb Michael Riesch:
> Enable the Rockchip RK809 audio codec on the Rockchip RK3568
> EVB1. This requires the VCCIO_ACODEC voltage regulator to be set
> to always on.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

[...]

> @@ -282,6 +301,7 @@ regulator-state-mem {
>  
>  			vccio_acodec: LDO_REG4 {
>  				regulator-name = "vccio_acodec";
> +				regulator-always-on;

As this seems to supply the codec (in the rk809?) shouldn't the
sound part model that relationship and handle regulators
instead of requiring an arbitary regulator to be always on?


Heiko

>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
>  
> @@ -366,6 +386,10 @@ regulator-state-mem {
>  				};
>  			};
>  		};
> +
> +		codec {
> +			mic-in-differential;
> +		};
>  	};
>  };
>  
> @@ -386,6 +410,11 @@ touchscreen0: goodix@14 {
>  	};
>  };
>  
> +&i2s1_8ch {
> +	rockchip,trcm-sync-tx-only;
> +	status = "okay";
> +};
> +
>  &mdio0 {
>  	rgmii_phy0: ethernet-phy@0 {
>  		compatible = "ethernet-phy-ieee802.3-c22";
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
	Michael Riesch <michael.riesch@wolfvision.net>
Cc: Rob Herring <robh+dt@kernel.org>,
	Michael Riesch <michael.riesch@wolfvision.net>,
	Liang Chen <cl@rock-chips.com>,
	frank-w@public-files.de
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: enable rk809 audio codec on the rk3568 evb1
Date: Wed, 23 Feb 2022 00:11:12 +0100	[thread overview]
Message-ID: <3287619.yDqD7nnjd0@phil> (raw)
In-Reply-To: <20220222175004.1308990-2-michael.riesch@wolfvision.net>

Hi,

Am Dienstag, 22. Februar 2022, 18:50:04 CET schrieb Michael Riesch:
> Enable the Rockchip RK809 audio codec on the Rockchip RK3568
> EVB1. This requires the VCCIO_ACODEC voltage regulator to be set
> to always on.
> 
> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>

[...]

> @@ -282,6 +301,7 @@ regulator-state-mem {
>  
>  			vccio_acodec: LDO_REG4 {
>  				regulator-name = "vccio_acodec";
> +				regulator-always-on;

As this seems to supply the codec (in the rk809?) shouldn't the
sound part model that relationship and handle regulators
instead of requiring an arbitary regulator to be always on?


Heiko

>  				regulator-min-microvolt = <3300000>;
>  				regulator-max-microvolt = <3300000>;
>  
> @@ -366,6 +386,10 @@ regulator-state-mem {
>  				};
>  			};
>  		};
> +
> +		codec {
> +			mic-in-differential;
> +		};
>  	};
>  };
>  
> @@ -386,6 +410,11 @@ touchscreen0: goodix@14 {
>  	};
>  };
>  
> +&i2s1_8ch {
> +	rockchip,trcm-sync-tx-only;
> +	status = "okay";
> +};
> +
>  &mdio0 {
>  	rgmii_phy0: ethernet-phy@0 {
>  		compatible = "ethernet-phy-ieee802.3-c22";
> 





  reply	other threads:[~2022-02-22 23:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 17:50 [PATCH 1/2] arm64: dts: rockchip: enable work led on rk3568-evb1 Michael Riesch
2022-02-22 17:50 ` Michael Riesch
2022-02-22 17:50 ` Michael Riesch
2022-02-22 17:50 ` [PATCH 2/2] arm64: dts: rockchip: enable rk809 audio codec on the rk3568 evb1 Michael Riesch
2022-02-22 17:50   ` Michael Riesch
2022-02-22 17:50   ` Michael Riesch
2022-02-22 23:11   ` Heiko Stuebner [this message]
2022-02-22 23:11     ` Heiko Stuebner
2022-02-22 23:11     ` Heiko Stuebner
2022-02-23  8:41     ` Michael Riesch
2022-02-23  8:41       ` Michael Riesch
2022-02-23  8:41       ` Michael Riesch
2022-02-22 23:27 ` (subset) [PATCH 1/2] arm64: dts: rockchip: enable work led on rk3568-evb1 Heiko Stuebner
2022-02-22 23:27   ` Heiko Stuebner
2022-02-22 23:27   ` Heiko Stuebner
2022-02-23 23:44 ` Heiko Stuebner
2022-02-23 23:44   ` Heiko Stuebner
2022-02-23 23:44   ` Heiko Stuebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3287619.yDqD7nnjd0@phil \
    --to=heiko@sntech.de \
    --cc=cl@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=frank-w@public-files.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=michael.riesch@wolfvision.net \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.