Re: [SPAM] [PATCH v1 06/16] hw/arm/aspeed: Correct fmc_model w25q80bl for ast1030-a1 EVB

["Cédric Le Goater" <clg@kaod.org>]

On 10/18/24 07:31, Jamin Lin wrote:
> Currently, the default fmc_model was "sst25vf032b" whose size was 4MB for
> ast1030-a1 EVB. However, according to the schematic of ast1030-a1 EVB,
> ASPEED shipped default flash of fmc_cs0 and fmc_cs1 were "w25q80bl" and
> "w25q256", respectively. The size of w25q80bl is 1MB and the size of w25q256
> is 32MB.
> 
> The fmc_cs0 was connected to AST1030 A1 internal flash and the fmc_cs1 was
> connected to external flash. The internal flash could not be changed because
> it was placed into AST1030 A1 chip. Users only can change fmc_cs1 external
> flash.
> 
> So far, only supports to set the default fmc_model for all chip select pins.
> In other words, users cannot set the different default flash model for
> fmc_cs0 and fmc_cs1, respectively.
> 
> Correct fmc_model default flash to w25q80bl the same as AST1030 A1
> internal flash for ast1030-a1 EVB.
> 
> Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>


Reviewed-by: Cédric Le Goater <clg@redhat.com>

Thanks,

C.


> ---
>   hw/arm/aspeed.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
> index bf68224295..b4b1ce9efb 100644
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -1642,7 +1642,7 @@ static void aspeed_minibmc_machine_ast1030_evb_class_init(ObjectClass *oc,
>       mc->init = aspeed_minibmc_machine_init;
>       amc->i2c_init = ast1030_evb_i2c_init;
>       mc->default_ram_size = 0;
> -    amc->fmc_model = "sst25vf032b";
> +    amc->fmc_model = "w25q80bl";
>       amc->spi_model = "w25q256";
>       amc->num_cs = 2;
>       amc->macs_mask = 0;