From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Wed, 26 Jul 2017 11:26:48 -0400 (EDT) Subject: [Cluster-devel] [GFS2 PATCH] GFS2: Don't bother trying to add rgrps to the lru list In-Reply-To: <598159098.34643831.1501082572029.JavaMail.zimbra@redhat.com> Message-ID: <329827946.34644924.1501082808245.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi, This patch removes a call to gfs2_glock_add_to_lru from function gfs2_clear_rgrpd, which is called when GFS2 is removing all the rgrps from memory. The call is just a waste of time because as soon as it adds it to the lru_list, the subsequent call to gfs2_glock_put takes it back off again. It doesn't make sense for the rgrps to ever be on the lru list anyway because gfs2_rgrp_glops doesn't even have the GLOF_LRU bit set (by design). Signed-off-by: Bob Peterson --- fs/gfs2/rgrp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c index 836e38ba5d0a..29fbeee36fa6 100644 --- a/fs/gfs2/rgrp.c +++ b/fs/gfs2/rgrp.c @@ -706,7 +706,6 @@ void gfs2_clear_rgrpd(struct gfs2_sbd *sdp) if (gl) { glock_set_object(gl, NULL); - gfs2_glock_add_to_lru(gl); gfs2_glock_put(gl); }