From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v3 0/5] add dpdk packet capture support for
	tcpdump
Date: Wed, 09 Mar 2016 01:33:36 +0100
Message-ID: <3298735.LFDh5RH4eW@xps13>
References: <1455289045-25915-1-git-send-email-reshma.pattan@intel.com>
 <1456920970-2047-1-git-send-email-reshma.pattan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org
To: Reshma Pattan <reshma.pattan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id 3A01A2BF4
 for <dev@dpdk.org>; Wed,  9 Mar 2016 01:35:15 +0100 (CET)
Received: by mail-wm0-f49.google.com with SMTP id p65so171606000wmp.1
 for <dev@dpdk.org>; Tue, 08 Mar 2016 16:35:15 -0800 (PST)
In-Reply-To: <1456920970-2047-1-git-send-email-reshma.pattan@intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

This series has not been reviewed enough to be ready for 16.04.
So it would be good to restart the discussion about the tcpdump requirements.

> packet capture flow for tcpdump:
> ================================
> Part of the design is implemented in secondary process (proc_info.c) and other part
> in primary process (eal_interrupt.c).

Why proc_info is used? Why not a dedicated tool?

> *User should request packet capture via proc_info application command line by passing newly
> added tcpdump command line options i.e. [--tcpdump (port,queue)] [ --src-ip-filter \"A.B.C.D\"]
> [--single-tcpdump-file].
> 
> Note: As basic support, a src ip filter option is provided for filtering the packets.
> This is optional. If user dont provide any src ip filter option all packets will be captured
> for tcpdump.

Why filtering? Why only on IP address? Why not BPF?

> 2: Because of the underlying pcap writing overhead packets can only be captured at slow rates.

What is the benefit of slow rate capture in DPDK?
Shouldn't we target a high rate mechanism?