All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: Jeff Daly <jeffd@silicom-usa.com>,
	"Wang, Haiyue" <haiyue.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: RE: [PATCH] doc: describe ixgbe devargs fiber_sdp3_no_tx_disable
Date: Fri, 29 Apr 2022 02:59:25 +0000	[thread overview]
Message-ID: <32b327d4ea08497295f7b68f6fd1d222@intel.com> (raw)
In-Reply-To: <20220427142040.24897-1-jeffd@silicom-usa.com>



> -----Original Message-----
> From: Jeff Daly <jeffd@silicom-usa.com>
> Sent: Wednesday, April 27, 2022 10:21 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org
> Subject: [PATCH] doc: describe ixgbe devargs fiber_sdp3_no_tx_disable
> 
> The devargs option for the IXGBE driver is introduced in order to inform the
> driver to skip checking SDP3 as an indicator of laser enable/disable for SFP
> modules.
> 
> Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
> ---
>  doc/guides/nics/ixgbe.rst | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/doc/guides/nics/ixgbe.rst b/doc/guides/nics/ixgbe.rst index
> 82fa453fa28e..ad1a3da6101e 100644
> --- a/doc/guides/nics/ixgbe.rst
> +++ b/doc/guides/nics/ixgbe.rst
> @@ -101,6 +101,23 @@ To guarantee the constraint, capabilities in
> dev_conf.rxmode.offloads will be ch
> 
>  fdir_conf->mode will also be checked.
> 
> +Disable SDP3 TX_DISABLE for Fiber Links
> +^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> +
> +The following ``devargs`` option can be enabled at runtime.  It must be
> +passed as part of EAL arguments. For example,
> +
> +.. code-block:: console
> +
> +   dpdk-testpmd -a fiber_sdp3_no_tx_disable=1 -- -i
> +
> +- ``fiber_sdp3_no_tx_disable`` (default **0**)
> +
> +  Not all IXGBE implementations with SFP cages use the SDP3 signal as
> + TX_DISABLE as a means to disable the laser on fiber SFP modules.
> +  This option informs the driver that in this case, SDP3 is not to be
> + used as a check for link up by testing for laser on/off.
> +
>  VF Runtime Options
>  ^^^^^^^^^^^^^^^^^^
> 
> --
> 2.25.1

Please squash the document update into the code path.


      reply	other threads:[~2022-04-29  2:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-27 14:20 [PATCH] doc: describe ixgbe devargs fiber_sdp3_no_tx_disable Jeff Daly
2022-04-29  2:59 ` Zhang, Qi Z [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32b327d4ea08497295f7b68f6fd1d222@intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=jeffd@silicom-usa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.