All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <tj@kernel.org>
To: Petr Malat <oss@malat.biz>
Cc: cgroups@vger.kernel.org, Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH] cgroup: Increment dying descendants from rmdir context
Date: Wed, 22 Apr 2026 07:14:41 -1000	[thread overview]
Message-ID: <32f69d774f9aaac90d588567e1fcd880@kernel.org> (raw)
In-Reply-To: <CANMuvJnpVSHNJ1=6Auw7zYnZ9w32J0mn+dw6PkdXi-WDU4Lrqg@mail.gmail.com>

Hello Petr,

Thanks for the patch - the fix itself looks good to me. One thing
worth clarifying in the subject and changelog: the counters this
patch actually moves are cgroup->nr_dying_subsys[] and the per-css
nr_descendants walk, which surface as nr_dying_subsys_<name> and
nr_subsys_<name> in cgroup.stat. The top-level nr_dying_descendants
is already incremented synchronously in cgroup_destroy_locked() under
css_set_lock, so it's not the one that was racy.

Could you respin with the subject and description updated to name
the actual counters? That'd make the intent clearer for future
readers.

Thanks.

--
tejun

  reply	other threads:[~2026-04-22 17:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-22 13:57 [PATCH] cgroup: Increment dying descendants from rmdir context Petr Malat
2026-04-22 17:14 ` Tejun Heo [this message]
2026-04-23  9:48   ` [PATCH v2] cgroup: Increment nr_dying_subsys_* " Petr Malat
2026-04-23 19:22     ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32f69d774f9aaac90d588567e1fcd880@kernel.org \
    --to=tj@kernel.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=oss@malat.biz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.