From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 914E9C4338F for ; Mon, 2 Aug 2021 09:36:58 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4EF3561057 for ; Mon, 2 Aug 2021 09:36:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4EF3561057 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=70JBLbk+qNqIuVIvS0T3lHD4quvB6FwaTCBM4KeRxM0=; b=k/pjUDTXYaUDU40ZkSgNynU02Y rueQfueZKM4WIt9pJ8rLYReQc4Khrw3/FkyUt4EJw31r1DQWE1pSSJBopu5PZV9zHcG47Uzt+x4QI Yk6sd2/PXe7mlYi1xcDBk8VJZK5qceLq/72nI4NXO+Nsw2qCFN33XKyRzLRJrsJNXJMRlyIh8ghZM 6CIu++pSE3Ap7qme8v6/Tuk9yhzIGPXHlwCOJ1XamvQ1aP/zeXnpsVWi2eNrQDUibaPgf6d5ym72/ PaKa+vH8qNkEGo5zS66MjCcS+WNZASZ9HjPcvqbHk9MjEjbblSrdj/1MEeXAfwuneZrGj9lW5ILKa r7P7t9tA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAULw-00FZ31-J1; Mon, 02 Aug 2021 09:35:20 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mAULr-00FZ29-F5 for linux-arm-kernel@lists.infradead.org; Mon, 02 Aug 2021 09:35:17 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A996061057; Mon, 2 Aug 2021 09:35:14 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAULo-002PoM-Kq; Mon, 02 Aug 2021 10:35:12 +0100 MIME-Version: 1.0 Date: Mon, 02 Aug 2021 10:35:12 +0100 From: Marc Zyngier To: Anshuman Khandual Cc: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, mark.rutland@arm.com Subject: Re: [PATCH 10/10] arm64: errata: Add workaround for TSB flush failures In-Reply-To: <477c4943-7c35-8502-0291-4c0ed3a03905@arm.com> References: <20210728135217.591173-1-suzuki.poulose@arm.com> <20210728135217.591173-11-suzuki.poulose@arm.com> <87mtq5a1gs.wl-maz@kernel.org> <477c4943-7c35-8502-0291-4c0ed3a03905@arm.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <32f719c8f9f61b244b3fc29137f76a19@kernel.org> X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210802_023515_567739_70AD8F20 X-CRM114-Status: GOOD ( 16.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gMjAyMS0wOC0wMiAxMDoxMiwgQW5zaHVtYW4gS2hhbmR1YWwgd3JvdGU6Cj4gT24gNy8yOS8y MSA0OjExIFBNLCBTdXp1a2kgSyBQb3Vsb3NlIHdyb3RlOgo+PiBPbiAyOS8wNy8yMDIxIDEwOjU1 LCBNYXJjIFp5bmdpZXIgd3JvdGU6Cj4+PiBPbiBXZWQsIDI4IEp1bCAyMDIxIDE0OjUyOjE3ICsw MTAwLAo+Pj4gU3V6dWtpIEsgUG91bG9zZSA8c3V6dWtpLnBvdWxvc2VAYXJtLmNvbT4KClsuLi5d Cgo+Pj4+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIF9fdHNiX2NzeW5jKCk7wqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4+Pj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqAgX190c2JfY3N5bmMoKTvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgIFwKPj4+PiArwqDCoMKgwqDCoMKgwqAgfSBlbHNlIHvCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgXAo+Pj4+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIF9fdHNiX2NzeW5jKCk7wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4+Pj4gK8KgwqDCoMKgwqDCoMKgIH3CoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBcCj4+PiAK Pj4+IG5pdDogWW91IGNvdWxkIGtlZXAgb25lIHVuY29uZGl0aW9uYWwgX190c2JfY3N5bmMoKS4K Pj4gCj4+IEkgdGhvdWdodCBhYm91dCB0aGF0LCBJIHdhcyB3b3JyaWVkIGlmIHRoZSBDUFUgZXhw ZWN0cyB0aGVtIGJhY2sgdG8gCj4+IGJhY2sKPj4gd2l0aG91dCBhbnkgb3RoZXIgaW5zdHJ1Y3Rp b25zIGluIGJldHdlZW4gdGhlbS4gVGhpbmtpbmcgYWJvdXQgaXQgYSAKPj4gYml0Cj4+IG1vcmUs IGl0IGRvZXNuJ3QgbG9vayBsaWtlIHRoYXQgaXMgdGhlIGNhc2UuIEkgd2lsbCBjb25maXJtIHRo aXMgYW5kCj4+IGNoYW5nZSBpdCBhY2NvcmRpbmdseS4KPiBCdXQgaXRzIGEgdmVyeSBzdWJ0bGUg Y2hhbmdlIHdoaWNoIG1pZ2h0IGJlIGRpZmZpY3VsdCB0byBkZWJ1ZyBhbmQgCj4gYmxhbWUKPiBs YXRlciBvbiwgaWYgaW5kZWVkIGJvdGggdGhlIGluc3RydWN0aW9ucyBuZWVkIHRvIGJlIGJhY2sg dG8gYmFjay4gCj4gU2VlbXMKPiBsaWtlIGp1c3QgYmV0dGVyIHRvIGxlYXZlIHRoaXMgdW5jaGFu Z2VkLgoKSXMgdGhhdCBhbiBhY3R1YWwgcmVxdWlyZW1lbnQ/IFNvdW5kcyBsaWtlIHlvdSB3YW50 IHRvIGZpbmQgb3V0CmZyb20gdGhlIGVycmF0YSBkb2N1bWVudC4KCkFuZCBpZiB0aGV5IGFjdHVh bGx5IG5lZWQgdG8gYmUgYmFjayB0byBiYWNrLCB3aGF0IGVuc3VyZXMgdGhhdAp0aGlzIGlzIGFs d2F5cyBjYWxsZWQgd2l0aCBpbnRlcnJ1cHQgZGlzYWJsZWQ/CgpZb3Ugd291bGQgYWxzbyBuZWVk IHRvIGhhdmUgdGhlbSBpbiB0aGUgc2FtZSBhc20gYmxvY2sgdG8gYXZvaWQKdGhlIGNvbXBpbGVy IHJlb3JkZXJpbmcgc3R1ZmYuCgogICAgICAgICBNLgotLSAKSmF6eiBpcyBub3QgZGVhZC4gSXQg anVzdCBzbWVsbHMgZnVubnkuLi4KCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6B09C4338F for ; Mon, 2 Aug 2021 09:35:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 85E61610CC for ; Mon, 2 Aug 2021 09:35:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233022AbhHBJf0 (ORCPT ); Mon, 2 Aug 2021 05:35:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:40252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231460AbhHBJfX (ORCPT ); Mon, 2 Aug 2021 05:35:23 -0400 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A996061057; Mon, 2 Aug 2021 09:35:14 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mAULo-002PoM-Kq; Mon, 02 Aug 2021 10:35:12 +0100 MIME-Version: 1.0 Date: Mon, 02 Aug 2021 10:35:12 +0100 From: Marc Zyngier To: Anshuman Khandual Cc: Suzuki K Poulose , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, mark.rutland@arm.com Subject: Re: [PATCH 10/10] arm64: errata: Add workaround for TSB flush failures In-Reply-To: <477c4943-7c35-8502-0291-4c0ed3a03905@arm.com> References: <20210728135217.591173-1-suzuki.poulose@arm.com> <20210728135217.591173-11-suzuki.poulose@arm.com> <87mtq5a1gs.wl-maz@kernel.org> <477c4943-7c35-8502-0291-4c0ed3a03905@arm.com> User-Agent: Roundcube Webmail/1.4.11 Message-ID: <32f719c8f9f61b244b3fc29137f76a19@kernel.org> X-Sender: maz@kernel.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: anshuman.khandual@arm.com, suzuki.poulose@arm.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, coresight@lists.linaro.org, will@kernel.org, catalin.marinas@arm.com, james.morse@arm.com, mathieu.poirier@linaro.org, mike.leach@linaro.org, leo.yan@linaro.org, mark.rutland@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-08-02 10:12, Anshuman Khandual wrote: > On 7/29/21 4:11 PM, Suzuki K Poulose wrote: >> On 29/07/2021 10:55, Marc Zyngier wrote: >>> On Wed, 28 Jul 2021 14:52:17 +0100, >>> Suzuki K Poulose [...] >>>> +            __tsb_csync();                        \ >>>> +            __tsb_csync();                        \ >>>> +        } else {                            \ >>>> +            __tsb_csync();                        \ >>>> +        }                                \ >>> >>> nit: You could keep one unconditional __tsb_csync(). >> >> I thought about that, I was worried if the CPU expects them back to >> back >> without any other instructions in between them. Thinking about it a >> bit >> more, it doesn't look like that is the case. I will confirm this and >> change it accordingly. > But its a very subtle change which might be difficult to debug and > blame > later on, if indeed both the instructions need to be back to back. > Seems > like just better to leave this unchanged. Is that an actual requirement? Sounds like you want to find out from the errata document. And if they actually need to be back to back, what ensures that this is always called with interrupt disabled? You would also need to have them in the same asm block to avoid the compiler reordering stuff. M. -- Jazz is not dead. It just smells funny...